From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 20027D5B16F for ; Mon, 15 Dec 2025 13:52:02 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id CECDE40647; Mon, 15 Dec 2025 13:52:01 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id IEQRm6RJ5Aq8; Mon, 15 Dec 2025 13:51:59 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org CD18340632 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1765806719; bh=5xOfSsOHTJVPT/asFcBzsToAdyh5F43Xil3FQ+PqXO4=; h=Date:To:References:From:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=jsbc4g4GtjoMrhrDIIrsAyf9Twel/tiBGTQoAtREICo0pN0jczSJs/cwu/oFjT25o cbWCBu/GHfLTcSipzbSFx4iC30lylFLdD8RypXSy7d6r7kIcjY7zW/3INTEbxUPF96 t8wj3/Juv5BCiSWoRrB/0OsC5qdV7U3qzB+FouHc6SZW5UH52oLA38qs0d/vPpnAfn /pdSVMsygnJ6rkUejPEzxDJ/jhq8ywgGlnVJ1J0dECEXAQFKg5iRirsN9gaC4/1CdF ZhbdRP3167qmjtC8sblKIrV36VHq5woxI3pyTshGV2JfzBKnd3gGbHOa00CMggjEHb 3xNEReRqHe67g== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id CD18340632; Mon, 15 Dec 2025 13:51:59 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists1.osuosl.org (Postfix) with ESMTP id 06526272 for ; Mon, 15 Dec 2025 13:51:59 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id DFF92407E1 for ; Mon, 15 Dec 2025 13:51:58 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id FMOeyEP1gE2W for ; Mon, 15 Dec 2025 13:51:58 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=170.10.129.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=ivecera@redhat.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org CF50A407D9 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org CF50A407D9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by smtp2.osuosl.org (Postfix) with ESMTPS id CF50A407D9 for ; Mon, 15 Dec 2025 13:51:57 +0000 (UTC) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-537-EpkNGB0SNJqMAM5A8UhPHw-1; Mon, 15 Dec 2025 08:51:51 -0500 X-MC-Unique: EpkNGB0SNJqMAM5A8UhPHw-1 X-Mimecast-MFC-AGG-ID: EpkNGB0SNJqMAM5A8UhPHw_1765806708 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AD1AC1800624; Mon, 15 Dec 2025 13:51:46 +0000 (UTC) Received: from [10.44.34.139] (unknown [10.44.34.139]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 86067180045B; Mon, 15 Dec 2025 13:51:38 +0000 (UTC) Message-ID: Date: Mon, 15 Dec 2025 14:51:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Jiri Pirko References: <20251211194756.234043-1-ivecera@redhat.com> <20251211194756.234043-3-ivecera@redhat.com> <3E2869EC-61B3-40DA-98E2-CD9543424468@redhat.com> Content-Language: en-US From: Ivan Vecera In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1765806716; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5xOfSsOHTJVPT/asFcBzsToAdyh5F43Xil3FQ+PqXO4=; b=Zy2F0cCeUeuDw8hacFZdd4D6bhJiSeHDbi8MYL+mJZVMt5KprMfjNpCShwAYKmN+FiH+Bt iYFslz9fMns8BXuajlOhmuxLDajOUWLi2AFBK+rwKETMsHyMKbvlAwFe5l7IsLvOZrhOUk 8im1gsKVaIQ7cblO9jmf9THbvL3TWV0= X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Zy2F0cCe Subject: Re: [Intel-wired-lan] [PATCH RFC net-next 02/13] dpll: Allow registering pin with firmware node X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eric Dumazet , Tony Nguyen , Rob Herring , Leon Romanovsky , Alexander Lobakin , linux-rdma@vger.kernel.org, Przemek Kitszel , Arkadiusz Kubalewski , intel-wired-lan@lists.osuosl.org, Jakub Kicinski , Paolo Abeni , devicetree@vger.kernel.org, Conor Dooley , Richard Cochran , Prathosh Satish , Willem de Bruijn , Vadim Fedorenko , netdev@vger.kernel.org, Mark Bloch , linux-kernel@vger.kernel.org, Tariq Toukan , Andrew Lunn , Stefan Wahren , Simon Horman , Jonathan Lemon , Krzysztof Kozlowski , Saeed Mahameed , "David S. Miller" Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On 12/15/25 2:08 PM, Jiri Pirko wrote: > Sun, Dec 14, 2025 at 08:35:01PM +0100, ivecera@redhat.com wrote: >> >> >> On December 12, 2025 12:25:12 PM GMT+01:00, Jiri Pirko wrote: >>> Thu, Dec 11, 2025 at 08:47:45PM +0100, ivecera@redhat.com wrote: >>> >>> [..] >>> >>>> @@ -559,7 +563,8 @@ EXPORT_SYMBOL(dpll_netdev_pin_clear); >>>> */ >>>> struct dpll_pin * >>>> dpll_pin_get(u64 clock_id, u32 pin_idx, struct module *module, >>>> - const struct dpll_pin_properties *prop) >>>> + const struct dpll_pin_properties *prop, >>>> + struct fwnode_handle *fwnode) >>>> { >>>> struct dpll_pin *pos, *ret = NULL; >>>> unsigned long i; >>>> @@ -568,14 +573,15 @@ dpll_pin_get(u64 clock_id, u32 pin_idx, struct module *module, >>>> xa_for_each(&dpll_pin_xa, i, pos) { >>>> if (pos->clock_id == clock_id && >>>> pos->pin_idx == pin_idx && >>>> - pos->module == module) { >>>> + pos->module == module && >>>> + pos->fwnode == fwnode) { >>> >>> Is fwnode part of the key? Doesn't look to me like that. Then you can >>> have a simple helper to set fwnode on struct dpll_pin *, and leave >>> dpll_pin_get() out of this, no? >> >> IMHO yes, because particular fwnode identifies exact dpll pin, so >> I think it should be a part of the key. > > The key items serve for userspace identification purposes as well. For > that, fwnode is non-sense. > fwnode identifies exact pin, that is nice. But is it the only > differentiator among other key items? I don't expect so. From this point of view, not. I will not touch dpll_pin_get() and rather use new helper like dpll_pin_fwnode_set(), ok? Thanks, Ivan