From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: Jedrzej Jagielski <jedrzej.jagielski@intel.com>,
<intel-wired-lan@lists.osuosl.org>
Cc: Brett Creeley <brett@pensando.io>,
Brett Creeley <brett.creeley@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH net-next v1] iavf: Add helper to check if iavf_remove() is in progress
Date: Fri, 3 Jun 2022 11:00:22 -0700 [thread overview]
Message-ID: <ef312927-bded-682f-95f5-e0d9e6bd770d@intel.com> (raw)
In-Reply-To: <20220603085210.2862148-1-jedrzej.jagielski@intel.com>
On 6/3/2022 1:52 AM, Jedrzej Jagielski wrote:
> From: Brett Creeley <brett@pensando.io>
>
> Currently the driver checks if the __IAVF_IN_REMOVE_TASK bit is set in
> the adapter's crit_section bitmap. This is fine, but if the
> implementation were to ever change, i.e. a mutex was introduced all of
> the callers of test_bit(__IAVF_IN_REMOVE_TASK, &adapter->crit_section)
> would have to change. Fix this by introducing the
> iavf_is_remove_in_progress() helper function.
>
> Signed-off-by: Brett Creeley <brett.creeley@intel.com>
The author and Sign-off need to match exactly:
WARNING: From:/Signed-off-by: email address mismatch: 'From: Brett
Creeley <brett@pensando.io>' != 'Signed-off-by: Brett Creeley
<brett.creeley@intel.com>'
> Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@intel.com>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
prev parent reply other threads:[~2022-06-03 18:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 8:52 [Intel-wired-lan] [PATCH net-next v1] iavf: Add helper to check if iavf_remove() is in progress Jedrzej Jagielski
2022-06-03 18:00 ` Tony Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef312927-bded-682f-95f5-e0d9e6bd770d@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=brett.creeley@intel.com \
--cc=brett@pensando.io \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jedrzej.jagielski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox