From: Jacob Keller <jacob.e.keller@intel.com>
To: <intel-wired-lan@osuosl.org>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v7 1/2] ice: Remove unnecessary argument from ice_fdir_comp_rules()
Date: Wed, 14 Feb 2024 15:42:12 -0800 [thread overview]
Message-ID: <f1d22f31-48bd-4b2a-b841-8cef82fe65a0@intel.com> (raw)
In-Reply-To: <20240212110307.12704-2-lukasz.plachno@intel.com>
On 2/12/2024 3:03 AM, Lukasz Plachno wrote:
> Passing v6 argument is unnecessary as flow_type is still
> analyzed inside the function.
>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Signed-off-by: Lukasz Plachno <lukasz.plachno@intel.com>
> Reviewed-by: Simon Horman <horms@kernel.org>
Good cleanup.
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
next prev parent reply other threads:[~2024-02-14 23:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-12 11:03 [Intel-wired-lan] [PATCH iwl-next v7 0/2] ice: Support flow director ether type filters Lukasz Plachno
2024-02-12 11:03 ` [Intel-wired-lan] [PATCH iwl-next v7 1/2] ice: Remove unnecessary argument from ice_fdir_comp_rules() Lukasz Plachno
2024-02-14 23:42 ` Jacob Keller [this message]
2024-02-12 11:03 ` [Intel-wired-lan] [PATCH iwl-next v7 2/2] ice: Implement 'flow-type ether' rules Lukasz Plachno
2024-02-14 23:47 ` Jacob Keller
2024-02-14 23:50 ` Jacob Keller
2024-02-29 11:59 ` Plachno, Lukasz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1d22f31-48bd-4b2a-b841-8cef82fe65a0@intel.com \
--to=jacob.e.keller@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox