Re: [Intel-wired-lan] [PATCH net-next v1] ice: Allow 100M speeds for some devices

[Tony Nguyen <anthony.l.nguyen@intel.com>]

On 7/27/2022 3:42 AM, Mikael Barsehyan wrote:
> From: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>
> 
> For certain devices, 100M speeds are supported. Do not mask off
> 100M speed for these devices.
> 
> Signed-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>
> Signed-off-by: Chinh T Cao <chinh.t.cao@intel.com>

I believe Chinh is a co-developer? If so, this should also have:
Co-developed-by: Chinh T Cao <chinh.t.cao@intel.com> above his sign-off.

> Signed-off-by: Mikael Barsehyan <mikael.barsehyan@intel.com>
> ---

<snip>

> @@ -1503,6 +1503,7 @@ ice_get_ethtool_stats(struct net_device *netdev,
>   
>   /**
>    * ice_mask_min_supported_speeds
> + * @hw: pointer to the HW structure
>    * @phy_types_high: PHY type high
>    * @phy_types_low: PHY type low to apply minimum supported speeds mask
>    *
> @@ -1510,13 +1511,14 @@ ice_get_ethtool_stats(struct net_device *netdev,
>    * for ethtool supported link mode.
>    */
>   static
> -void ice_mask_min_supported_speeds(u64 phy_types_high, u64 *phy_types_low)
> +void ice_mask_min_supported_speeds(struct ice_hw *hw,
> +				   u64 phy_types_high, u64 *phy_types_low)

Not from this patch, but it would be nice to fix this format instead of 
continuing with it.


static void
ice_mask_min_supported_speeds(...)

>   {
>   	/* if QSFP connection with 100G speed, minimum supported speed is 25G */
>   	if (*phy_types_low & ICE_PHY_TYPE_LOW_MASK_100G ||
>   	    phy_types_high & ICE_PHY_TYPE_HIGH_MASK_100G)
>   		*phy_types_low &= ~ICE_PHY_TYPE_LOW_MASK_MIN_25G;
> -	else
> +	else if (!ice_is_100m_speed_supported(hw))
>   		*phy_types_low &= ~ICE_PHY_TYPE_LOW_MASK_MIN_1G;
>   }
>   
> @@ -1566,7 +1568,8 @@ ice_phy_type_to_ethtool(struct net_device *netdev,
>   		phy_types_low = le64_to_cpu(pf->nvm_phy_type_lo);
>   		phy_types_high = le64_to_cpu(pf->nvm_phy_type_hi);
>   
> -		ice_mask_min_supported_speeds(phy_types_high, &phy_types_low);
> +		ice_mask_min_supported_speeds(&pf->hw, phy_types_high,
> +					      &phy_types_low);
>   		/* determine advertised modes based on link override only
>   		 * if it's supported and if the FW doesn't abstract the
>   		 * driver from having to account for link overrides
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan