From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 003C2606A31A for ; Mon, 26 Oct 2026 23:48:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256 header.s=default header.b=5c3duSbS; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=E3e0Unu5 Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id D5C744050C; Mon, 26 Oct 2026 23:48:26 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id YiX-Dj7BQxD9; Mon, 26 Oct 2026 23:48:26 +0000 (UTC) ARC-Filter: OpenARC Filter v1.3.2 smtp4.osuosl.org 0F4444056E Authentication-Results: smtp4.osuosl.org; arc=fail smtp.remote-ip=140.211.166.142 ARC-Seal: i=3; d=osuosl.org; s=arc; a=rsa-sha256; cv=fail; t=1793058506; b=OM18MmIb8EqKWKhwCRUegq6JPrqKDVW4UAkxHdxPtUKwGcQo82+ui92/8uwfPioNoAJo 8k9WTT7/DbJCGkzsaaolRDGY9M48vYsz+MHXNNZc0BXJxZN1LEB9d2cwAOWQhTSxCUoHS IIXNdF2TDZv3cdAGOZx4Mnu+YW9gSYzK+z21i7RsihMT0Nsl+uCQW5NChIBSBGmJe/M0L Nkd5gbESWR93eUhjgMBKGxU82mNhl7wRHBPSn3jXcXHPUuB+8P63P7uGE9AaOARhTbTKd garR4nEizpWxR2BwgfTrf81Wtrot8ZKaLPRin6LH5kaant3Xo5eBjZHwyD00psuGSxQ== ARC-Message-Signature: i=3; d=osuosl.org; s=arc; a=rsa-sha256; c=relaxed/relaxed; t=1793058506; h=X-Comment:DKIM-Signature:X-Original-To:Delivered-To:Received: Received:X-Virus-Scanned:X-Spam-Flag:X-Spam-Score:X-Spam-Level: X-Spam-Status:Received:ARC-Filter:Received-SPF:Received: DKIM-Signature:X-CSE-ConnectionGUID:X-CSE-MsgGUID:X-IronPort-AV: X-IronPort-AV:Received:X-CSE-ConnectionGUID:X-CSE-MsgGUID:X-ExtLoop1: X-IronPort-AV:Received:Received:Received:Received:Received:Received: Message-ID:Date:User-Agent:Subject:To:References:From: Content-Language:In-Reply-To:Content-Type:Content-Transfer-Encoding: X-ClientProxiedBy:MIME-Version:X-MS-PublicTrafficType: X-MS-TrafficTypeDiagnostic:X-MS-Office365-Filtering-Correlation-Id: X-MS-Exchange-SenderADCheck:X-MS-Exchange-AntiSpam-Relay: X-Microsoft-Antispam:X-Microsoft-Antispam-Message-Info: X-Forefront-Antispam-Report: X-MS-Exchange-AntiSpam-MessageData-ChunkCount: X-MS-Exchange-AntiSpam-MessageData-0:X-Exchange-RoutingPolicyChecked: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-AuthSource:X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-OriginalArrivalTime: X-MS-Exchange-CrossTenant-FromEntityHeader: X-MS-Exchange-CrossTenant-Id:X-MS-Exchange-CrossTenant-MailboxType: X-MS-Exchange-CrossTenant-UserPrincipalName: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg: X-BeenThere:X-Mailman-Version:Precedence:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:Errors-To; bh=ydBFyts4vqx0nI1SLurNcSLMfKUmjdZNw5PHS9EczgU=; b=Q7+Wixu0bdyyoo8ReCWoevruQzJQxZZeYd3RrOe0ci5qnJeaDkroskU2r86pxASAccxh KLZG3YGIVgYzl1c4QJ0BN2fj9F7AWxOQXpZ8ry+Z4N3hOVcxomEaRVuxfkSDqei7itia1 g9DA21fgvqsk8cad3kXsMj8R/6KhUd6DvWOz4jQuVDuCq84mn+OCg0f7EH6M/JrnOoTh9 JNFQzz1pIJoxXwEUTncMdN/s+rGHphwwAWQi7nDBLBqsH1qarBq99fO2xfiwHKCROMO+B dmaZ1n0SX7LTNE5HwzLrXwcmh5bxa5AfeL10N7A5smqtBCl+ngqOg1/6Ca2cHT1RjzA== ARC-Authentication-Results: i=3; smtp4.osuosl.org; arc=fail smtp.remote-ip=140.211.166.142 X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1793058506; bh=ydBFyts4vqx0nI1SLurNcSLMfKUmjdZNw5PHS9EczgU=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=5c3duSbSTtAkGLPIB0TE6Uf6XyBz8xhkrMcQ9KLz4JrA52t6n7evQYK/eKrC+Ekrw B0IdfNOnhHLThyhr1f8csEryNnqvkFtBzx+DbBxgadDSLWyXk5MFhQ/HTif1iht3Mz 9hPYJf+WqUqp3VWVLnNaEm1RSEpFSThZHMQFcyMLv65jMXzKACIg/0ftQ1p+Al3Iau Dh+Xh7ggWZboTLtQ9Th3PPcuAIWASgw4fXoPWG9tnXaVixkjSGTgv0WtG1/S0fUUY/ o8FnfXl720kCRUUBmwx2JdXdFVC0I2ZX3t5TBZHHluFa0D3rJeAxqMX8z7FolaVbYK tDUggn/rq2i9A== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id 0F4444056E; Mon, 26 Oct 2026 23:48:26 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists1.osuosl.org (Postfix) with ESMTP id 89EDE3421 for ; Mon, 26 Oct 2026 23:48:23 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 7B90180BBE for ; Mon, 26 Oct 2026 23:48:23 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id rlVShBEstncC for ; Mon, 26 Oct 2026 23:48:22 +0000 (UTC) ARC-Filter: OpenARC Filter v1.3.2 smtp1.osuosl.org 61F0680BBD Authentication-Results: smtp1.osuosl.org; arc=fail smtp.remote-ip=192.198.163.14 ARC-Seal: i=2; d=osuosl.org; s=arc; a=rsa-sha256; cv=fail; t=1793058502; b=iRAJxXXpgRgjubzw/EkLH2RSiWTRkaUBXiyPizo5DEDsmnPjyFMzAn3hjvqQah6QumTa VvtIWDigmBFcjzIrFxYhbL/VHJ9hLBgyzw9Sfc56zSJht17Ra4s+8f74VSKZocXja+Wdi 38aVAA/8VE0qUiHGm6kktU12zZGAuOX+O2p8QKu4HfDBzrrx/qqm64uZaFK7j8iiKthVP fqI+vcy9W1oRoExAiCsANU5hDxugg075Y87ppKZm/qlZszbSoH90Q0NkK1LBPg7JjiDde wLhcBw2bqcTLWvOB6d754bFdnB5sMn5c9ipT8STvPCJyNjfrWqHsmlokz/QeZ0pfk1g== ARC-Message-Signature: i=2; d=osuosl.org; s=arc; a=rsa-sha256; c=relaxed/relaxed; t=1793058502; h=Received-SPF:DKIM-Signature:X-CSE-ConnectionGUID:X-CSE-MsgGUID: X-IronPort-AV:X-IronPort-AV:Received:X-CSE-ConnectionGUID: X-CSE-MsgGUID:X-ExtLoop1:X-IronPort-AV:Received:Received:Received: Received:Received:Received:Message-ID:Date:User-Agent:Subject:To: References:From:Content-Language:In-Reply-To:Content-Type: Content-Transfer-Encoding:X-ClientProxiedBy:MIME-Version: X-MS-PublicTrafficType:X-MS-TrafficTypeDiagnostic: X-MS-Office365-Filtering-Correlation-Id:X-MS-Exchange-SenderADCheck: X-MS-Exchange-AntiSpam-Relay:X-Microsoft-Antispam: X-Microsoft-Antispam-Message-Info:X-Forefront-Antispam-Report: X-MS-Exchange-AntiSpam-MessageData-ChunkCount: X-MS-Exchange-AntiSpam-MessageData-0:X-Exchange-RoutingPolicyChecked: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-AuthSource:X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-OriginalArrivalTime: X-MS-Exchange-CrossTenant-FromEntityHeader: X-MS-Exchange-CrossTenant-Id:X-MS-Exchange-CrossTenant-MailboxType: X-MS-Exchange-CrossTenant-UserPrincipalName: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; bh=ydBFyts4vqx0nI1SLurNcSLMfKUmjdZNw5PHS9EczgU=; b=sf5Z9XRad65BrJWm1nDNHQmGtuxKcvIq/7u/4lcoVGZ5aCEfIs4IFJ7jrmKgaFbRUZzC MjfVh72MN1BUa/bfCoa45EUCNlFxsyzjrybkw/IWWmgluUUt1ufYgWVgtqBatVYJhmm96 EwFgXQ7PdFYTvSWImODNPozQRrw/RFG9l/z+3Az/p4PkzVm5H9WspZV8MKmEEr6iSspbc LvTMY1tFSH6puYADAs34uWK8okycH+rlIsmPvcHjxcWiavZ1o5EpmgUZ9orRxrvlmLLKC hvPoK/XjyXJqqucSb9YL6lMlTryRb8maScKFXkjmXKD0RUotNjkPKZ8QWu+E14woZ+w== ARC-Authentication-Results: i=2; smtp1.osuosl.org; dmarc=pass header.from=intel.com; dkim=pass header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=E3e0Unu5; arc=fail smtp.remote-ip=192.198.163.14 Received-SPF: None (mailfrom) identity=mailfrom; client-ip=192.198.163.14; helo=mgamail.intel.com; envelope-from=jacob.e.keller@intel.com; receiver= Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=E3e0Unu5 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) by smtp1.osuosl.org (Postfix) with ESMTPS id 61F0680BBD for ; Mon, 26 Oct 2026 23:48:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1793058503; x=1824594503; h=message-id:date:subject:to:references:from:in-reply-to: content-transfer-encoding:mime-version; bh=GZ3AraRf87VJYK1CEMaGET5Pr/tR0wxymgazYvdgvGU=; b=E3e0Unu5VODPAYA/41FroTrBy2f3+PcomyKt3RtdNKKuXkdLbuXzLCMx UPrDBfj/Nmlt1REPI55eBvaiBYvgb+pL3+b2GJGPLYh9TWjaDdbseJ0vI hGOqnqW1wcPgVF6bs17SWT6z0vTkxNlm69rtjiV7iuM6eD80C6RxcILlT xC+Ay3w760kfyvyIHeGTYoxaboKvWogFx5QbSNPoKUV2p/41pyph+7kuL cbA+bRxXUbzQqBAKvHQswKqvTGs+GHT59vpg1XugQ4x5lZ/ieqrIHlHvk AuZ1QwrXyQqghe8xAZMc7toCBevok7SMgr9rc7vubWIZNOBg281a/JiE8 A==; X-CSE-ConnectionGUID: 0CmDITgIQG63Ej7f6gbZWg== X-CSE-MsgGUID: WeNyE2WtQ16K3dqDp7ByHQ== X-IronPort-AV: E=McAfee;i="6800,10657,11947"; a="1775879" X-IronPort-AV: E=Sophos;i="6.27,180,1787036400"; d="scan'208";a="1775879" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2026 16:48:21 -0700 X-CSE-ConnectionGUID: Pmixi+d1SJOs0+Pzg5i/Vg== X-CSE-MsgGUID: mQvkUL6VSTiLhJuRpOlyOg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,180,1787036400"; d="scan'208";a="4549734" Received: from orsmsx902.amr.corp.intel.com ([10.22.229.24]) by fmviesa005.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2026 16:48:22 -0700 Received: from ORSMSX902.amr.corp.intel.com (10.22.229.24) by ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.49; Mon, 26 Oct 2026 16:48:20 -0700 Received: from ORSEDG902.ED.cps.intel.com (10.7.248.12) by ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.49 via Frontend Transport; Mon, 26 Oct 2026 16:48:20 -0700 Received: from PH7PR06CU001.outbound.protection.outlook.com (52.101.201.64) by edgegateway.intel.com (134.134.137.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.49; Mon, 26 Oct 2026 16:48:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=aWIASX6q7CiqsSQ04HjET43Gb9I+V1AkRylM0RMpdMIFvy2lL6eulpO61KM0DCjJ58Cxp05gsmngPUjNuSCvzRS/JOSD6AORcTeOn/ozxspYfQhC5s3dpaspti2izP2YLEezsgt48+0uX9LsTqwl3auMJu0RISkgUrkpxLL+DLOTba0cJZTFF68F7NR6OwszgEzgNoDlsMZ+ASsF+MfTFYUQrGxop7z1B3DH4P37FoIooZA0JVO0Uc+Yi3MNqg9VQRbEZcuwFN+OeA9zTIgQf4wndHuI0ZheApI3H0IuqZXiMBHuH3TSQyLvu2w14M/aqGcQ1R+50nU85wfiVnJ99g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ydBFyts4vqx0nI1SLurNcSLMfKUmjdZNw5PHS9EczgU=; b=skaXCRY2WSQ3JyQyid5npQA/YYZGyEiCvPNrVJkJzGSyLIArUMiq9I+/zeFEG0xqc9R4HAVyNX5Uvqv0+sjNfT76XWR3FQL6rp2AyeLzo/4cEV9J8oPJJ+4Ucb/0qtiu0NvPKsFXnKmkj64LkTGq0DQ4Z05o7/zcpGF5i9pFRrgZDlw/m2cA1MLeASz+gXkpMd2xsFSry5TkIOuScXvqVTP8RCeJ95c+cpgjW80bfce1rw9jAhsBPSPtbbLhSCjOq7TFu2piEWMbPgQTQtHXikGxdTVSqMkzOirllfDCFvetFlEIqxgZsHmKr4Dow3nC91WSeWHuiwrDl/hrd+B+DQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7381.namprd11.prod.outlook.com (2603:10b6:8:134::14) by CY8PR11MB7747.namprd11.prod.outlook.com (2603:10b6:930:91::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.22; Mon, 26 Oct 2026 23:46:35 +0000 Received: from DS0PR11MB7381.namprd11.prod.outlook.com ([fe80::4c39:dfe6:d6dc:6f58]) by DS0PR11MB7381.namprd11.prod.outlook.com ([fe80::4c39:dfe6:d6dc:6f58%6]) with mapi id 15.21.0546.021; Mon, 26 Oct 2026 23:46:35 +0000 Message-ID: Date: Mon, 26 Oct 2026 16:46:33 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH iwl-net 1/2] ice: store cached PHC time in ice_adapter To: , Intel Wired LAN References: <20261023-jk-e825-e830-timecounter-v1-0-e932602f0d16@intel.com> <20261023-jk-e825-e830-timecounter-v1-1-e932602f0d16@intel.com> From: Jacob Keller Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4PR03CA0013.namprd03.prod.outlook.com (2603:10b6:303:8f::18) To DS0PR11MB7381.namprd11.prod.outlook.com (2603:10b6:8:134::14) X-Archived-By: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7381:EE_|CY8PR11MB7747:EE_ X-MS-Office365-Filtering-Correlation-Id: 2a034584-0342-49bd-d945-08df33bb5ed0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|1800799024|376014|23010399003|10067099003|18002099003|22082099003|261026140227099003|56012099006|261009223027099003|5023799004|11063799006|4143699003|261021121427099003|261022105027099003|261022075727099003|261026121527099003; X-Microsoft-Antispam-Message-Info: vMahcXgxU9U6cD6bpSUyZnu5Sy6MEFytqGEZNuIkuwF+QYOXbvfmCNZe15aBSLH1ZRsWtwX+lAnyc5SQniAofAQsiaGrJ5H+X8PyBg4YMZyyYFQBkLbyDNg5GQNOGCpWAcwcGleil51g0asMXMQI9pS/+rk22UPcPQjmN+xwqGqAOlqs2yG9d79uufmLVgauww7DO79GTYT2uIvQbYOPKhw5pEoS7vWcMKE/2FzMTUGku+vIg5iNwaXS+e72qcKalqpHe3/8oGk8HmVmwcPFpi66ntbcCkYN+0rs/Y4ogTQ6x3vZ2Sz9ITQRiMFLmWvrzYLKflVF7HxEfzaS6MXOuwc5Eram9aqwBH5L/NcA08b/ZdZm6QPqVOB6y3jYLR0bpvMuAM/ZcFQxVZigDZO4YArYFNeN8RWPNZMjG0wRQkQXMjMxjp4vz280K9NDnTe0JuhoLcaJZz3wcdPD6t9bspAYjbv1O8B5Co18Wnx3bKz4h5qf3IjgGf13jtMHclNtzGiEMooLBDkiij92hD55Vd9eqOVA0JXacDd4ZL7suUaF18yDsgiK5Ck22T1v2Era/ZBqyP2Ww4r7h++LMsDMtciSJiKPrLahk3e+oz7fO3U6TftuVYDFD3tFScT4XoBDhpb12bGjhvenatiAxHMdF1sehcg+virDdZKzXLryr6o= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7381.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(23010399003)(10067099003)(18002099003)(22082099003)(261026140227099003)(56012099006)(261009223027099003)(5023799004)(11063799006)(4143699003)(261021121427099003)(261022105027099003)(261022075727099003)(261026121527099003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U2dQczJKVkduRTRSOVgzenZ1VC96WGNNU0lvc0lkVy9ZQzhtSG1uYzJHbXY0?= =?utf-8?B?MjlxZEl6Z1pZekluN0dKV1NTcUJXUHcrcGNZbU44WXFWWXZjSm9rV3VHSmdV?= =?utf-8?B?bktrYWlvS0tpckNwdUNLbnpDWC9kc28yamc1TFZ5VUIxMkdWMjlGN2QyeEdi?= =?utf-8?B?dm1vVUYzd2E4djNhUkgwdGM2S1A0WHlEL0hmOFVBS1FjNEVZd0h1UHBWUkcw?= =?utf-8?B?UWFKelkwUk52NWFwemY5ZGxMR3hmbnJjYzVxM2htLzNad1puT2JPU0F4NmVn?= =?utf-8?B?SFZwMy9OK3ZwSDF2cGdwd0pGRjhKdTg3S1d1NDNDdUNuU1hUSDJKb2IvRlJJ?= =?utf-8?B?b0t2R3VmSE5OZm94ZFNhd1RobFd6aStCZG55Z04ybUl6bWx6WXIwTklUUGtI?= =?utf-8?B?bEtiUU95OFFPQ3l5YXFPemhBaXlVanRicXlWSzhXT2QyUEJ1QnZjb3NsZ1Rs?= =?utf-8?B?OU0wN2dnV3BYMDdLK3pmU2FZT05IZlNDM0h3R3BJUjl4dmVzdUJOZHZuWFNr?= =?utf-8?B?V3RBT1NZK1VvaE1MdXhXeCtCMzRBdnBmWGIxeVIzazJmdXFqc0xSbE1sUWRq?= =?utf-8?B?eXBSRkJUdEEvczUyeUpORTJmM2txcW1rek5aWHpMUGtqZFU2MG02ZXQxZVMw?= =?utf-8?B?NGRnZzU4MEtPTVNsODErZ3BhamxSaDRnVWV5NHc5Ni91Y2YxeVZOYXRlSFFS?= =?utf-8?B?K0NHS3hZQXdKM0E0YzZyQTl1eVpINldWTVp4N2FuajM5a3RlcG1MSHkxUzJp?= =?utf-8?B?VzRXN2pUS2liVGllNWhsZk80UXMxZUt3YUd0eEhiYWJhaW13U1QyYmpjT1VS?= =?utf-8?B?UUg2ZitxdEo2T1R5T3cycGtFbmNXU09jaHVnTFFQMFZ0YU4zTFByVU16aWdK?= =?utf-8?B?SEZmeEd6SFgxMDZYVVBJUkhNYUFYTUI4T2ZzU2RvOFhZdWNjRFhTSmVtQ2Ux?= =?utf-8?B?ZFlyZVBFaUlMZUQ2a084aW9uRzhVc1ZtQ2x0WG5zaFpKa1lwK3orTFlwK2tx?= =?utf-8?B?NlNNa0Z3VkVHZ0o4aWVtT1h5OHpLeHJmVFhhSXJFNnI2Q3doZnVYTVRBa1ZC?= =?utf-8?B?R2d6WlNxbW9IbHo5VFo5ZHh6VXYvM3N6VW5GOWxxNXArTnZTU0dMYWdOTEFM?= =?utf-8?B?Wlp1cHRQZHJVcXE4eFYyUkloTWlIU1Q4WTdjS2xVNVRGSHo5MGttc0pBZm9p?= =?utf-8?B?WjREWW1COHlNNEVYTHNEWDJXcyswQW5wazRLZEtqZ0QvOU12WWRGaWo4RGlO?= =?utf-8?B?cy9wR0cxMjFHZ2hIRDRwdHhqMWEzMi9sUnk4cE9hNDNSR2tPV3N0T2tWSTE2?= =?utf-8?B?NzlvSExYazZhUUFOV2dvUUltOE9pbjZtVm9HM0lxMHVrRVFuWGhIWklUUXB0?= =?utf-8?B?MEpvK2RiU1NZRjNVWkdXZlNpMk5CNEdLQVhVbDlPcXRreWpIcDNUTVlXS0VU?= =?utf-8?B?Qm1NZXozdVRuS1ZjdWEwNWVUTGwzWHpsUzJ5SjhIUCtuZEtNMDZhZHZIeUJY?= =?utf-8?B?U0E2R2lLTDlMcnBMZGN0a21SMW9yRnJjRlNiN25aaDNRVGt6UStRYjVCOEJN?= =?utf-8?B?cDBPUkN4RnhHaWlJcHFSYU5FTzc3NkMzcVFzM21BdlY1UnUxZnBVWlFTK0pE?= =?utf-8?B?dkxDV1cxemlZVk5HTmlTTEFrLzZ6aGdQbndidmp2L1l6NVhKYWl5ZGxHN000?= =?utf-8?B?RHpHWWZNejF3THl2aWNPM1pRQys0Z3hvMmg2RnN1MnBIZ2JMbXFCL3h3cllU?= =?utf-8?B?RTBaUkRJaEJ6eXAwalJJVnZkSm0xTWJEc2phTFg0c05mZHhzdTdYM2tkNVVR?= =?utf-8?B?eDVWWlRpbCsyRDBmK0xkczY0THRlVU9tK3JuUGlQSzRGd1pKNFU0ZnQ2Q0Nh?= =?utf-8?B?eTZ6b3VOSUZyMW1qV0t4OWVKMytvQjduaDNKTVZlbVowNnczbFJxQ1d1ZFlN?= =?utf-8?B?OXFTbEFLRW9NTm5rQWh3SlN0Q1ZDT2NhQnRVcFl5UmhBcTNGYkJEeDMrY1dX?= =?utf-8?B?OUQ0SERySG5yOXc4VUprczNKUW43a1lCOXpXMEZNUVg2VXpTSG1hMlZySkdM?= =?utf-8?B?MzZ6Y1luOHpQYnBBQk40MWw2cmRQT1BJR016RGZYZ3pNMU5CbmRjZ1hoQm13?= =?utf-8?B?eHJSbFlCS2pqS2t1YWtZZlNNN3J2ejBxanNpSXdMdjN2dW5GeUtPZFFLaktV?= =?utf-8?B?akExVUppTHhmOFlWTXREUHBZc1F6UHEweVhEU1lLbXAvTlZjaGhuTlZXRzA0?= =?utf-8?B?ODBsQTBXUURHYUMxODhvNEFSRml4WTFFYmNNa1ZYZEpHNDU1NFE0WmtBQlVy?= =?utf-8?B?cHFDWHdkZCtiL1pRLyttZ2ptNXpnRGpUK3BrUjJXYlM4dk9rdThHZz09?= X-Exchange-RoutingPolicyChecked: UPlEZt9IermTTG6JOhlW/KujRK6B5UZC8l1qv3sR9bhwwpC6Fv3bWE980sXamEaBfbJLzU7WXVxjK3xWKASXczujvFfGROLX8yEep3/0/ZfgeKyZ/sN2oZfQhRIJIwb5rvvwRtvW6MwC40O3yKsJ/IbZGpqniuK37mUOrmVsRZfKpGapwpmHbz+xN7SQ9jd8mbwE4BkqQmWzAgsO72gflBxw/XRQB9QBzoC6ftCl0/8UtrAqEoQyXzJqHSrh80DhbeochAO1rkPoAI1ka3YrkydN2m35fH1MrvwbQxya8q7Fl/NhJsZ9I1/HiR5OH5xo9x3lpNIYtLiOp9xOVyuAkw== X-MS-Exchange-CrossTenant-Network-Message-Id: 2a034584-0342-49bd-d945-08df33bb5ed0 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7381.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2026 23:46:35.4495 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ddel+w791eCYzbUjbP17XKvk7gV85JTvenZ02x4f2SBLDF0O/mV7gk2rBeVgQ7NrYVt0XL7ym6G1K5ehgHp9sxzkFy9KIzqLgNBjT5tmK00= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7747 X-OriginatorOrg: intel.com X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Archive: List-Post: List-Help: List-Subscribe: , X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On 10/23/2026 6:46 PM, sashiko-bot@kernel.org wrote: > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: > - [Medium] ice: stale shared phc.cached_time when clock-owning PF stops or unbinds > -- > > commit 866055ac7173935e690af3f73268e559a0698a8d > Author: Jacob Keller > > ice: store cached PHC time in ice_adapter > > This commit moves the cached PHC time from per-PF and per-Rx-ring fields > into a shared struct ice_phc embedded in struct ice_adapter, and updates > only the clock-owning PF to refresh that shared value in its periodic > work. > >> diff --git a/drivers/net/ethernet/intel/ice/ice_ptp.c b/drivers/net/ethernet/intel/ice/ice_ptp.c >> index ec24c09280785..4b4a00beadd2c 100644 >> --- a/drivers/net/ethernet/intel/ice/ice_ptp.c >> +++ b/drivers/net/ethernet/intel/ice/ice_ptp.c > > [ ... ] > >> @@ -987,35 +992,26 @@ static int ice_ptp_init_tx(struct ice_pf *pf, struct ice_ptp_tx *tx, u8 port) >> } >> >> /** >> - * ice_ptp_update_cached_phctime - Update the cached PHC time values >> + * ice_ptp_update_cached_phctime - Update the cached PHC time value >> * @pf: Board specific private structure >> * >> - * This function updates the system time values which are cached in the PF >> - * structure and the Rx rings. >> - * >> - * This function must be called periodically to ensure that the cached value >> - * is never more than 2 seconds old. >> + * Update the PTP hardware clock time values which are cached in the PHC >> + * structure. >> * >> - * Note that the cached copy in the PF PTP structure is always updated, even >> - * if we can't update the copy in the Rx rings. >> - * >> - * Return: >> - * * 0 - OK, successfully updated >> - * * -EAGAIN - PF was busy, need to reschedule the update >> - * * -ENODEV - no control PF owns the source clock register space >> - * * -EOPNOTSUPP - PTP support is not compiled in >> + * This function must be called periodically by the clock owner to ensure that >> + * the cached value is never more than 2 seconds old. >> */ >> -static int ice_ptp_update_cached_phctime(struct ice_pf *pf) >> +static void ice_ptp_update_cached_phctime(struct ice_pf *pf) >> { >> + struct ice_phc *phc = &pf->adapter->phc; >> struct device *dev = ice_pf_to_dev(pf); >> unsigned long update_before; >> u64 systime; >> - int err, i; >> + int err; >> >> - update_before = pf->ptp.cached_phc_jiffies + msecs_to_jiffies(2000); >> - if (pf->ptp.cached_phc_time && >> - time_is_before_jiffies(update_before)) { >> - unsigned long time_taken = jiffies - pf->ptp.cached_phc_jiffies; >> + update_before = phc->update_jiffies + msecs_to_jiffies(2000); >> + if (phc->cached_time && time_is_before_jiffies(update_before)) { >> + unsigned long time_taken = jiffies - phc->update_jiffies; >> >> dev_warn(dev, "%u msecs passed between update to cached PHC time\n", >> jiffies_to_msecs(time_taken)); >> @@ -1032,36 +1028,12 @@ static int ice_ptp_update_cached_phctime(struct ice_pf *pf) >> * longer tracks the PHC, and both treat a zero cache as >> * "no timestamp". >> */ >> - systime = 0; >> - WRITE_ONCE(pf->ptp.cached_phc_time, 0); >> + WRITE_ONCE(phc->cached_time, 0); >> } else { >> - /* Update the cached PHC time stored in the PF structure */ >> - WRITE_ONCE(pf->ptp.cached_phc_time, systime); >> - WRITE_ONCE(pf->ptp.cached_phc_jiffies, jiffies); >> + /* Update the cached PHC time stored in the PHC structure */ >> + WRITE_ONCE(phc->cached_time, systime); >> + WRITE_ONCE(phc->update_jiffies, jiffies); >> } > > [ ... ] > >> @@ -3078,24 +3025,20 @@ static void ice_ptp_periodic_work(struct kthread_work *work) >> { >> struct ice_ptp *ptp = container_of(work, struct ice_ptp, work.work); >> struct ice_pf *pf = container_of(ptp, struct ice_pf, ptp); >> - int err; >> >> if (pf->ptp.state != ICE_PTP_READY) >> return; >> >> ice_ptp_tspll_monitor(pf); >> >> - err = ice_ptp_update_cached_phctime(pf); >> + if (ice_pf_src_tmr_owned(pf)) >> + ice_ptp_update_cached_phctime(pf); > > [Severity: Medium] > What happens to pf->adapter->phc.cached_time on remaining PFs if the > clock-owning PF is unbound, reset, or fails PTP rebuild? > > Previously, commit dcc2c9108e65 ("ice: Reject PTP access without a control > PF") handled control PF removal by having each PF run > ice_ptp_update_cached_phctime() from ice_ptp_periodic_work(). When the > control PF went away, ice_ptp_read_src_clk_reg() returned -ENODEV on the > secondary PFs, which cleared cached_phc_time and the Rx ring cached_phctime > copies to 0. > > With this change, ice_ptp_periodic_work() in > drivers/net/ethernet/intel/ice/ice_ptp.c only calls > ice_ptp_update_cached_phctime() when ice_pf_src_tmr_owned(pf) is true > (and the only other callers are ice_ptp_settime64() and ice_ptp_adjtime() > via ice_ptp_reset_cached_phctime(), which also only run on the clock > owner). Because ice_pf_src_tmr_owned(pf) guarantees ice_is_primary(&pf->hw) > is true, ice_ptp_read_src_clk_reg() never returns -ENODEV here, making the > error branch in ice_ptp_update_cached_phctime() that zeroes > phc->cached_time unreachable. > > Meanwhile, when the clock-owning PF stops its periodic worker in > ice_ptp_prepare_for_reset() or is unbound via > ice_ptp_release() -> ice_ptp_cleanup_adapter(): > > drivers/net/ethernet/intel/ice/ice_ptp.c:ice_ptp_cleanup_adapter() { > ... > if (ice_get_ctrl_pf(pf) == pf) { > rcu_assign_pointer(pf->adapter->ctrl_pf, NULL); > synchronize = true; > } > ... > } > > nothing zeroes pf->adapter->phc.cached_time. > > Because the Rx path in ice_ptp_get_rx_hwts() -> ice_ptp_extend_32b_ts() > only checks whether phc->cached_time is non-zero and does not check > phc->update_jiffies, won't active sibling or secondary PFs continue > extending 32-bit hardware Rx timestamps against the frozen > phc->cached_time indefinitely? > It does seem reasonable to clear this value when we clear the ctrl_pf. I can fix that.