From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
To: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Cc: netdev@vger.kernel.org, Tony Nguyen <anthony.l.nguyen@intel.com>,
intel-wired-lan@lists.osuosl.org
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v5] iavf: fix err handling for MAC replace
Date: Tue, 20 Jun 2023 10:27:11 +0200 [thread overview]
Message-ID: <f3dcd43c-0de6-e618-8f71-07f47a6b6071@intel.com> (raw)
In-Reply-To: <ZJARN5Nj/IpdWNWQ@boxer>
On 6/19/23 10:26, Maciej Fijalkowski wrote:
> On Mon, Jun 19, 2023 at 04:06:35AM -0400, Przemek Kitszel wrote:
>> Defer removal of current primary MAC until a replacement is successfully
>> added. Previous implementation would left filter list with no primary MAC.
>> This was found while reading the code.
>>
>> The patch takes advantage of the fact that there can only be a single primary
>> MAC filter at any time ([1] by Piotr)
>>
>> Piotr has also applied some review suggestions during our internal patch
>> submittal process.
>>
>> [1] https://lore.kernel.org/netdev/20230614145302.902301-2-piotrx.gardocki@intel.com/
>>
>> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
>> Tested-by: Rafal Romanowski <rafal.romanowski@intel.com>
>> Signed-off-by: Piotr Gardocki <piotrx.gardocki@intel.com>
>> Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
>
> I was reviewing that:
> https://lore.kernel.org/netdev/ZH8JBgiZAvNdfg4+@boxer/
>
> Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Thanks a lot both for insightful review, a remainder, and attitude :)
[...]
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
prev parent reply other threads:[~2023-06-20 8:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-19 8:06 [Intel-wired-lan] [PATCH iwl-next v5] iavf: fix err handling for MAC replace Przemek Kitszel
2023-06-19 8:26 ` Maciej Fijalkowski
2023-06-20 8:27 ` Przemek Kitszel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3dcd43c-0de6-e618-8f71-07f47a6b6071@intel.com \
--to=przemyslaw.kitszel@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=maciej.fijalkowski@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox