Re: [Intel-wired-lan] [PATCH iwl-net v11] igc: Fix trigger of incorrect irq in igc_xsk_wakeup function

["Dahan, AvigailX" <avigailx.dahan@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3485 bytes --]


On 20/01/2026 9:52, Vivek Behera via Intel-wired-lan wrote:
> This patch addresses the issue where the igc_xsk_wakeup function
> was triggering an incorrect IRQ for tx-0 when the i226 is configured
> with only 2 combined queues or in an environment with 2 active CPU cores.
> This prevented XDP Zero-copy send functionality in such split IRQ
> configurations.
>
> The fix implements the correct logic for extracting q_vectors saved
> during rx and tx ring allocation and utilizes flags provided by the
> ndo_xsk_wakeup API to trigger the appropriate IRQ.
>
> Fixes: fc9df2a0b520 ("igc: Enable RX via AF_XDP zero-copy")
> Fixes: 15fd021bc427 ("igc: Add Tx hardware timestamp request for AF_XDP zero-copy packet")
> Signed-off-by: Vivek Behera<vivek.behera@siemens.com>
> Reviewed-by: Jacob Keller<jacob.keller@intel.com>
> Reviewed-by: Aleksandr loktinov<aleksandr.loktionov@intel.com>
> Reviewed-by: Piotr Kwapulinski<piotr.kwapulinski@intel.com>
> ---
> v1:https://lore.kernel.org/intel-wired-lan/AS1PR10MB5392B7268416DB8A1624FDB88FA7A@AS1PR10MB5392.EURPRD10.PROD.OUTLOOK.COM/
> v2:https://lore.kernel.org/intel-wired-lan/AS1PR10MB539280B1427DA0ABE9D65E628FA5A@AS1PR10MB5392.EURPRD10.PROD.OUTLOOK.COM/
> v3:https://lore.kernel.org/intel-wired-lan/IA3PR11MB8986E4ACB7F264CF2DD1D750E5A0A@IA3PR11MB8986.namprd11.prod.outlook.com/
> v4:https://lore.kernel.org/intel-wired-lan/AS1PR10MB53926CB955FBD4F9F4A018818FA0A@AS1PR10MB5392.EURPRD10.PROD.OUTLOOK.COM/
> v5:https://lore.kernel.org/intel-wired-lan/AS1PR10MB5392FCA415A38B9DD7BB5F218FA0A@AS1PR10MB5392.EURPRD10.PROD.OUTLOOK.COM/
> v6:https://lore.kernel.org/intel-wired-lan/20251211173916.23951-1-vivek.behera@siemens.com/
> v7:https://lore.kernel.org/intel-wired-lan/20251212163208.137164-1-vivek.behera@siemens.com/
> v8:https://lore.kernel.org/intel-wired-lan/20251215122052.412327-1-vivek.behera@siemens.com/
> v9:https://lore.kernel.org/intel-wired-lan/20251220110009.137245-1-vivek.behera@siemens.com/
> v10:https://lore.kernel.org/intel-wired-lan/20260117150753.2088857-1-vivek.behera@siemens.com/
> changelog:
> v1
> - Inital description of the Bug and steps to reproduce with RTC Testbench
> - Test results after applying the patch
> v1 -> v2
> - Handling of RX and TX Wakeup in igc_xsk_wakeup for a split IRQ configuration
> - Removal of igc_trigger_rxtxq_interrupt (now redundant)
> - Added flag to igc_xsk_wakeup function call in igc_ptp_free_tx_buffer
> v2 -> v3
> - Added 'Fixes:' tags for the relevant commits.
> - Added reviewer
> v3 -> v4
> - Added reviewer
> v4 -> v5
> - Updated comment style from multi-star to standard linux convention
> v5 -> v6
> - Resolve formatting issues highlighted by reviewers
> - Try to include version histroy as defined in netdev guidelines
> - Included review suggestions from Przemyslaw
> - Added reviewers
> v6 -> v7
> - Included review suggestions from Przemyslaw missed in v6
> v7 -> v8
> - Modified sequence to complete all error checks for rx and tx
>    before updating napi states and triggering irq
> v8 -> v9
> - Included review feedback and suggestions from Tony and Siang
> v9 -> v10
> - Introduced a simplified logic for sequential check for RX and TX
> v10 -> v11
> - Improved explanation of implemented logic in comment block
> ---
>   drivers/net/ethernet/intel/igc/igc_main.c | 34 ++++++++++++++++-------
>   drivers/net/ethernet/intel/igc/igc_ptp.c  |  3 +-
>   2 files changed, 26 insertions(+), 11 deletions(-)
>
Tested-by: Avigail Dahan <avigailx.dahan@intel.com>

[-- Attachment #2: Type: text/html, Size: 5850 bytes --]