Re: [Intel-wired-lan] [PATCH net v1] i40e: Fix erroneous adapter reinitialization during recovery process

[Tony Nguyen <anthony.l.nguyen@intel.com>]

On 6/8/2022 2:13 AM, Jan Sokolowski wrote:
> From: Alice Michael <alice.michael@intel.com>
> 
> Fix an issue, when driver incorrectly detects state
> of recovery process and erroneously reinitializes interrupts,
> which results in a kernel error and call trace message.
> 
> The issue was caused by a combination of two factors:
> 1. Assuming the EMP reset issued after completing
> firmware recovery means the whole recovery process is complete.
> 2. Erroneous reinitialization of interrupt vector after detecting
> the abovementioned EMP reset.
> 
> Fixes (1) by changing how recovery state change is detected
> and (2) by adjusting the conditional expression to ensure using proper
> interrupt reinitialization method, depending on the situation.
> 
> Fixes: 4ff0ee1af016 ("i40e: Introduce recovery mode support")
> Signed-off-by: Alice Michael <alice.michael@intel.com>
> Signed-off-by: Dawid Lukwinski <dawid.lukwinski@intel.com>

Could you clarify how Dawid was involved in this patch? If he helped 
develop it, please add the Co-developed-by [1]. If he did something 
else, please use the appropriate tag/contribution [2].

> Signed-off-by: Jan Sokolowski <jan.sokolowski@intel.com>

[1] 
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by
[2] 
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan