Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Nguyen, Anthony L <anthony.l.nguyen@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net-next v2] iavf: Add support for 50G/100G in AIM algorithm
Date: Mon, 20 Sep 2021 22:21:03 +0000	[thread overview]
Message-ID: <f6facbbaada21e6e668fd2dd4c04a52f2546b6ec.camel@intel.com> (raw)
In-Reply-To: <20210920132539.24114-1-mateusz.palczewski@intel.com>

On Mon, 2021-09-20 at 15:25 +0200, Mateusz Palczewski wrote:
> Advanced link speed support was added long back, but adding AIM
> support
> was missed. Adding AIM support for advanced link speed support
> allows the algorithm to take into account 50G/100G link speeds.
> Also, other previous speeds are taken into consideration when
> advanced
> link speeds are supported.
> 
> Signed-off-by: Brett Creeley brett.creeley at intel.com
> Signed-off-by: Mateusz Palczewski mateusz.palczewski at intel.com

Please run checkpatch before sending:

ERROR: Unrecognized email address: 'Brett Creeley 
brett.creeley at intel.com'
#12:
Signed-off-by: Brett Creeley brett.creeley at intel.com

ERROR: Unrecognized email address: 'Mateusz Palczewski 
mateusz.palczewski at intel.com'
#13:
Signed-off-by: Mateusz Palczewski mateusz.palczewski at intel.com

WARNING: please, no space before tabs
#39: FILE: drivers/net/ethernet/intel/iavf/iavf_txrx.c:378:
+#define IAVF_AIM_MULTIPLIER_50G ^I1280$

WARNING: please, no space before tabs
#40: FILE: drivers/net/ethernet/intel/iavf/iavf_txrx.c:379:
+#define IAVF_AIM_MULTIPLIER_40G ^I1024$

WARNING: please, no space before tabs
#41: FILE: drivers/net/ethernet/intel/iavf/iavf_txrx.c:380:
+#define IAVF_AIM_MULTIPLIER_20G ^I512$

WARNING: please, no space before tabs
#42: FILE: drivers/net/ethernet/intel/iavf/iavf_txrx.c:381:
+#define IAVF_AIM_MULTIPLIER_10G ^I256$

WARNING: please, no space before tabs
#43: FILE: drivers/net/ethernet/intel/iavf/iavf_txrx.c:382:
+#define IAVF_AIM_MULTIPLIER_1G  ^I32$

CHECK: Please use a blank line after function/struct/union/enum
declarations
#66: FILE: drivers/net/ethernet/intel/iavf/iavf_txrx.c:404:
+}
+<200b>

CHECK: Please use a blank line after function/struct/union/enum
declarations
#95: FILE: drivers/net/ethernet/intel/iavf/iavf_txrx.c:422:
+}
+<200b>


> ---
>  v2: Removed build issues

Are you building these patches? Issues still exist:

drivers/net/ethernet/intel/iavf/iavf_txrx.c:404:1: error: stray \342 in
program
 
 ^
drivers/net/ethernet/intel/iavf/iavf_txrx.c:404:2: error: stray \200 in
program
 
  ^
drivers/net/ethernet/intel/iavf/iavf_txrx.c:404:3: error: stray \213 in
program
 
   ^
drivers/net/ethernet/intel/iavf/iavf_txrx.c:422:1: error: stray \342 in
program
 
 ^
drivers/net/ethernet/intel/iavf/iavf_txrx.c:422:2: error: stray \200 in
program
 
  ^
drivers/net/ethernet/intel/iavf/iavf_txrx.c:422:3: error: stray \213 in
program


> ---
>  drivers/net/ethernet/intel/iavf/iavf_txrx.c | 70 +++++++++++++++--
> ----
>  1 file changed, 51 insertions(+), 19 deletions(-)


      parent reply	other threads:[~2021-09-20 22:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-20 13:25 [Intel-wired-lan] [PATCH net-next v2] iavf: Add support for 50G/100G in AIM algorithm Mateusz Palczewski
2021-09-20 17:31 ` kernel test robot
2021-09-20 22:21 ` Nguyen, Anthony L [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f6facbbaada21e6e668fd2dd4c04a52f2546b6ec.camel@intel.com \
    --to=anthony.l.nguyen@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox