Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Joseph, Jithu <jithu.joseph@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net-next v6 1/9] igc: Fix igc_ptp_rx_pktstamp()
Date: Fri, 12 Feb 2021 19:16:53 +0000	[thread overview]
Message-ID: <f6fb65d0a78b51489323486ca218b2f3d9c441c3.camel@intel.com> (raw)
In-Reply-To: <578c9ceb86e0d6007cab529c4215372f61d023d3.camel@intel.com>

On Thu, 2021-02-11 at 00:30 +0000, Nguyen, Anthony L wrote:
> On Wed, 2021-02-10 at 13:58 -0800, Vedang Patel wrote:
> > From: Andre Guedes <andre.guedes@intel.com>
> > 
> > The comment describing the timestamps layout in the packet buffer
> > is
> > wrong and the code is actually retrieving the timestamp in Timer 1
> > reference instead of Timer 0. This hasn't been a big issue so far
> > because hardware is configured to report both timestamps using
> > Timer
> > 0
> > (see IGC_SRRCTL register configuration in
> > igc_ptp_enable_rx_timestamp()
> > helper). This patch fixes the comment and the code so we retrieve
> > the
> > timestamp in Timer 0 reference as expected.
> > 
> > This patch also takes the opportunity to get rid of the hw.mac.type
> > check
> > since it is not required.
> > 
> > Fixes: 81b055205e8ba ("igc: Add support for RX timestamping")
> 
> This seems better suited for net. I can split it and send it that
> route, but is there a reason that it needs to stay in this series?
> 

A subsequent patch  in this series (f6ddfa4ba2ed - igc: Refactor Rx
timestamp handling) is dependent on this patch.  

Please go ahead and split this patch from this series and send it via
the "net route" you mention, if that is more appropriate. 

Let us know if you want us to resend the rest of the patches in this
series (without the first patch) .

Jithu

  reply	other threads:[~2021-02-12 19:16 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-10 21:58 [Intel-wired-lan] [PATCH net-next v6 0/9] igc: Add XDP support Vedang Patel
2021-02-10 21:58 ` [Intel-wired-lan] [PATCH net-next v6 1/9] igc: Fix igc_ptp_rx_pktstamp() Vedang Patel
2021-02-11  0:30   ` Nguyen, Anthony L
2021-02-12 19:16     ` Joseph, Jithu [this message]
2021-03-02  8:20   ` Dvora Fuxbrumer
2021-02-10 21:58 ` [Intel-wired-lan] [PATCH net-next v6 2/9] igc: Remove unused argument from igc_tx_cmd_type() Vedang Patel
2021-03-02  8:20   ` Dvora Fuxbrumer
2021-02-10 21:58 ` [Intel-wired-lan] [PATCH net-next v6 3/9] igc: Introduce igc_rx_buffer_flip() helper Vedang Patel
2021-03-02  8:20   ` Dvora Fuxbrumer
2021-02-10 21:58 ` [Intel-wired-lan] [PATCH net-next v6 4/9] igc: Introduce igc_get_rx_frame_truesize() helper Vedang Patel
2021-03-02  8:21   ` Dvora Fuxbrumer
2021-02-10 21:58 ` [Intel-wired-lan] [PATCH net-next v6 5/9] igc: Refactor Rx timestamp handling Vedang Patel
2021-03-02  8:21   ` Dvora Fuxbrumer
2021-02-10 21:58 ` [Intel-wired-lan] [PATCH net-next v6 6/9] igc: Add set/clear large buffer helpers Vedang Patel
2021-03-02  8:21   ` Dvora Fuxbrumer
2021-02-10 21:58 ` [Intel-wired-lan] [PATCH net-next v6 7/9] igc: Add initial XDP support Vedang Patel
2021-03-02  8:22   ` Dvora Fuxbrumer
2021-02-10 21:58 ` [Intel-wired-lan] [PATCH net-next v6 8/9] igc: Add support for XDP_TX action Vedang Patel
2021-03-02  8:22   ` Dvora Fuxbrumer
2021-02-10 21:58 ` [Intel-wired-lan] [PATCH net-next v6 9/9] igc: Add support for XDP_REDIRECT action Vedang Patel
2021-03-02  8:22   ` Dvora Fuxbrumer
2021-03-02  8:19 ` [Intel-wired-lan] [PATCH net-next v6 0/9] igc: Add XDP support Dvora Fuxbrumer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f6fb65d0a78b51489323486ca218b2f3d9c441c3.camel@intel.com \
    --to=jithu.joseph@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox