From: Jacob Keller <jacob.e.keller@intel.com>
To: <intel-wired-lan@osuosl.org>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next 1/3] i40e: Move i40e_is_aq_api_ver_ge helper
Date: Mon, 23 Oct 2023 15:01:26 -0700 [thread overview]
Message-ID: <f707e348-ed39-4a53-a28b-28ace767f76c@intel.com> (raw)
In-Reply-To: <20231023162928.245583-2-ivecera@redhat.com>
On 10/23/2023 9:29 AM, Ivan Vecera wrote:
> +/**
> + * i40e_is_aq_api_ver_ge
> + * @hw: pointer to i40e_hw structure
> + * @maj: API major value to compare
> + * @min: API minor value to compare
> + *
> + * Assert whether current HW API version is greater/equal than provided.
> + **/
> +static inline bool i40e_is_aq_api_ver_ge(struct i40e_hw *hw, u16 maj, u16 min)
> +{
> + return (hw->aq.api_maj_ver > maj ||
> + (hw->aq.api_maj_ver == maj && hw->aq.api_min_ver >= min));
> +}
Checkpatch.pl complained here that this was using spaces instead of a
tab to indent.
Thanks,
Jake
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2023-10-23 22:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 16:29 [Intel-wired-lan] [PATCH iwl-next 0/3] i40e: Add and use version check helpers Ivan Vecera
2023-10-23 16:29 ` [Intel-wired-lan] [PATCH iwl-next 1/3] i40e: Move i40e_is_aq_api_ver_ge helper Ivan Vecera
2023-10-23 22:01 ` Jacob Keller [this message]
2023-10-23 16:29 ` [Intel-wired-lan] [PATCH iwl-next 2/3] i40e: Add other helpers to check version of running firmware and AQ API Ivan Vecera
2023-10-23 18:57 ` kernel test robot
2023-10-23 22:01 ` Jacob Keller
2023-10-24 10:24 ` Wojciech Drewek
2023-10-24 13:01 ` Ivan Vecera
2023-10-24 13:11 ` Wojciech Drewek
2023-10-24 20:02 ` Jacob Keller
2023-10-23 16:29 ` [Intel-wired-lan] [PATCH iwl-next 3/3] i40e: Use helpers to check running FW and AQ API versions Ivan Vecera
2023-10-23 22:02 ` Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f707e348-ed39-4a53-a28b-28ace767f76c@intel.com \
--to=jacob.e.keller@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox