public inbox for intel-wired-lan@osuosl.org
 help / color / mirror / Atom feed
From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: Jakub Kicinski <kuba@kernel.org>,
	<intel-wired-lan@lists.osuosl.org>,
	<michal.swiatkowski@linux.intel.com>
Cc: "Kitszel, Przemyslaw" <przemyslaw.kitszel@intel.com>,
	<jacob.e.keller@intel.com>
Subject: Re: [Intel-wired-lan] ice crashes when not enough IRQs
Date: Mon, 16 Mar 2026 10:29:56 -0700	[thread overview]
Message-ID: <f770c976-8688-4192-910f-5996e1850deb@intel.com> (raw)
In-Reply-To: <20260315132245.1a7efb20@kernel.org>

On 3/15/2026 1:22 PM, Jakub Kicinski wrote:
> On Sun, 15 Mar 2026 13:01:50 -0700 Jakub Kicinski wrote:
>> On Sun, 15 Mar 2026 12:54:51 -0700 Jakub Kicinski wrote:
>>> Trying to build a minimal kernel I dropped CONFIG_IRQ_REMAP=y from
>>> my config, and (on AMD) that caused IRQ shortage.
>>>
>>> This seems to crash ice after commit ad61cd9c67ad ("ice: get rid of
>>> num_lan_msix field"). Sorry for the lack of line numbers, I also
>>> dropped DEBUG_INFO. But I think the problem itself is pretty obvious.
>>> The fix less so, short of reverting ad61cd9c67ad. We can't just clamp
>>> the queues in ice_vsi_alloc_q_vectors() because AFAICT that would make
>>> ethtool -L succeed but driver would have a lower queue count than
>>> requested.
>>
>> Hm, maybe it's not just CONFIG_IRQ_REMAP=y
>> Enabling it makes no difference. Let me try to see what state the IRQ
>> allocation machinery is in on this kernel. On distro kernel ice gets
>> all the IRQs it wants at boot. But it also barfs something RDMA so
>> I can't really compare..
> 
> I think it's ee13aa1a2c5a ("ice: use netif_get_num_default_rss_queues()")
> It clamped the number of allocated queues but I think it meant to only
> clamp the default enabled queue count. No idea how y'all gonna get the
> extra IRQs later or whether you intended to pack multiple queues per IRQ
> so I'll let you figure this out..

Hi Jakub,

Thanks for letting us know. I think we have the fix for this in the 
pipeline [1]. I'll try to get it tested and out to you ASAP.

Thanks,
Tony

[1] 
https://lore.kernel.org/intel-wired-lan/20260223125157.819135-1-michal.swiatkowski@linux.intel.com/

> Thanks for letting me test crash detection and recovery in NIPA, I guess :D


  reply	other threads:[~2026-03-16 17:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-15 19:54 [Intel-wired-lan] ice crashes when not enough IRQs Jakub Kicinski
2026-03-15 20:01 ` Jakub Kicinski
2026-03-15 20:22   ` Jakub Kicinski
2026-03-16 17:29     ` Tony Nguyen [this message]
2026-03-16 18:59       ` Jakub Kicinski
2026-03-16 19:57         ` Tony Nguyen
2026-03-16 20:31           ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f770c976-8688-4192-910f-5996e1850deb@intel.com \
    --to=anthony.l.nguyen@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jacob.e.keller@intel.com \
    --cc=kuba@kernel.org \
    --cc=michal.swiatkowski@linux.intel.com \
    --cc=przemyslaw.kitszel@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox