Re: [Intel-wired-lan] [PATCH iwl-net v1] igc: Include the length/type field and VLAN tag in queueMaxSDU

From: "naamax.meir" <naamax.meir@linux.intel.com>
To: tee.min.tan@intel.com, intel-wired-lan@osuosl.org
Cc: anthony.l.nguyen@intel.com
Subject: Re: [Intel-wired-lan] [PATCH iwl-net v1] igc: Include the length/type field and VLAN tag in queueMaxSDU
Date: Tue, 27 Jun 2023 09:22:10 +0300	[thread overview]
Message-ID: <f9910e0a-b583-d202-fb69-a4586bbc453d@linux.intel.com> (raw)
In-Reply-To: <1686281322-26581-1-git-send-email-tee.min.tan@intel.com>

On 6/9/2023 06:28, tee.min.tan@intel.com wrote:
> From: Tan Tee Min <tee.min.tan@linux.intel.com>
> 
> IEEE 802.1Q does not have clear definitions of what constitutes an
> SDU (Service Data Unit), but IEEE Std 802.3 clause 3.1.2 does define
> the MAC service primitives and clause 3.2.7 does define the MAC Client
> Data for Q-tagged frames.
> 
> It shows that the mac_service_data_unit (MSDU) does NOT contain the
> preamble, destination and source address, or FCS. The MSDU does contain
> the length/type field, MAC client data, VLAN tag and any padding
> data (prior to the FCS).
> 
> Thus, the maximum 802.3 frame size that is allowed to be transmitted
> should be QueueMaxSDU (MSDU) + 16 (6 byte SA + 6 byte DA + 4 byte FCS).
> 
> Fixes: 92a0dcb8427d ("igc: offload queue max SDU from tc-taprio")
> Signed-off-by: Tan Tee Min <tee.min.tan@linux.intel.com>
> ---
>   drivers/net/ethernet/intel/igc/igc_main.c | 16 +++++-----------
>   1 file changed, 5 insertions(+), 11 deletions(-)

Tested-by: Naama Meir <naamax.meir@linux.intel.com>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan