From: Anatolii Gerasymenko <anatolii.gerasymenko@intel.com>
To: Tony Nguyen <anthony.l.nguyen@intel.com>,
<intel-wired-lan@lists.osuosl.org>
Subject: Re: [Intel-wired-lan] [PATCH net v1] ice: Create a separate kthread to handle ptp extts work
Date: Wed, 2 Nov 2022 09:03:52 +0100 [thread overview]
Message-ID: <fa75f705-a0c8-35a3-5ba3-1d1785398a71@intel.com> (raw)
In-Reply-To: <ee73169c-0060-e997-8661-c0e76cff12ff@intel.com>
On 01.11.2022 21:54, Tony Nguyen wrote:
> On 10/31/2022 12:14 AM, Anatolii Gerasymenko wrote:
>> ice_ptp_extts_work() and ice_ptp_periodic_work() are both scheduled on
>> the same kthread_worker pf.ptp.kworker. But, ice_ptp_periodic_work()
>> sends messages to ADQ and waits for responses. This causes
>
> Is this supposed to be AQ (not ADQ)?
>
Yes, I meant Admin Queue. Thanks for noticing this.
>> ice_ptp_extts_work() to be blocked while waiting to be scheduled. This
>> causes problems with the reading of the incoming signal timestamps,
>> which disrupts a 100 Hz signal.
>>
>> Create an additional kthread_worker pf.ptp.kworker_extts to service only
>> ice_ptp_extts_work() as soon as possible.
>>
>> Fixes: 77a781155a65 ("ice: enable receive hardware timestamping")
>> Signed-off-by: Anatolii Gerasymenko <anatolii.gerasymenko@intel.com>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
prev parent reply other threads:[~2022-11-02 8:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 7:14 [Intel-wired-lan] [PATCH net v1] ice: Create a separate kthread to handle ptp extts work Anatolii Gerasymenko
2022-11-01 20:54 ` Tony Nguyen
2022-11-02 8:03 ` Anatolii Gerasymenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa75f705-a0c8-35a3-5ba3-1d1785398a71@intel.com \
--to=anatolii.gerasymenko@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox