Re: [Intel-wired-lan] [PATCH iwl-net v2 1/1] e1000e: Workaround for sporadic MDI error on Meteor Lake systems

[Jacob Keller <jacob.e.keller@intel.com>]

On 10/4/2023 10:44 PM, Vitaly Lifshits wrote:
> On some Meteor Lake systems accessing the PHY via the MDIO interface may
> result in an MDI error. This issue happens sporadically and in most cases
> a second access to the PHY via the MDIO interface results in success.
> 
> As a workaround, introduce a retry counter which is set to 3 on Meteor
> Lake systems. The driver will only return an error if 3 consecutive PHY
> access attempts fail. The retry mechanism is disabled in specific flows,
> where MDI errors are expected.
> 
> Fixes: cc23f4f0b6b9 ("e1000e: Add support for Meteor Lake")
> Suggested-by: Nikolay Mushayev <nikolay.mushayev@intel.com>
> Co-developed-by: Nir Efrati <nir.efrati@intel.com>
> Signed-off-by: Nir Efrati <nir.efrati@intel.com>
> Signed-off-by: Vitaly Lifshits <vitaly.lifshits@intel.com>
> ---
> v2: fix checkpatch errors
> v1: initial version
> ---

This still produces a few long lines (netdev still prefers 80 columns vs
the 100 that is now the default for checkpatch.pl), and there are a few
places where you have multiple sequential blank lines:

WARNING: line length of 88 exceeds 80 columns
#241: FILE: drivers/net/ethernet/intel/e1000e/phy.c:166:
+                       e_dbg("MDI Read PHY Reg Address %d did not
complete\n", offset);

WARNING: line length of 87 exceeds 80 columns
#248: FILE: drivers/net/ethernet/intel/e1000e/phy.c:173:
+               if (((mdic & E1000_MDIC_REG_MASK) >>
E1000_MDIC_REG_SHIFT) != offset) {

WARNING: line length of 84 exceeds 80 columns
#251: FILE: drivers/net/ethernet/intel/e1000e/phy.c:176:
+                             (mdic & E1000_MDIC_REG_MASK) >>
E1000_MDIC_REG_SHIFT);

CHECK: Please don't use multiple blank lines
#273: FILE: drivers/net/ethernet/intel/e1000e/phy.c:197:
+
+

CHECK: Please don't use multiple blank lines
#334: FILE: drivers/net/ethernet/intel/e1000e/phy.c:234:

+

WARNING: line length of 89 exceeds 80 columns
#348: FILE: drivers/net/ethernet/intel/e1000e/phy.c:248:
+                       e_dbg("MDI Write PHY Reg Address %d did not
complete\n", offset);

WARNING: line length of 87 exceeds 80 columns
#355: FILE: drivers/net/ethernet/intel/e1000e/phy.c:255:
+               if (((mdic & E1000_MDIC_REG_MASK) >>
E1000_MDIC_REG_SHIFT) != offset) {

WARNING: line length of 84 exceeds 80 columns
#358: FILE: drivers/net/ethernet/intel/e1000e/phy.c:258:
+                             (mdic & E1000_MDIC_REG_MASK) >>
E1000_MDIC_REG_SHIFT);

total: 0 errors, 6 warnings, 2 checks, 343 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or
--fix-inplace.

Commit 5aa593aaf659 ("e1000e: Workaround for sporadic MDI error on
Meteor Lake systems") has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

(you can check this with ./scripts/checkpatch.pl --strict
--max-line-length=80)

Thanks,
Jake
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan