From: Jacob Keller <jacob.e.keller@intel.com>
To: <intel-wired-lan@osuosl.org>
Subject: Re: [Intel-wired-lan] [net-queue v4 1/1] ice: Do not use WQ_MEM_RECLAIM flag for workqueue
Date: Thu, 26 Jan 2023 10:55:20 -0800 [thread overview]
Message-ID: <fdfbeefd-eb4e-3e1f-727a-a20171d04927@intel.com> (raw)
In-Reply-To: <310135ff-2322-9349-afb4-f85c4b683002@intel.com>
On 1/26/2023 10:16 AM, Anirudh Venkataramanan wrote:
> I don't know. This was probably a mistake to begin with, but it was
> exposed only when the RDMA driver was also in use.
>
> Ani
I replied on the other thread, but the short answer is that
create_singlethread_workqueue used to set it, and i40e migrated from
that to alloc_workqueue, and kept the same flags. The ice driver then
copied alloc_workqueue from the i40e implementation. Interestingly, the
out-of-tree i40e driver available on sourceforge has removed
WQ_MEM_RECLAIM but the in-kernel driver hasn't yet...
I suspect create_workqueue had it set originally because it was a
catch-all API at the time.
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2023-01-26 18:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 21:16 [Intel-wired-lan] [net-queue v4 1/1] ice: Do not use WQ_MEM_RECLAIM flag for workqueue Tony Nguyen
2023-01-25 8:03 ` Andrysiak, Jakub
2023-01-26 16:10 ` Maciej Fijalkowski
2023-01-26 18:16 ` Anirudh Venkataramanan
2023-01-26 18:55 ` Jacob Keller [this message]
2023-01-26 18:49 ` Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdfbeefd-eb4e-3e1f-727a-a20171d04927@intel.com \
--to=jacob.e.keller@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox