Re: [PATCH net-next] ice: correct PTP register access debug messages

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] ice: missing trailing newline in debug message for threshold write failure
--

commit 3dfc5e0655da8eeda86700792eb12011c421ed4e
Author: Alok Tiwari <alok.a.tiwari@oracle.com>

ice: correct PTP register access debug messages

This commit updates the debug message for PHY_VENDOR_TXLANE_THRESH to
report a write failure rather than a read failure. It also intends to fix
newline placement in PHY register read and threshold write failure
messages.

> diff --git a/drivers/net/ethernet/intel/ice/ice_ptp_hw.c b/drivers/net/ethernet/intel/ice/ice_ptp_hw.c
> index 3a41c711e751b..289e0b3ef6ae9 100644
> --- a/drivers/net/ethernet/intel/ice/ice_ptp_hw.c
> +++ b/drivers/net/ethernet/intel/ice/ice_ptp_hw.c
> @@ -1529,7 +1529,7 @@ static int ice_phy_cfg_parpcs_eth56g(struct ice_hw *hw, u8 port)
>  	err = ice_write_xpcs_reg_eth56g(hw, port, PHY_VENDOR_TXLANE_THRESH,
>  					ICE_ETH56G_NOMINAL_THRESH4);
>  	if (err) {
> -		ice_debug(hw, ICE_DBG_PTP, "Failed to read VENDOR_TXLANE_THRESH, status: %d",
> +		ice_debug(hw, ICE_DBG_PTP, "Failed to write VENDOR_TXLANE_THRESH, status: %d",
>  			  err);

[Severity: Low]
In ice_phy_cfg_parpcs_eth56g(), is this missing a newline at the end of the
format string? The commit message indicates that it fixes newline placement
for the threshold write failure message, but the modified format string
still lacks a trailing newline when ice_write_xpcs_reg_eth56g() fails while
updating PHY_VENDOR_TXLANE_THRESH. Should a \n be appended to the string
here?

>  		return err;
>  	}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261011113545.16718-1-alok.a.tiwari@oracle.com?part=1