Re: [PATCH v12 net-next 6/9] octeontx2: cn20k: Coordinate default rules with NIX LF lifecycle

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Undocumented logic change in `rvu_npc_install_allmulti_entry`.
--

commit 905a3173f74be8db2d23362cf0c4656c9ea8d645
Author: Ratheesh Kannoth <rkannoth@marvell.com>

octeontx2: cn20k: Coordinate default rules with NIX LF lifecycle

This commit adds a new flag NIX_LF_DONT_FREE_DFT_IDXS to prevent the AF
from freeing CN20K default NPC rule indexes during PF hw reinit or teardown.
It also updates rvu_mbox_handler_nix_lf_alloc to improve error handling.

> diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c
> --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c
> @@ -990,7 +990,7 @@ void rvu_npc_install_allmulti_entry(struct rvu *rvu, u16 pcifunc, int nixlf,
>  	u16 vf_func;
>  
>  	/* Only CGX PF/VF can add allmulticast entry */
> -	if (is_lbk_vf(rvu, pcifunc) && is_sdp_vf(rvu, pcifunc))
> +	if (is_lbk_vf(rvu, pcifunc) || is_sdp_vf(rvu, pcifunc))

Is this logic change intended to be part of this commit?

The commit message focuses on coordinating default rules with the NIX LF
lifecycle, but this silently changes the condition from a logical AND to a
logical OR. While this appears to correctly fix a bug where the condition
could never be true (since a device cannot simultaneously be both an LBK VF
and an SDP VF), including an undocumented bug fix in a patch about a
different topic obscures the commit's intent.

Should this be split into a separate patch, or explicitly mentioned in the
commit message?

>  		return;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260508034912.4082520-1-rkannoth@marvell.com?part=6