From: sashiko-bot@kernel.org
To: "Sasha Neftin" <sashaneftin@gmail.com>, intel-wired-lan@lists.osuosl.org
Subject: Re: [PATCH iwl-next v1 1/2] igc: remove unused extended wakeup filter definitions
Date: Sun, 08 Nov 2026 14:52:33 +0000 [thread overview]
Message-ID: <sashiko-outbox-203816@kernel.org> (raw)
In-Reply-To: <20261108144503.97783-1-sashaneftin@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] igc: commit message omits removal of IGC_WUFC_FLX1 through
IGC_WUFC_FLX7
--
commit da9a0d24a19cd51d91534d22701d18bfafb24621
Author: Sasha Neftin <sashaneftin@gmail.com>
igc: remove unused extended wakeup filter definitions
This commit removes unused flexible wakeup filter bitmask definitions from
igc_defines.h.
> diff --git a/drivers/net/ethernet/intel/igc/igc_defines.h b/drivers/net/ethernet/intel/igc/igc_defines.h
> index ab55b88d4d96a..369aaccbd24e8 100644
> --- a/drivers/net/ethernet/intel/igc/igc_defines.h
> +++ b/drivers/net/ethernet/intel/igc/igc_defines.h
> @@ -26,13 +26,6 @@
> #define IGC_WUFC_BC 0x00000010 /* Broadcast Wakeup Enable */
> #define IGC_WUFC_FLEX_HQ BIT(14) /* Flex Filters Host Queuing */
> #define IGC_WUFC_FLX0 BIT(16) /* Flexible Filter 0 Enable */
> -#define IGC_WUFC_FLX1 BIT(17) /* Flexible Filter 1 Enable */
> -#define IGC_WUFC_FLX2 BIT(18) /* Flexible Filter 2 Enable */
> -#define IGC_WUFC_FLX3 BIT(19) /* Flexible Filter 3 Enable */
> -#define IGC_WUFC_FLX4 BIT(20) /* Flexible Filter 4 Enable */
> -#define IGC_WUFC_FLX5 BIT(21) /* Flexible Filter 5 Enable */
> -#define IGC_WUFC_FLX6 BIT(22) /* Flexible Filter 6 Enable */
> -#define IGC_WUFC_FLX7 BIT(23) /* Flexible Filter 7 Enable */
[Severity: Low]
Should the commit title and message also mention removing IGC_WUFC_FLX1
through IGC_WUFC_FLX7, since they currently only describe removing the
extended IGC_WUFC_EXT_FLX9 through IGC_WUFC_EXT_FLX31 definitions?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261108144503.97783-1-sashaneftin@gmail.com?part=1
next prev parent reply other threads:[~2026-11-08 14:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-08 14:45 [PATCH iwl-next v1 1/2] igc: remove unused extended wakeup filter definitions Sasha Neftin
2026-11-08 14:45 ` [PATCH iwl-next v1 2/2] igc: clean up redundant braces and code formatting Sasha Neftin
2026-11-08 14:52 ` sashiko-bot [this message]
2026-11-09 10:40 ` [PATCH iwl-next v1 1/2] igc: remove unused extended wakeup filter definitions Loktionov, Aleksandr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-203816@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=sashaneftin@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox