Re: [PATCH bpf-next 01/15] xdp: reserve an skb core extension area after the xdp_frame

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] xdp: multi-line comment style violation in include/net/xdp.h
--

commit c815cea2f0a60c677b6335d7bc98d4ff8c9346df
Author: Tianyi Gao <tianyi@cloudflare.com>

xdp: reserve an skb core extension area after the xdp_frame

This commit reserves an skb core extension area in the XDP headroom after
struct xdp_frame and updates XDP head, metadata, and pull-data helpers to
preserve it.

Link: https://lore.kernel.org/all/1d5521eb-84fc-4417-a3f5-6366694d160a@kernel.org/

> diff --git a/include/net/xdp.h b/include/net/xdp.h
> index 07231adfb5f82..c888353425d42 100644
> --- a/include/net/xdp.h
> +++ b/include/net/xdp.h
> @@ -81,6 +81,9 @@ enum xdp_buff_flags {
>  	 * XDP program is not attached.
>  	 */
>  	XDP_FLAGS_FRAGS_UNREADABLE	= BIT(2),
> +	XDP_FLAGS_HAS_SKB_EXT		= BIT(3), /* skb core extension header
> +						   * is valid
> +						   */
>  };

[ ... ]

> @@ -450,6 +464,37 @@ struct xdp_frame *xdp_convert_buff_to_frame(struct xdp_buff *xdp)
>  	return xdp_frame;
>  }
>  
> +/* skb core extensions: RX metadata that an XDP program stores in the
> + * headroom right after the xdp_frame, for the skb that is built later.
> + */

[Severity: Low]
This isn't a bug, but BPF coding style puts the opening /* of multi-line
comments on its own line, with the comment text starting on the next line,
for both XDP_FLAGS_HAS_SKB_EXT and the comment above enum xdp_skb_ext_id.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1794281983.git.tianyi@cloudflare.com?part=1