Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Dima Ruinskiy" <dima.ruinskiy@intel.com>,
	intel-wired-lan@lists.osuosl.org
Subject: Re: [PATCH iwl-net 2/2] e1000e: remove K1 workaround from Nova Lake
Date: Wed, 18 Nov 2026 16:51:55 +0000	[thread overview]
Message-ID: <sashiko-outbox-221568@kernel.org> (raw)
In-Reply-To: <20261118163447.1117617-3-dima.ruinskiy@intel.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] e1000e: inaccurate Fixes tag and commit attribution for K1
  workaround
--

commit 5c9c29651f27bff328cda7813a58dbb82ff6d70b
Author: Dima Ruinskiy <dima.ruinskiy@intel.com>

> e1000e: remove K1 workaround from Nova Lake
>
> Commit 3c7bf5af2196 ("e1000e: Introduce private flag to disable K1")
> implemented a workaround for packet loss issues when the K1 low-power link
> state is enabled on the integrated LAN on several generations of platforms,
> between Meteor Lake and Panther Lake. On Nova Lake platforms, it is not
> needed, and may cause noticeable performance degradations.
>
> Now that board_pch_nvp and e1000_pch_nvp are distinct types, add another
> MAC type check in e1000_reconfigure_k1_params() so that it never applies
> to MAC types before Meteor Lake or after Panther Lake.
>
> Tested on an I219-V29 (8086:57ba), K1 enabled, 1 Gb/s link. For each test,
> first line is the result without the patch, second line is with the patch.
>
>   iperf3 TCP receive, 20 s runs:
>       16-50 Mbps, 72-208 rx_crc_errors per run
>       949 Mbps, 0 rx_crc_errors (5 of 5 runs)
>   UDP 120 Mbps for 120 s, 2 runs:
>       0.55-0.67 % lost, 1855-2651 rx_crc_errors
>       0 % lost, 0 rx_crc_errors
>   HTTPS download of a 4.3 GB and a 3.5 GB file:
>       5.6 and 10.3 MB/s
>       74 and 59 MB/s
>
> Fixes: 3c7bf5af2196 ("e1000e: Introduce private flag to disable K1")
> Signed-off-by: Dima Ruinskiy <dima.ruinskiy@intel.com>
> Co-developed-by: Michael Edri <michael.edri@intel.com>
> Signed-off-by: Michael Edri <michael.edri@intel.com>

[Severity: Low]
Should the commit description and Fixes tag reference efaaf344bc29 ("e1000e:
change k1 configuration on MTP and later platforms") instead of 3c7bf5af2196
("e1000e: Introduce private flag to disable K1")?

In e1000_reconfigure_k1_params(), the early return for hw->mac.type >
e1000_pch_ptp still honors FLAG2_DISABLE_K1 (added in 3c7bf5af2196 ("e1000e:
Introduce private flag to disable K1")), while skipping the FEXTNVM12 and
I217_PHY_TIMEOUTS_REG K1 parameter workaround introduced by efaaf344bc29
("e1000e: change k1 configuration on MTP and later platforms").

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261118163447.1117617-1-dima.ruinskiy@intel.com?part=2

      reply	other threads:[~2026-11-18 16:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 16:34 [PATCH iwl-net 0/2] e1000e: Remove unnecessary workarounds from Nova Lake platform Dima Ruinskiy
2026-11-18 16:34 ` [PATCH iwl-net 1/2] e1000e: introduce new board type for Nova Lake PCH Dima Ruinskiy
2026-11-18 16:34 ` [PATCH iwl-net 2/2] e1000e: remove K1 workaround from Nova Lake Dima Ruinskiy
2026-11-18 16:51   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-221568@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=dima.ruinskiy@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox