Re: [Intel-xe] [PATCH 1/2] drm/xe: Add DRIVER_DATE to coredump error.

["Vivi, Rodrigo" <rodrigo.vivi@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1688 bytes --]

On Wed, 2023-07-26 at 19:29 +0000, Matthew Brost wrote:
On Wed, Jul 26, 2023 at 03:25:19PM -0400, Rodrigo Vivi wrote:
This might be an useful debugging information if the driver
date is properly updated with a certain cadence. With this
we know from which point in time in our development the
driver was from.


Make sense to have this, wondering what the cadence should be...

before we are merged we should probably change the date along with our rebases.

after we are in tree probably after the latest pull request towards the next version.


Anyways:
Reviewed-by: Matthew Brost <matthew.brost@intel.com<mailto:matthew.brost@intel.com>>

Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com<mailto:rodrigo.vivi@intel.com>>
---
 drivers/gpu/drm/xe/xe_devcoredump.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/xe/xe_devcoredump.c b/drivers/gpu/drm/xe/xe_devcoredump.c
index f53f4b51233a..79b506dc2622 100644
--- a/drivers/gpu/drm/xe/xe_devcoredump.c
+++ b/drivers/gpu/drm/xe/xe_devcoredump.c
@@ -10,6 +10,7 @@
 #include <generated/utsrelease.h>

 #include "xe_device.h"
+#include "xe_drv.h"
 #include "xe_engine.h"
 #include "xe_force_wake.h"
 #include "xe_gt.h"
@@ -83,6 +84,7 @@ static ssize_t xe_devcoredump_read(char *buffer, loff_t offset,
        drm_printf(&p, "**** Xe Device Coredump ****\n");
        drm_printf(&p, "kernel: " UTS_RELEASE "\n");
        drm_printf(&p, "module: " KBUILD_MODNAME "\n");
+       drm_printf(&p, "driver date: " DRIVER_DATE "\n");

        ts = ktime_to_timespec64(ss->snapshot_time);
        drm_printf(&p, "Snapshot time: %lld.%09ld\n", ts.tv_sec, ts.tv_nsec);
--
2.41.0



[-- Attachment #2: Type: text/html, Size: 3803 bytes --]