Re: [PATCH v3 1/7] drm/xe: s/xe_device_get_gt/xe_device_lookup_gt

[Michal Wajdeczko <michal.wajdeczko@intel.com>]

On 10/14/2025 6:48 PM, Jonathan Cavitt wrote:
> Replace the function name xe_device_get_gt with xe_device_lookup_gt to
> better illustrate it's capacity to return NULL in some cases.
> 

my suggestion was little different: introduce _new_ helper that can't fail
so the tool will not complain, and use it where we are sure we get a valid gt

renaming main function and then adding dedicated helper (that only wraps 
the original one) is not solving any problem at all

if we don't want to reuse/abuse existing xe_root_mmio_gt() then maybe just
add something similar but renamed for dedicated use case:

static inline struct xe_gt *xe_device_primary_gt(struct xe_device *xe)
{
	return xe_device_get_root_tile(xe)->primary_gt;
}

and start by using it as replacement for xe_device_get_gt(xe, 0)
where we known that checks are redundant/not needed (kunit/sriov)

then update remaining usages of xe_device_get_gt(xe, id) by
adding proper NULL check as needed

> Suggested-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Suggested-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
> ---
>  drivers/gpu/drm/xe/tests/xe_guc_buf_kunit.c   |  2 +-
>  drivers/gpu/drm/xe/tests/xe_guc_db_mgr_test.c |  2 +-
>  drivers/gpu/drm/xe/tests/xe_guc_g2g_test.c    |  2 +-
>  drivers/gpu/drm/xe/tests/xe_guc_id_mgr_test.c |  2 +-
>  drivers/gpu/drm/xe/tests/xe_guc_relay_test.c  |  8 ++++----
>  drivers/gpu/drm/xe/xe_device.h                |  4 ++--
>  drivers/gpu/drm/xe/xe_eu_stall.c              |  2 +-
>  drivers/gpu/drm/xe/xe_exec_queue.c            |  2 +-
>  drivers/gpu/drm/xe/xe_guc.c                   |  2 +-
>  drivers/gpu/drm/xe/xe_hw_engine.c             |  4 ++--
>  drivers/gpu/drm/xe/xe_pmu.c                   | 10 +++++-----
>  drivers/gpu/drm/xe/xe_query.c                 |  2 +-
>  drivers/gpu/drm/xe/xe_sriov_vf.c              |  2 +-
>  13 files changed, 22 insertions(+), 22 deletions(-)