From: Jani Nikula <jani.nikula@intel.com>
To: "Michał Grzelak" <michal.grzelak@intel.com>
Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Subject: Re: [v2] drm/{i915, xe}/pcode: move display pcode calls to parent interface
Date: Mon, 19 Jan 2026 12:14:43 +0200 [thread overview]
Message-ID: <037265c310c9f3901e2e47d00e2e225c76370f94@intel.com> (raw)
In-Reply-To: <f7329c3b-77f2-1944-16de-f3a75aa1a2aa@intel.com>
On Fri, 16 Jan 2026, Michał Grzelak <michal.grzelak@intel.com> wrote:
> While moving the code, should we rename val & val1 into val1 & val2 (or
> val2 & val1)? I think even renaming val -> val0 would suffice.
The variable naming matches the register macro naming. Historically,
there was only GEN6_PCODE_DATA, and GEN6_PCODE_DATA1 was added
afterwards. Hence val and val1.
Nowadays the spec has DATA0 and DATA1, so renaming both the register
macro and the variable to DATA0 and val0, respectively, would be fine.
Just not in this patch. Generally, only do one thing at a time.
> Or (if the comment is valid) should I send it as a separate patch?
The latter.
> Reviewed-by: Michał Grzelak <michal.grzelak@intel.com>
Thanks,
Jani.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2026-01-19 10:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-15 11:33 [PATCH v2] drm/{i915, xe}/pcode: move display pcode calls to parent interface Jani Nikula
2026-01-15 11:39 ` ✗ CI.checkpatch: warning for drm/{i915, xe}/pcode: move display pcode calls to parent interface (rev2) Patchwork
2026-01-15 11:40 ` ✓ CI.KUnit: success " Patchwork
2026-01-15 12:15 ` ✓ Xe.CI.BAT: " Patchwork
2026-01-15 13:20 ` ✗ Xe.CI.Full: failure " Patchwork
2026-01-16 17:38 ` [v2] drm/{i915, xe}/pcode: move display pcode calls to parent interface Michał Grzelak
2026-01-19 10:14 ` Jani Nikula [this message]
2026-01-19 22:57 ` Michał Grzelak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=037265c310c9f3901e2e47d00e2e225c76370f94@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=michal.grzelak@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox