* [PATCH] drm/gpuvm: Rename 'map' to 'op' in drm_gpuvm_map_req
@ 2025-08-20 15:23 Himal Prasad Ghimiray
2025-08-20 16:07 ` Boris Brezillon
` (6 more replies)
0 siblings, 7 replies; 17+ messages in thread
From: Himal Prasad Ghimiray @ 2025-08-20 15:23 UTC (permalink / raw)
To: intel-xe
Cc: Himal Prasad Ghimiray, Boris Brezillon, Danilo Krummrich,
Matt Coster, Rob Clark, Matthew Brost, dri-devel
Renamed 'map' to 'op' in drm_gpuvm_map_req for clarity and added
corresponding documentation. No functional changes introduced.
Fixes: baf1638c0956 ("drm/gpuvm: Introduce drm_gpuvm_madvise_ops_create")
Fixes: 000a45dce7ad ("drm/gpuvm: Pass map arguments through a struct")
Suggested-by: Boris Brezillon <bbrezillon@kernel.org>
Suggested-by: Danilo Krummrich <dakr@kernel.org>
Cc: Danilo Krummrich <dakr@kernel.org>
Cc: Matt Coster <matt.coster@imgtec.com>
Cc: Boris Brezillon <bbrezillon@kernel.org>
Cc: Rob Clark <robin.clark@oss.qualcomm.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: <dri-devel@lists.freedesktop.org>
Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
---
drivers/gpu/drm/drm_gpuvm.c | 36 +++++++++++++-------------
drivers/gpu/drm/imagination/pvr_vm.c | 8 +++---
drivers/gpu/drm/msm/msm_gem_vma.c | 16 ++++++------
drivers/gpu/drm/nouveau/nouveau_uvmm.c | 8 +++---
drivers/gpu/drm/panthor/panthor_mmu.c | 8 +++---
drivers/gpu/drm/xe/xe_vm.c | 8 +++---
include/drm/drm_gpuvm.h | 4 +--
7 files changed, 44 insertions(+), 44 deletions(-)
diff --git a/drivers/gpu/drm/drm_gpuvm.c b/drivers/gpu/drm/drm_gpuvm.c
index 39f934a91a7b..e9aaf9b287e7 100644
--- a/drivers/gpu/drm/drm_gpuvm.c
+++ b/drivers/gpu/drm/drm_gpuvm.c
@@ -552,11 +552,11 @@
* struct drm_gem_object *obj, u64 offset)
* {
* struct drm_gpuvm_map_req map_req = {
- * .map.va.addr = addr,
- * .map.va.range = range,
- * .map.gem.obj = obj,
- * .map.gem.offset = offset,
- * };
+ * .op.va.addr = addr,
+ * .op.va.range = range,
+ * .op.gem.obj = obj,
+ * .op.gem.offset = offset,
+ * };
* struct drm_gpuva_ops *ops;
* struct drm_gpuva_op *op
* struct drm_gpuvm_bo *vm_bo;
@@ -2132,10 +2132,10 @@ op_map_cb(const struct drm_gpuvm_ops *fn, void *priv,
return 0;
op.op = DRM_GPUVA_OP_MAP;
- op.map.va.addr = req->map.va.addr;
- op.map.va.range = req->map.va.range;
- op.map.gem.obj = req->map.gem.obj;
- op.map.gem.offset = req->map.gem.offset;
+ op.map.va.addr = req->op.va.addr;
+ op.map.va.range = req->op.va.range;
+ op.map.gem.obj = req->op.gem.obj;
+ op.map.gem.offset = req->op.gem.offset;
return fn->sm_step_map(&op, priv);
}
@@ -2180,12 +2180,12 @@ __drm_gpuvm_sm_map(struct drm_gpuvm *gpuvm,
const struct drm_gpuvm_map_req *req,
bool madvise)
{
- struct drm_gem_object *req_obj = req->map.gem.obj;
+ struct drm_gem_object *req_obj = req->op.gem.obj;
const struct drm_gpuvm_map_req *op_map = madvise ? NULL : req;
struct drm_gpuva *va, *next;
- u64 req_offset = req->map.gem.offset;
- u64 req_range = req->map.va.range;
- u64 req_addr = req->map.va.addr;
+ u64 req_offset = req->op.gem.offset;
+ u64 req_range = req->op.va.range;
+ u64 req_addr = req->op.va.addr;
u64 req_end = req_addr + req_range;
int ret;
@@ -2272,8 +2272,8 @@ __drm_gpuvm_sm_map(struct drm_gpuvm *gpuvm,
if (madvise) {
struct drm_gpuvm_map_req map_req = {
- .map.va.addr = req_addr,
- .map.va.range = end - req_addr,
+ .op.va.addr = req_addr,
+ .op.va.range = end - req_addr,
};
ret = op_map_cb(ops, priv, &map_req);
@@ -2340,8 +2340,8 @@ __drm_gpuvm_sm_map(struct drm_gpuvm *gpuvm,
if (madvise) {
struct drm_gpuvm_map_req map_req = {
- .map.va.addr = addr,
- .map.va.range = req_end - addr,
+ .op.va.addr = addr,
+ .op.va.range = req_end - addr,
};
return op_map_cb(ops, priv, &map_req);
@@ -2583,7 +2583,7 @@ drm_gpuvm_sm_map_exec_lock(struct drm_gpuvm *gpuvm,
struct drm_exec *exec, unsigned int num_fences,
struct drm_gpuvm_map_req *req)
{
- struct drm_gem_object *req_obj = req->map.gem.obj;
+ struct drm_gem_object *req_obj = req->op.gem.obj;
if (req_obj) {
int ret = drm_exec_prepare_obj(exec, req_obj, num_fences);
diff --git a/drivers/gpu/drm/imagination/pvr_vm.c b/drivers/gpu/drm/imagination/pvr_vm.c
index 3d97990170bf..983165eb3e6a 100644
--- a/drivers/gpu/drm/imagination/pvr_vm.c
+++ b/drivers/gpu/drm/imagination/pvr_vm.c
@@ -187,10 +187,10 @@ static int pvr_vm_bind_op_exec(struct pvr_vm_bind_op *bind_op)
switch (bind_op->type) {
case PVR_VM_BIND_TYPE_MAP: {
const struct drm_gpuvm_map_req map_req = {
- .map.va.addr = bind_op->device_addr,
- .map.va.range = bind_op->size,
- .map.gem.obj = gem_from_pvr_gem(bind_op->pvr_obj),
- .map.gem.offset = bind_op->offset,
+ .op.va.addr = bind_op->device_addr,
+ .op.va.range = bind_op->size,
+ .op.gem.obj = gem_from_pvr_gem(bind_op->pvr_obj),
+ .op.gem.offset = bind_op->offset,
};
return drm_gpuvm_sm_map(&bind_op->vm_ctx->gpuvm_mgr,
diff --git a/drivers/gpu/drm/msm/msm_gem_vma.c b/drivers/gpu/drm/msm/msm_gem_vma.c
index 210604181c05..9b5d003bc5a2 100644
--- a/drivers/gpu/drm/msm/msm_gem_vma.c
+++ b/drivers/gpu/drm/msm/msm_gem_vma.c
@@ -1179,10 +1179,10 @@ vm_bind_job_lock_objects(struct msm_vm_bind_job *job, struct drm_exec *exec)
case MSM_VM_BIND_OP_MAP:
case MSM_VM_BIND_OP_MAP_NULL: {
struct drm_gpuvm_map_req map_req = {
- .map.va.addr = op->iova,
- .map.va.range = op->range,
- .map.gem.obj = op->obj,
- .map.gem.offset = op->obj_offset,
+ .op.va.addr = op->iova,
+ .op.va.range = op->range,
+ .op.gem.obj = op->obj,
+ .op.gem.offset = op->obj_offset,
};
ret = drm_gpuvm_sm_map_exec_lock(job->vm, exec, 1, &map_req);
@@ -1296,10 +1296,10 @@ vm_bind_job_prepare(struct msm_vm_bind_job *job)
fallthrough;
case MSM_VM_BIND_OP_MAP_NULL: {
struct drm_gpuvm_map_req map_req = {
- .map.va.addr = op->iova,
- .map.va.range = op->range,
- .map.gem.obj = op->obj,
- .map.gem.offset = op->obj_offset,
+ .op.va.addr = op->iova,
+ .op.va.range = op->range,
+ .op.gem.obj = op->obj,
+ .op.gem.offset = op->obj_offset,
};
ret = drm_gpuvm_sm_map(job->vm, &arg, &map_req);
diff --git a/drivers/gpu/drm/nouveau/nouveau_uvmm.c b/drivers/gpu/drm/nouveau/nouveau_uvmm.c
index d94a85509176..314121a857e7 100644
--- a/drivers/gpu/drm/nouveau/nouveau_uvmm.c
+++ b/drivers/gpu/drm/nouveau/nouveau_uvmm.c
@@ -1277,10 +1277,10 @@ nouveau_uvmm_bind_job_submit(struct nouveau_job *job,
case OP_MAP: {
struct nouveau_uvma_region *reg;
struct drm_gpuvm_map_req map_req = {
- .map.va.addr = op->va.addr,
- .map.va.range = op->va.range,
- .map.gem.obj = op->gem.obj,
- .map.gem.offset = op->gem.offset,
+ .op.va.addr = op->va.addr,
+ .op.va.range = op->va.range,
+ .op.gem.obj = op->gem.obj,
+ .op.gem.offset = op->gem.offset,
};
reg = nouveau_uvma_region_find_first(uvmm,
diff --git a/drivers/gpu/drm/panthor/panthor_mmu.c b/drivers/gpu/drm/panthor/panthor_mmu.c
index 2003b91a8409..3799e2c6ea59 100644
--- a/drivers/gpu/drm/panthor/panthor_mmu.c
+++ b/drivers/gpu/drm/panthor/panthor_mmu.c
@@ -2204,10 +2204,10 @@ panthor_vm_exec_op(struct panthor_vm *vm, struct panthor_vm_op_ctx *op,
switch (op_type) {
case DRM_PANTHOR_VM_BIND_OP_TYPE_MAP: {
const struct drm_gpuvm_map_req map_req = {
- .map.va.addr = op->va.addr,
- .map.va.range = op->va.range,
- .map.gem.obj = op->map.vm_bo->obj,
- .map.gem.offset = op->map.bo_offset,
+ .op.va.addr = op->va.addr,
+ .op.va.range = op->va.range,
+ .op.gem.obj = op->map.vm_bo->obj,
+ .op.gem.offset = op->map.bo_offset,
};
if (vm->unusable) {
diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
index f35d69c0b4c6..66b54b152446 100644
--- a/drivers/gpu/drm/xe/xe_vm.c
+++ b/drivers/gpu/drm/xe/xe_vm.c
@@ -2339,10 +2339,10 @@ vm_bind_ioctl_ops_create(struct xe_vm *vm, struct xe_vma_ops *vops,
case DRM_XE_VM_BIND_OP_MAP:
case DRM_XE_VM_BIND_OP_MAP_USERPTR: {
struct drm_gpuvm_map_req map_req = {
- .map.va.addr = addr,
- .map.va.range = range,
- .map.gem.obj = obj,
- .map.gem.offset = bo_offset_or_userptr,
+ .op.va.addr = addr,
+ .op.va.range = range,
+ .op.gem.obj = obj,
+ .op.gem.offset = bo_offset_or_userptr,
};
ops = drm_gpuvm_sm_map_ops_create(&vm->gpuvm, &map_req);
diff --git a/include/drm/drm_gpuvm.h b/include/drm/drm_gpuvm.h
index 4a22b9d848f7..751c96a817ed 100644
--- a/include/drm/drm_gpuvm.h
+++ b/include/drm/drm_gpuvm.h
@@ -1054,9 +1054,9 @@ struct drm_gpuva_ops {
*/
struct drm_gpuvm_map_req {
/**
- * @op_map: struct drm_gpuva_op_map
+ * @op: struct drm_gpuva_op_map
*/
- struct drm_gpuva_op_map map;
+ struct drm_gpuva_op_map op;
};
struct drm_gpuva_ops *
--
2.34.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/gpuvm: Rename 'map' to 'op' in drm_gpuvm_map_req
2025-08-20 15:23 [PATCH] drm/gpuvm: Rename 'map' to 'op' in drm_gpuvm_map_req Himal Prasad Ghimiray
@ 2025-08-20 16:07 ` Boris Brezillon
2025-08-21 11:01 ` Boris Brezillon
2025-08-20 16:38 ` Danilo Krummrich
` (5 subsequent siblings)
6 siblings, 1 reply; 17+ messages in thread
From: Boris Brezillon @ 2025-08-20 16:07 UTC (permalink / raw)
To: Himal Prasad Ghimiray
Cc: intel-xe, Boris Brezillon, Danilo Krummrich, Matt Coster,
Rob Clark, Matthew Brost, dri-devel
On Wed, 20 Aug 2025 20:53:35 +0530
Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com> wrote:
> Renamed 'map' to 'op' in drm_gpuvm_map_req for clarity and added
> corresponding documentation. No functional changes introduced.
>
> Fixes: baf1638c0956 ("drm/gpuvm: Introduce drm_gpuvm_madvise_ops_create")
> Fixes: 000a45dce7ad ("drm/gpuvm: Pass map arguments through a struct")
> Suggested-by: Boris Brezillon <bbrezillon@kernel.org>
> Suggested-by: Danilo Krummrich <dakr@kernel.org>
> Cc: Danilo Krummrich <dakr@kernel.org>
> Cc: Matt Coster <matt.coster@imgtec.com>
> Cc: Boris Brezillon <bbrezillon@kernel.org>
> Cc: Rob Clark <robin.clark@oss.qualcomm.com>
> Cc: Matthew Brost <matthew.brost@intel.com>
> Cc: <dri-devel@lists.freedesktop.org>
> Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
Acked-by: Boris Brezillon <boris.brezillon@collabora.com>
> ---
> drivers/gpu/drm/drm_gpuvm.c | 36 +++++++++++++-------------
> drivers/gpu/drm/imagination/pvr_vm.c | 8 +++---
> drivers/gpu/drm/msm/msm_gem_vma.c | 16 ++++++------
> drivers/gpu/drm/nouveau/nouveau_uvmm.c | 8 +++---
> drivers/gpu/drm/panthor/panthor_mmu.c | 8 +++---
> drivers/gpu/drm/xe/xe_vm.c | 8 +++---
> include/drm/drm_gpuvm.h | 4 +--
> 7 files changed, 44 insertions(+), 44 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_gpuvm.c b/drivers/gpu/drm/drm_gpuvm.c
> index 39f934a91a7b..e9aaf9b287e7 100644
> --- a/drivers/gpu/drm/drm_gpuvm.c
> +++ b/drivers/gpu/drm/drm_gpuvm.c
> @@ -552,11 +552,11 @@
> * struct drm_gem_object *obj, u64 offset)
> * {
> * struct drm_gpuvm_map_req map_req = {
> - * .map.va.addr = addr,
> - * .map.va.range = range,
> - * .map.gem.obj = obj,
> - * .map.gem.offset = offset,
> - * };
> + * .op.va.addr = addr,
> + * .op.va.range = range,
> + * .op.gem.obj = obj,
> + * .op.gem.offset = offset,
> + * };
> * struct drm_gpuva_ops *ops;
> * struct drm_gpuva_op *op
> * struct drm_gpuvm_bo *vm_bo;
> @@ -2132,10 +2132,10 @@ op_map_cb(const struct drm_gpuvm_ops *fn, void *priv,
> return 0;
>
> op.op = DRM_GPUVA_OP_MAP;
> - op.map.va.addr = req->map.va.addr;
> - op.map.va.range = req->map.va.range;
> - op.map.gem.obj = req->map.gem.obj;
> - op.map.gem.offset = req->map.gem.offset;
> + op.map.va.addr = req->op.va.addr;
> + op.map.va.range = req->op.va.range;
> + op.map.gem.obj = req->op.gem.obj;
> + op.map.gem.offset = req->op.gem.offset;
>
> return fn->sm_step_map(&op, priv);
> }
> @@ -2180,12 +2180,12 @@ __drm_gpuvm_sm_map(struct drm_gpuvm *gpuvm,
> const struct drm_gpuvm_map_req *req,
> bool madvise)
> {
> - struct drm_gem_object *req_obj = req->map.gem.obj;
> + struct drm_gem_object *req_obj = req->op.gem.obj;
> const struct drm_gpuvm_map_req *op_map = madvise ? NULL : req;
> struct drm_gpuva *va, *next;
> - u64 req_offset = req->map.gem.offset;
> - u64 req_range = req->map.va.range;
> - u64 req_addr = req->map.va.addr;
> + u64 req_offset = req->op.gem.offset;
> + u64 req_range = req->op.va.range;
> + u64 req_addr = req->op.va.addr;
> u64 req_end = req_addr + req_range;
> int ret;
>
> @@ -2272,8 +2272,8 @@ __drm_gpuvm_sm_map(struct drm_gpuvm *gpuvm,
>
> if (madvise) {
> struct drm_gpuvm_map_req map_req = {
> - .map.va.addr = req_addr,
> - .map.va.range = end - req_addr,
> + .op.va.addr = req_addr,
> + .op.va.range = end - req_addr,
> };
>
> ret = op_map_cb(ops, priv, &map_req);
> @@ -2340,8 +2340,8 @@ __drm_gpuvm_sm_map(struct drm_gpuvm *gpuvm,
>
> if (madvise) {
> struct drm_gpuvm_map_req map_req = {
> - .map.va.addr = addr,
> - .map.va.range = req_end - addr,
> + .op.va.addr = addr,
> + .op.va.range = req_end - addr,
> };
>
> return op_map_cb(ops, priv, &map_req);
> @@ -2583,7 +2583,7 @@ drm_gpuvm_sm_map_exec_lock(struct drm_gpuvm *gpuvm,
> struct drm_exec *exec, unsigned int num_fences,
> struct drm_gpuvm_map_req *req)
> {
> - struct drm_gem_object *req_obj = req->map.gem.obj;
> + struct drm_gem_object *req_obj = req->op.gem.obj;
>
> if (req_obj) {
> int ret = drm_exec_prepare_obj(exec, req_obj, num_fences);
> diff --git a/drivers/gpu/drm/imagination/pvr_vm.c b/drivers/gpu/drm/imagination/pvr_vm.c
> index 3d97990170bf..983165eb3e6a 100644
> --- a/drivers/gpu/drm/imagination/pvr_vm.c
> +++ b/drivers/gpu/drm/imagination/pvr_vm.c
> @@ -187,10 +187,10 @@ static int pvr_vm_bind_op_exec(struct pvr_vm_bind_op *bind_op)
> switch (bind_op->type) {
> case PVR_VM_BIND_TYPE_MAP: {
> const struct drm_gpuvm_map_req map_req = {
> - .map.va.addr = bind_op->device_addr,
> - .map.va.range = bind_op->size,
> - .map.gem.obj = gem_from_pvr_gem(bind_op->pvr_obj),
> - .map.gem.offset = bind_op->offset,
> + .op.va.addr = bind_op->device_addr,
> + .op.va.range = bind_op->size,
> + .op.gem.obj = gem_from_pvr_gem(bind_op->pvr_obj),
> + .op.gem.offset = bind_op->offset,
> };
>
> return drm_gpuvm_sm_map(&bind_op->vm_ctx->gpuvm_mgr,
> diff --git a/drivers/gpu/drm/msm/msm_gem_vma.c b/drivers/gpu/drm/msm/msm_gem_vma.c
> index 210604181c05..9b5d003bc5a2 100644
> --- a/drivers/gpu/drm/msm/msm_gem_vma.c
> +++ b/drivers/gpu/drm/msm/msm_gem_vma.c
> @@ -1179,10 +1179,10 @@ vm_bind_job_lock_objects(struct msm_vm_bind_job *job, struct drm_exec *exec)
> case MSM_VM_BIND_OP_MAP:
> case MSM_VM_BIND_OP_MAP_NULL: {
> struct drm_gpuvm_map_req map_req = {
> - .map.va.addr = op->iova,
> - .map.va.range = op->range,
> - .map.gem.obj = op->obj,
> - .map.gem.offset = op->obj_offset,
> + .op.va.addr = op->iova,
> + .op.va.range = op->range,
> + .op.gem.obj = op->obj,
> + .op.gem.offset = op->obj_offset,
> };
>
> ret = drm_gpuvm_sm_map_exec_lock(job->vm, exec, 1, &map_req);
> @@ -1296,10 +1296,10 @@ vm_bind_job_prepare(struct msm_vm_bind_job *job)
> fallthrough;
> case MSM_VM_BIND_OP_MAP_NULL: {
> struct drm_gpuvm_map_req map_req = {
> - .map.va.addr = op->iova,
> - .map.va.range = op->range,
> - .map.gem.obj = op->obj,
> - .map.gem.offset = op->obj_offset,
> + .op.va.addr = op->iova,
> + .op.va.range = op->range,
> + .op.gem.obj = op->obj,
> + .op.gem.offset = op->obj_offset,
> };
>
> ret = drm_gpuvm_sm_map(job->vm, &arg, &map_req);
> diff --git a/drivers/gpu/drm/nouveau/nouveau_uvmm.c b/drivers/gpu/drm/nouveau/nouveau_uvmm.c
> index d94a85509176..314121a857e7 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_uvmm.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_uvmm.c
> @@ -1277,10 +1277,10 @@ nouveau_uvmm_bind_job_submit(struct nouveau_job *job,
> case OP_MAP: {
> struct nouveau_uvma_region *reg;
> struct drm_gpuvm_map_req map_req = {
> - .map.va.addr = op->va.addr,
> - .map.va.range = op->va.range,
> - .map.gem.obj = op->gem.obj,
> - .map.gem.offset = op->gem.offset,
> + .op.va.addr = op->va.addr,
> + .op.va.range = op->va.range,
> + .op.gem.obj = op->gem.obj,
> + .op.gem.offset = op->gem.offset,
> };
>
> reg = nouveau_uvma_region_find_first(uvmm,
> diff --git a/drivers/gpu/drm/panthor/panthor_mmu.c b/drivers/gpu/drm/panthor/panthor_mmu.c
> index 2003b91a8409..3799e2c6ea59 100644
> --- a/drivers/gpu/drm/panthor/panthor_mmu.c
> +++ b/drivers/gpu/drm/panthor/panthor_mmu.c
> @@ -2204,10 +2204,10 @@ panthor_vm_exec_op(struct panthor_vm *vm, struct panthor_vm_op_ctx *op,
> switch (op_type) {
> case DRM_PANTHOR_VM_BIND_OP_TYPE_MAP: {
> const struct drm_gpuvm_map_req map_req = {
> - .map.va.addr = op->va.addr,
> - .map.va.range = op->va.range,
> - .map.gem.obj = op->map.vm_bo->obj,
> - .map.gem.offset = op->map.bo_offset,
> + .op.va.addr = op->va.addr,
> + .op.va.range = op->va.range,
> + .op.gem.obj = op->map.vm_bo->obj,
> + .op.gem.offset = op->map.bo_offset,
> };
>
> if (vm->unusable) {
> diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
> index f35d69c0b4c6..66b54b152446 100644
> --- a/drivers/gpu/drm/xe/xe_vm.c
> +++ b/drivers/gpu/drm/xe/xe_vm.c
> @@ -2339,10 +2339,10 @@ vm_bind_ioctl_ops_create(struct xe_vm *vm, struct xe_vma_ops *vops,
> case DRM_XE_VM_BIND_OP_MAP:
> case DRM_XE_VM_BIND_OP_MAP_USERPTR: {
> struct drm_gpuvm_map_req map_req = {
> - .map.va.addr = addr,
> - .map.va.range = range,
> - .map.gem.obj = obj,
> - .map.gem.offset = bo_offset_or_userptr,
> + .op.va.addr = addr,
> + .op.va.range = range,
> + .op.gem.obj = obj,
> + .op.gem.offset = bo_offset_or_userptr,
> };
>
> ops = drm_gpuvm_sm_map_ops_create(&vm->gpuvm, &map_req);
> diff --git a/include/drm/drm_gpuvm.h b/include/drm/drm_gpuvm.h
> index 4a22b9d848f7..751c96a817ed 100644
> --- a/include/drm/drm_gpuvm.h
> +++ b/include/drm/drm_gpuvm.h
> @@ -1054,9 +1054,9 @@ struct drm_gpuva_ops {
> */
> struct drm_gpuvm_map_req {
> /**
> - * @op_map: struct drm_gpuva_op_map
> + * @op: struct drm_gpuva_op_map
> */
> - struct drm_gpuva_op_map map;
> + struct drm_gpuva_op_map op;
> };
>
> struct drm_gpuva_ops *
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/gpuvm: Rename 'map' to 'op' in drm_gpuvm_map_req
2025-08-20 15:23 [PATCH] drm/gpuvm: Rename 'map' to 'op' in drm_gpuvm_map_req Himal Prasad Ghimiray
2025-08-20 16:07 ` Boris Brezillon
@ 2025-08-20 16:38 ` Danilo Krummrich
2025-08-20 16:53 ` Rob Clark
` (4 subsequent siblings)
6 siblings, 0 replies; 17+ messages in thread
From: Danilo Krummrich @ 2025-08-20 16:38 UTC (permalink / raw)
To: Himal Prasad Ghimiray
Cc: intel-xe, Boris Brezillon, Matt Coster, Rob Clark, Matthew Brost,
dri-devel
On Wed Aug 20, 2025 at 5:23 PM CEST, Himal Prasad Ghimiray wrote:
> Renamed 'map' to 'op' in drm_gpuvm_map_req for clarity and added
> corresponding documentation. No functional changes introduced.
>
> Fixes: baf1638c0956 ("drm/gpuvm: Introduce drm_gpuvm_madvise_ops_create")
> Fixes: 000a45dce7ad ("drm/gpuvm: Pass map arguments through a struct")
> Suggested-by: Boris Brezillon <bbrezillon@kernel.org>
> Suggested-by: Danilo Krummrich <dakr@kernel.org>
> Cc: Danilo Krummrich <dakr@kernel.org>
> Cc: Matt Coster <matt.coster@imgtec.com>
> Cc: Boris Brezillon <bbrezillon@kernel.org>
> Cc: Rob Clark <robin.clark@oss.qualcomm.com>
> Cc: Matthew Brost <matthew.brost@intel.com>
> Cc: <dri-devel@lists.freedesktop.org>
> Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
Acked-by: Danilo Krummrich <dakr@kernel.org>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/gpuvm: Rename 'map' to 'op' in drm_gpuvm_map_req
2025-08-20 15:23 [PATCH] drm/gpuvm: Rename 'map' to 'op' in drm_gpuvm_map_req Himal Prasad Ghimiray
2025-08-20 16:07 ` Boris Brezillon
2025-08-20 16:38 ` Danilo Krummrich
@ 2025-08-20 16:53 ` Rob Clark
2025-08-20 16:56 ` Matt Coster
` (3 subsequent siblings)
6 siblings, 0 replies; 17+ messages in thread
From: Rob Clark @ 2025-08-20 16:53 UTC (permalink / raw)
To: Himal Prasad Ghimiray
Cc: intel-xe, Boris Brezillon, Danilo Krummrich, Matt Coster,
Matthew Brost, dri-devel
On Wed, Aug 20, 2025 at 7:56 AM Himal Prasad Ghimiray
<himal.prasad.ghimiray@intel.com> wrote:
>
> Renamed 'map' to 'op' in drm_gpuvm_map_req for clarity and added
> corresponding documentation. No functional changes introduced.
>
> Fixes: baf1638c0956 ("drm/gpuvm: Introduce drm_gpuvm_madvise_ops_create")
> Fixes: 000a45dce7ad ("drm/gpuvm: Pass map arguments through a struct")
> Suggested-by: Boris Brezillon <bbrezillon@kernel.org>
> Suggested-by: Danilo Krummrich <dakr@kernel.org>
> Cc: Danilo Krummrich <dakr@kernel.org>
> Cc: Matt Coster <matt.coster@imgtec.com>
> Cc: Boris Brezillon <bbrezillon@kernel.org>
> Cc: Rob Clark <robin.clark@oss.qualcomm.com>
> Cc: Matthew Brost <matthew.brost@intel.com>
> Cc: <dri-devel@lists.freedesktop.org>
> Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
Acked-by: Rob Clark <robin.clark@oss.qualcomm.com>
> ---
> drivers/gpu/drm/drm_gpuvm.c | 36 +++++++++++++-------------
> drivers/gpu/drm/imagination/pvr_vm.c | 8 +++---
> drivers/gpu/drm/msm/msm_gem_vma.c | 16 ++++++------
> drivers/gpu/drm/nouveau/nouveau_uvmm.c | 8 +++---
> drivers/gpu/drm/panthor/panthor_mmu.c | 8 +++---
> drivers/gpu/drm/xe/xe_vm.c | 8 +++---
> include/drm/drm_gpuvm.h | 4 +--
> 7 files changed, 44 insertions(+), 44 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_gpuvm.c b/drivers/gpu/drm/drm_gpuvm.c
> index 39f934a91a7b..e9aaf9b287e7 100644
> --- a/drivers/gpu/drm/drm_gpuvm.c
> +++ b/drivers/gpu/drm/drm_gpuvm.c
> @@ -552,11 +552,11 @@
> * struct drm_gem_object *obj, u64 offset)
> * {
> * struct drm_gpuvm_map_req map_req = {
> - * .map.va.addr = addr,
> - * .map.va.range = range,
> - * .map.gem.obj = obj,
> - * .map.gem.offset = offset,
> - * };
> + * .op.va.addr = addr,
> + * .op.va.range = range,
> + * .op.gem.obj = obj,
> + * .op.gem.offset = offset,
> + * };
> * struct drm_gpuva_ops *ops;
> * struct drm_gpuva_op *op
> * struct drm_gpuvm_bo *vm_bo;
> @@ -2132,10 +2132,10 @@ op_map_cb(const struct drm_gpuvm_ops *fn, void *priv,
> return 0;
>
> op.op = DRM_GPUVA_OP_MAP;
> - op.map.va.addr = req->map.va.addr;
> - op.map.va.range = req->map.va.range;
> - op.map.gem.obj = req->map.gem.obj;
> - op.map.gem.offset = req->map.gem.offset;
> + op.map.va.addr = req->op.va.addr;
> + op.map.va.range = req->op.va.range;
> + op.map.gem.obj = req->op.gem.obj;
> + op.map.gem.offset = req->op.gem.offset;
>
> return fn->sm_step_map(&op, priv);
> }
> @@ -2180,12 +2180,12 @@ __drm_gpuvm_sm_map(struct drm_gpuvm *gpuvm,
> const struct drm_gpuvm_map_req *req,
> bool madvise)
> {
> - struct drm_gem_object *req_obj = req->map.gem.obj;
> + struct drm_gem_object *req_obj = req->op.gem.obj;
> const struct drm_gpuvm_map_req *op_map = madvise ? NULL : req;
> struct drm_gpuva *va, *next;
> - u64 req_offset = req->map.gem.offset;
> - u64 req_range = req->map.va.range;
> - u64 req_addr = req->map.va.addr;
> + u64 req_offset = req->op.gem.offset;
> + u64 req_range = req->op.va.range;
> + u64 req_addr = req->op.va.addr;
> u64 req_end = req_addr + req_range;
> int ret;
>
> @@ -2272,8 +2272,8 @@ __drm_gpuvm_sm_map(struct drm_gpuvm *gpuvm,
>
> if (madvise) {
> struct drm_gpuvm_map_req map_req = {
> - .map.va.addr = req_addr,
> - .map.va.range = end - req_addr,
> + .op.va.addr = req_addr,
> + .op.va.range = end - req_addr,
> };
>
> ret = op_map_cb(ops, priv, &map_req);
> @@ -2340,8 +2340,8 @@ __drm_gpuvm_sm_map(struct drm_gpuvm *gpuvm,
>
> if (madvise) {
> struct drm_gpuvm_map_req map_req = {
> - .map.va.addr = addr,
> - .map.va.range = req_end - addr,
> + .op.va.addr = addr,
> + .op.va.range = req_end - addr,
> };
>
> return op_map_cb(ops, priv, &map_req);
> @@ -2583,7 +2583,7 @@ drm_gpuvm_sm_map_exec_lock(struct drm_gpuvm *gpuvm,
> struct drm_exec *exec, unsigned int num_fences,
> struct drm_gpuvm_map_req *req)
> {
> - struct drm_gem_object *req_obj = req->map.gem.obj;
> + struct drm_gem_object *req_obj = req->op.gem.obj;
>
> if (req_obj) {
> int ret = drm_exec_prepare_obj(exec, req_obj, num_fences);
> diff --git a/drivers/gpu/drm/imagination/pvr_vm.c b/drivers/gpu/drm/imagination/pvr_vm.c
> index 3d97990170bf..983165eb3e6a 100644
> --- a/drivers/gpu/drm/imagination/pvr_vm.c
> +++ b/drivers/gpu/drm/imagination/pvr_vm.c
> @@ -187,10 +187,10 @@ static int pvr_vm_bind_op_exec(struct pvr_vm_bind_op *bind_op)
> switch (bind_op->type) {
> case PVR_VM_BIND_TYPE_MAP: {
> const struct drm_gpuvm_map_req map_req = {
> - .map.va.addr = bind_op->device_addr,
> - .map.va.range = bind_op->size,
> - .map.gem.obj = gem_from_pvr_gem(bind_op->pvr_obj),
> - .map.gem.offset = bind_op->offset,
> + .op.va.addr = bind_op->device_addr,
> + .op.va.range = bind_op->size,
> + .op.gem.obj = gem_from_pvr_gem(bind_op->pvr_obj),
> + .op.gem.offset = bind_op->offset,
> };
>
> return drm_gpuvm_sm_map(&bind_op->vm_ctx->gpuvm_mgr,
> diff --git a/drivers/gpu/drm/msm/msm_gem_vma.c b/drivers/gpu/drm/msm/msm_gem_vma.c
> index 210604181c05..9b5d003bc5a2 100644
> --- a/drivers/gpu/drm/msm/msm_gem_vma.c
> +++ b/drivers/gpu/drm/msm/msm_gem_vma.c
> @@ -1179,10 +1179,10 @@ vm_bind_job_lock_objects(struct msm_vm_bind_job *job, struct drm_exec *exec)
> case MSM_VM_BIND_OP_MAP:
> case MSM_VM_BIND_OP_MAP_NULL: {
> struct drm_gpuvm_map_req map_req = {
> - .map.va.addr = op->iova,
> - .map.va.range = op->range,
> - .map.gem.obj = op->obj,
> - .map.gem.offset = op->obj_offset,
> + .op.va.addr = op->iova,
> + .op.va.range = op->range,
> + .op.gem.obj = op->obj,
> + .op.gem.offset = op->obj_offset,
> };
>
> ret = drm_gpuvm_sm_map_exec_lock(job->vm, exec, 1, &map_req);
> @@ -1296,10 +1296,10 @@ vm_bind_job_prepare(struct msm_vm_bind_job *job)
> fallthrough;
> case MSM_VM_BIND_OP_MAP_NULL: {
> struct drm_gpuvm_map_req map_req = {
> - .map.va.addr = op->iova,
> - .map.va.range = op->range,
> - .map.gem.obj = op->obj,
> - .map.gem.offset = op->obj_offset,
> + .op.va.addr = op->iova,
> + .op.va.range = op->range,
> + .op.gem.obj = op->obj,
> + .op.gem.offset = op->obj_offset,
> };
>
> ret = drm_gpuvm_sm_map(job->vm, &arg, &map_req);
> diff --git a/drivers/gpu/drm/nouveau/nouveau_uvmm.c b/drivers/gpu/drm/nouveau/nouveau_uvmm.c
> index d94a85509176..314121a857e7 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_uvmm.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_uvmm.c
> @@ -1277,10 +1277,10 @@ nouveau_uvmm_bind_job_submit(struct nouveau_job *job,
> case OP_MAP: {
> struct nouveau_uvma_region *reg;
> struct drm_gpuvm_map_req map_req = {
> - .map.va.addr = op->va.addr,
> - .map.va.range = op->va.range,
> - .map.gem.obj = op->gem.obj,
> - .map.gem.offset = op->gem.offset,
> + .op.va.addr = op->va.addr,
> + .op.va.range = op->va.range,
> + .op.gem.obj = op->gem.obj,
> + .op.gem.offset = op->gem.offset,
> };
>
> reg = nouveau_uvma_region_find_first(uvmm,
> diff --git a/drivers/gpu/drm/panthor/panthor_mmu.c b/drivers/gpu/drm/panthor/panthor_mmu.c
> index 2003b91a8409..3799e2c6ea59 100644
> --- a/drivers/gpu/drm/panthor/panthor_mmu.c
> +++ b/drivers/gpu/drm/panthor/panthor_mmu.c
> @@ -2204,10 +2204,10 @@ panthor_vm_exec_op(struct panthor_vm *vm, struct panthor_vm_op_ctx *op,
> switch (op_type) {
> case DRM_PANTHOR_VM_BIND_OP_TYPE_MAP: {
> const struct drm_gpuvm_map_req map_req = {
> - .map.va.addr = op->va.addr,
> - .map.va.range = op->va.range,
> - .map.gem.obj = op->map.vm_bo->obj,
> - .map.gem.offset = op->map.bo_offset,
> + .op.va.addr = op->va.addr,
> + .op.va.range = op->va.range,
> + .op.gem.obj = op->map.vm_bo->obj,
> + .op.gem.offset = op->map.bo_offset,
> };
>
> if (vm->unusable) {
> diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
> index f35d69c0b4c6..66b54b152446 100644
> --- a/drivers/gpu/drm/xe/xe_vm.c
> +++ b/drivers/gpu/drm/xe/xe_vm.c
> @@ -2339,10 +2339,10 @@ vm_bind_ioctl_ops_create(struct xe_vm *vm, struct xe_vma_ops *vops,
> case DRM_XE_VM_BIND_OP_MAP:
> case DRM_XE_VM_BIND_OP_MAP_USERPTR: {
> struct drm_gpuvm_map_req map_req = {
> - .map.va.addr = addr,
> - .map.va.range = range,
> - .map.gem.obj = obj,
> - .map.gem.offset = bo_offset_or_userptr,
> + .op.va.addr = addr,
> + .op.va.range = range,
> + .op.gem.obj = obj,
> + .op.gem.offset = bo_offset_or_userptr,
> };
>
> ops = drm_gpuvm_sm_map_ops_create(&vm->gpuvm, &map_req);
> diff --git a/include/drm/drm_gpuvm.h b/include/drm/drm_gpuvm.h
> index 4a22b9d848f7..751c96a817ed 100644
> --- a/include/drm/drm_gpuvm.h
> +++ b/include/drm/drm_gpuvm.h
> @@ -1054,9 +1054,9 @@ struct drm_gpuva_ops {
> */
> struct drm_gpuvm_map_req {
> /**
> - * @op_map: struct drm_gpuva_op_map
> + * @op: struct drm_gpuva_op_map
> */
> - struct drm_gpuva_op_map map;
> + struct drm_gpuva_op_map op;
> };
>
> struct drm_gpuva_ops *
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/gpuvm: Rename 'map' to 'op' in drm_gpuvm_map_req
2025-08-20 15:23 [PATCH] drm/gpuvm: Rename 'map' to 'op' in drm_gpuvm_map_req Himal Prasad Ghimiray
` (2 preceding siblings ...)
2025-08-20 16:53 ` Rob Clark
@ 2025-08-20 16:56 ` Matt Coster
2025-08-20 20:15 ` ✓ CI.KUnit: success for " Patchwork
` (2 subsequent siblings)
6 siblings, 0 replies; 17+ messages in thread
From: Matt Coster @ 2025-08-20 16:56 UTC (permalink / raw)
To: Himal Prasad Ghimiray
Cc: Boris Brezillon, Danilo Krummrich, Rob Clark, Matthew Brost,
dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org
[-- Attachment #1.1: Type: text/plain, Size: 9453 bytes --]
On 20/08/2025 16:23, Himal Prasad Ghimiray wrote:
> Renamed 'map' to 'op' in drm_gpuvm_map_req for clarity and added
> corresponding documentation. No functional changes introduced.
>
> Fixes: baf1638c0956 ("drm/gpuvm: Introduce drm_gpuvm_madvise_ops_create")
> Fixes: 000a45dce7ad ("drm/gpuvm: Pass map arguments through a struct")
> Suggested-by: Boris Brezillon <bbrezillon@kernel.org>
> Suggested-by: Danilo Krummrich <dakr@kernel.org>
> Cc: Danilo Krummrich <dakr@kernel.org>
> Cc: Matt Coster <matt.coster@imgtec.com>
> Cc: Boris Brezillon <bbrezillon@kernel.org>
> Cc: Rob Clark <robin.clark@oss.qualcomm.com>
> Cc: Matthew Brost <matthew.brost@intel.com>
> Cc: <dri-devel@lists.freedesktop.org>
> Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
Acked-by: Matt Coster <matt.coster@imgtec.com>
Cheers,
Matt
> ---
> drivers/gpu/drm/drm_gpuvm.c | 36 +++++++++++++-------------
> drivers/gpu/drm/imagination/pvr_vm.c | 8 +++---
> drivers/gpu/drm/msm/msm_gem_vma.c | 16 ++++++------
> drivers/gpu/drm/nouveau/nouveau_uvmm.c | 8 +++---
> drivers/gpu/drm/panthor/panthor_mmu.c | 8 +++---
> drivers/gpu/drm/xe/xe_vm.c | 8 +++---
> include/drm/drm_gpuvm.h | 4 +--
> 7 files changed, 44 insertions(+), 44 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_gpuvm.c b/drivers/gpu/drm/drm_gpuvm.c
> index 39f934a91a7b..e9aaf9b287e7 100644
> --- a/drivers/gpu/drm/drm_gpuvm.c
> +++ b/drivers/gpu/drm/drm_gpuvm.c
> @@ -552,11 +552,11 @@
> * struct drm_gem_object *obj, u64 offset)
> * {
> * struct drm_gpuvm_map_req map_req = {
> - * .map.va.addr = addr,
> - * .map.va.range = range,
> - * .map.gem.obj = obj,
> - * .map.gem.offset = offset,
> - * };
> + * .op.va.addr = addr,
> + * .op.va.range = range,
> + * .op.gem.obj = obj,
> + * .op.gem.offset = offset,
> + * };
> * struct drm_gpuva_ops *ops;
> * struct drm_gpuva_op *op
> * struct drm_gpuvm_bo *vm_bo;
> @@ -2132,10 +2132,10 @@ op_map_cb(const struct drm_gpuvm_ops *fn, void *priv,
> return 0;
>
> op.op = DRM_GPUVA_OP_MAP;
> - op.map.va.addr = req->map.va.addr;
> - op.map.va.range = req->map.va.range;
> - op.map.gem.obj = req->map.gem.obj;
> - op.map.gem.offset = req->map.gem.offset;
> + op.map.va.addr = req->op.va.addr;
> + op.map.va.range = req->op.va.range;
> + op.map.gem.obj = req->op.gem.obj;
> + op.map.gem.offset = req->op.gem.offset;
>
> return fn->sm_step_map(&op, priv);
> }
> @@ -2180,12 +2180,12 @@ __drm_gpuvm_sm_map(struct drm_gpuvm *gpuvm,
> const struct drm_gpuvm_map_req *req,
> bool madvise)
> {
> - struct drm_gem_object *req_obj = req->map.gem.obj;
> + struct drm_gem_object *req_obj = req->op.gem.obj;
> const struct drm_gpuvm_map_req *op_map = madvise ? NULL : req;
> struct drm_gpuva *va, *next;
> - u64 req_offset = req->map.gem.offset;
> - u64 req_range = req->map.va.range;
> - u64 req_addr = req->map.va.addr;
> + u64 req_offset = req->op.gem.offset;
> + u64 req_range = req->op.va.range;
> + u64 req_addr = req->op.va.addr;
> u64 req_end = req_addr + req_range;
> int ret;
>
> @@ -2272,8 +2272,8 @@ __drm_gpuvm_sm_map(struct drm_gpuvm *gpuvm,
>
> if (madvise) {
> struct drm_gpuvm_map_req map_req = {
> - .map.va.addr = req_addr,
> - .map.va.range = end - req_addr,
> + .op.va.addr = req_addr,
> + .op.va.range = end - req_addr,
> };
>
> ret = op_map_cb(ops, priv, &map_req);
> @@ -2340,8 +2340,8 @@ __drm_gpuvm_sm_map(struct drm_gpuvm *gpuvm,
>
> if (madvise) {
> struct drm_gpuvm_map_req map_req = {
> - .map.va.addr = addr,
> - .map.va.range = req_end - addr,
> + .op.va.addr = addr,
> + .op.va.range = req_end - addr,
> };
>
> return op_map_cb(ops, priv, &map_req);
> @@ -2583,7 +2583,7 @@ drm_gpuvm_sm_map_exec_lock(struct drm_gpuvm *gpuvm,
> struct drm_exec *exec, unsigned int num_fences,
> struct drm_gpuvm_map_req *req)
> {
> - struct drm_gem_object *req_obj = req->map.gem.obj;
> + struct drm_gem_object *req_obj = req->op.gem.obj;
>
> if (req_obj) {
> int ret = drm_exec_prepare_obj(exec, req_obj, num_fences);
> diff --git a/drivers/gpu/drm/imagination/pvr_vm.c b/drivers/gpu/drm/imagination/pvr_vm.c
> index 3d97990170bf..983165eb3e6a 100644
> --- a/drivers/gpu/drm/imagination/pvr_vm.c
> +++ b/drivers/gpu/drm/imagination/pvr_vm.c
> @@ -187,10 +187,10 @@ static int pvr_vm_bind_op_exec(struct pvr_vm_bind_op *bind_op)
> switch (bind_op->type) {
> case PVR_VM_BIND_TYPE_MAP: {
> const struct drm_gpuvm_map_req map_req = {
> - .map.va.addr = bind_op->device_addr,
> - .map.va.range = bind_op->size,
> - .map.gem.obj = gem_from_pvr_gem(bind_op->pvr_obj),
> - .map.gem.offset = bind_op->offset,
> + .op.va.addr = bind_op->device_addr,
> + .op.va.range = bind_op->size,
> + .op.gem.obj = gem_from_pvr_gem(bind_op->pvr_obj),
> + .op.gem.offset = bind_op->offset,
> };
>
> return drm_gpuvm_sm_map(&bind_op->vm_ctx->gpuvm_mgr,
> diff --git a/drivers/gpu/drm/msm/msm_gem_vma.c b/drivers/gpu/drm/msm/msm_gem_vma.c
> index 210604181c05..9b5d003bc5a2 100644
> --- a/drivers/gpu/drm/msm/msm_gem_vma.c
> +++ b/drivers/gpu/drm/msm/msm_gem_vma.c
> @@ -1179,10 +1179,10 @@ vm_bind_job_lock_objects(struct msm_vm_bind_job *job, struct drm_exec *exec)
> case MSM_VM_BIND_OP_MAP:
> case MSM_VM_BIND_OP_MAP_NULL: {
> struct drm_gpuvm_map_req map_req = {
> - .map.va.addr = op->iova,
> - .map.va.range = op->range,
> - .map.gem.obj = op->obj,
> - .map.gem.offset = op->obj_offset,
> + .op.va.addr = op->iova,
> + .op.va.range = op->range,
> + .op.gem.obj = op->obj,
> + .op.gem.offset = op->obj_offset,
> };
>
> ret = drm_gpuvm_sm_map_exec_lock(job->vm, exec, 1, &map_req);
> @@ -1296,10 +1296,10 @@ vm_bind_job_prepare(struct msm_vm_bind_job *job)
> fallthrough;
> case MSM_VM_BIND_OP_MAP_NULL: {
> struct drm_gpuvm_map_req map_req = {
> - .map.va.addr = op->iova,
> - .map.va.range = op->range,
> - .map.gem.obj = op->obj,
> - .map.gem.offset = op->obj_offset,
> + .op.va.addr = op->iova,
> + .op.va.range = op->range,
> + .op.gem.obj = op->obj,
> + .op.gem.offset = op->obj_offset,
> };
>
> ret = drm_gpuvm_sm_map(job->vm, &arg, &map_req);
> diff --git a/drivers/gpu/drm/nouveau/nouveau_uvmm.c b/drivers/gpu/drm/nouveau/nouveau_uvmm.c
> index d94a85509176..314121a857e7 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_uvmm.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_uvmm.c
> @@ -1277,10 +1277,10 @@ nouveau_uvmm_bind_job_submit(struct nouveau_job *job,
> case OP_MAP: {
> struct nouveau_uvma_region *reg;
> struct drm_gpuvm_map_req map_req = {
> - .map.va.addr = op->va.addr,
> - .map.va.range = op->va.range,
> - .map.gem.obj = op->gem.obj,
> - .map.gem.offset = op->gem.offset,
> + .op.va.addr = op->va.addr,
> + .op.va.range = op->va.range,
> + .op.gem.obj = op->gem.obj,
> + .op.gem.offset = op->gem.offset,
> };
>
> reg = nouveau_uvma_region_find_first(uvmm,
> diff --git a/drivers/gpu/drm/panthor/panthor_mmu.c b/drivers/gpu/drm/panthor/panthor_mmu.c
> index 2003b91a8409..3799e2c6ea59 100644
> --- a/drivers/gpu/drm/panthor/panthor_mmu.c
> +++ b/drivers/gpu/drm/panthor/panthor_mmu.c
> @@ -2204,10 +2204,10 @@ panthor_vm_exec_op(struct panthor_vm *vm, struct panthor_vm_op_ctx *op,
> switch (op_type) {
> case DRM_PANTHOR_VM_BIND_OP_TYPE_MAP: {
> const struct drm_gpuvm_map_req map_req = {
> - .map.va.addr = op->va.addr,
> - .map.va.range = op->va.range,
> - .map.gem.obj = op->map.vm_bo->obj,
> - .map.gem.offset = op->map.bo_offset,
> + .op.va.addr = op->va.addr,
> + .op.va.range = op->va.range,
> + .op.gem.obj = op->map.vm_bo->obj,
> + .op.gem.offset = op->map.bo_offset,
> };
>
> if (vm->unusable) {
> diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
> index f35d69c0b4c6..66b54b152446 100644
> --- a/drivers/gpu/drm/xe/xe_vm.c
> +++ b/drivers/gpu/drm/xe/xe_vm.c
> @@ -2339,10 +2339,10 @@ vm_bind_ioctl_ops_create(struct xe_vm *vm, struct xe_vma_ops *vops,
> case DRM_XE_VM_BIND_OP_MAP:
> case DRM_XE_VM_BIND_OP_MAP_USERPTR: {
> struct drm_gpuvm_map_req map_req = {
> - .map.va.addr = addr,
> - .map.va.range = range,
> - .map.gem.obj = obj,
> - .map.gem.offset = bo_offset_or_userptr,
> + .op.va.addr = addr,
> + .op.va.range = range,
> + .op.gem.obj = obj,
> + .op.gem.offset = bo_offset_or_userptr,
> };
>
> ops = drm_gpuvm_sm_map_ops_create(&vm->gpuvm, &map_req);
> diff --git a/include/drm/drm_gpuvm.h b/include/drm/drm_gpuvm.h
> index 4a22b9d848f7..751c96a817ed 100644
> --- a/include/drm/drm_gpuvm.h
> +++ b/include/drm/drm_gpuvm.h
> @@ -1054,9 +1054,9 @@ struct drm_gpuva_ops {
> */
> struct drm_gpuvm_map_req {
> /**
> - * @op_map: struct drm_gpuva_op_map
> + * @op: struct drm_gpuva_op_map
> */
> - struct drm_gpuva_op_map map;
> + struct drm_gpuva_op_map op;
> };
>
> struct drm_gpuva_ops *
--
Matt Coster
E: matt.coster@imgtec.com
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* ✓ CI.KUnit: success for drm/gpuvm: Rename 'map' to 'op' in drm_gpuvm_map_req
2025-08-20 15:23 [PATCH] drm/gpuvm: Rename 'map' to 'op' in drm_gpuvm_map_req Himal Prasad Ghimiray
` (3 preceding siblings ...)
2025-08-20 16:56 ` Matt Coster
@ 2025-08-20 20:15 ` Patchwork
2025-08-20 21:19 ` ✓ Xe.CI.BAT: " Patchwork
2025-08-21 20:15 ` ✗ Xe.CI.Full: failure " Patchwork
6 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2025-08-20 20:15 UTC (permalink / raw)
To: Ghimiray, Himal Prasad; +Cc: intel-xe
== Series Details ==
Series: drm/gpuvm: Rename 'map' to 'op' in drm_gpuvm_map_req
URL : https://patchwork.freedesktop.org/series/153233/
State : success
== Summary ==
+ trap cleanup EXIT
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/xe/.kunitconfig
[20:14:16] Configuring KUnit Kernel ...
Generating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[20:14:20] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[20:14:49] Starting KUnit Kernel (1/1)...
[20:14:49] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[20:14:49] ================== guc_buf (11 subtests) ===================
[20:14:49] [PASSED] test_smallest
[20:14:49] [PASSED] test_largest
[20:14:49] [PASSED] test_granular
[20:14:49] [PASSED] test_unique
[20:14:49] [PASSED] test_overlap
[20:14:49] [PASSED] test_reusable
[20:14:49] [PASSED] test_too_big
[20:14:49] [PASSED] test_flush
[20:14:49] [PASSED] test_lookup
[20:14:49] [PASSED] test_data
[20:14:49] [PASSED] test_class
[20:14:49] ===================== [PASSED] guc_buf =====================
[20:14:49] =================== guc_dbm (7 subtests) ===================
[20:14:49] [PASSED] test_empty
[20:14:49] [PASSED] test_default
[20:14:49] ======================== test_size ========================
[20:14:49] [PASSED] 4
[20:14:49] [PASSED] 8
[20:14:49] [PASSED] 32
[20:14:49] [PASSED] 256
[20:14:49] ==================== [PASSED] test_size ====================
[20:14:49] ======================= test_reuse ========================
[20:14:49] [PASSED] 4
[20:14:49] [PASSED] 8
[20:14:49] [PASSED] 32
[20:14:49] [PASSED] 256
[20:14:49] =================== [PASSED] test_reuse ====================
[20:14:49] =================== test_range_overlap ====================
[20:14:49] [PASSED] 4
[20:14:49] [PASSED] 8
[20:14:49] [PASSED] 32
[20:14:49] [PASSED] 256
[20:14:49] =============== [PASSED] test_range_overlap ================
[20:14:49] =================== test_range_compact ====================
[20:14:49] [PASSED] 4
[20:14:49] [PASSED] 8
[20:14:49] [PASSED] 32
[20:14:49] [PASSED] 256
[20:14:49] =============== [PASSED] test_range_compact ================
[20:14:49] ==================== test_range_spare =====================
[20:14:49] [PASSED] 4
[20:14:49] [PASSED] 8
[20:14:49] [PASSED] 32
[20:14:49] [PASSED] 256
[20:14:49] ================ [PASSED] test_range_spare =================
[20:14:49] ===================== [PASSED] guc_dbm =====================
[20:14:49] =================== guc_idm (6 subtests) ===================
[20:14:49] [PASSED] bad_init
[20:14:49] [PASSED] no_init
[20:14:49] [PASSED] init_fini
[20:14:49] [PASSED] check_used
[20:14:49] [PASSED] check_quota
[20:14:49] [PASSED] check_all
[20:14:49] ===================== [PASSED] guc_idm =====================
[20:14:49] ================== no_relay (3 subtests) ===================
[20:14:49] [PASSED] xe_drops_guc2pf_if_not_ready
[20:14:49] [PASSED] xe_drops_guc2vf_if_not_ready
[20:14:49] [PASSED] xe_rejects_send_if_not_ready
[20:14:49] ==================== [PASSED] no_relay =====================
[20:14:49] ================== pf_relay (14 subtests) ==================
[20:14:49] [PASSED] pf_rejects_guc2pf_too_short
[20:14:49] [PASSED] pf_rejects_guc2pf_too_long
[20:14:49] [PASSED] pf_rejects_guc2pf_no_payload
[20:14:49] [PASSED] pf_fails_no_payload
[20:14:49] [PASSED] pf_fails_bad_origin
[20:14:49] [PASSED] pf_fails_bad_type
[20:14:49] [PASSED] pf_txn_reports_error
[20:14:49] [PASSED] pf_txn_sends_pf2guc
[20:14:49] [PASSED] pf_sends_pf2guc
[20:14:49] [SKIPPED] pf_loopback_nop
[20:14:49] [SKIPPED] pf_loopback_echo
[20:14:49] [SKIPPED] pf_loopback_fail
[20:14:49] [SKIPPED] pf_loopback_busy
[20:14:49] [SKIPPED] pf_loopback_retry
[20:14:49] ==================== [PASSED] pf_relay =====================
[20:14:49] ================== vf_relay (3 subtests) ===================
[20:14:49] [PASSED] vf_rejects_guc2vf_too_short
[20:14:49] [PASSED] vf_rejects_guc2vf_too_long
[20:14:49] [PASSED] vf_rejects_guc2vf_no_payload
[20:14:49] ==================== [PASSED] vf_relay =====================
[20:14:49] ===================== lmtt (1 subtest) =====================
[20:14:49] ======================== test_ops =========================
[20:14:49] [PASSED] 2-level
[20:14:49] [PASSED] multi-level
[20:14:49] ==================== [PASSED] test_ops =====================
[20:14:49] ====================== [PASSED] lmtt =======================
[20:14:49] ================= pf_service (11 subtests) =================
[20:14:49] [PASSED] pf_negotiate_any
[20:14:49] [PASSED] pf_negotiate_base_match
[20:14:49] [PASSED] pf_negotiate_base_newer
[20:14:49] [PASSED] pf_negotiate_base_next
[20:14:49] [SKIPPED] pf_negotiate_base_older
[20:14:49] [PASSED] pf_negotiate_base_prev
[20:14:49] [PASSED] pf_negotiate_latest_match
[20:14:49] [PASSED] pf_negotiate_latest_newer
[20:14:49] [PASSED] pf_negotiate_latest_next
[20:14:49] [SKIPPED] pf_negotiate_latest_older
[20:14:49] [SKIPPED] pf_negotiate_latest_prev
[20:14:49] =================== [PASSED] pf_service ====================
[20:14:49] =================== xe_mocs (2 subtests) ===================
[20:14:49] ================ xe_live_mocs_kernel_kunit ================
[20:14:49] =========== [SKIPPED] xe_live_mocs_kernel_kunit ============
[20:14:49] ================ xe_live_mocs_reset_kunit =================
[20:14:49] ============ [SKIPPED] xe_live_mocs_reset_kunit ============
[20:14:49] ==================== [SKIPPED] xe_mocs =====================
[20:14:49] ================= xe_migrate (2 subtests) ==================
[20:14:49] ================= xe_migrate_sanity_kunit =================
[20:14:49] ============ [SKIPPED] xe_migrate_sanity_kunit =============
[20:14:49] ================== xe_validate_ccs_kunit ==================
[20:14:49] ============= [SKIPPED] xe_validate_ccs_kunit ==============
[20:14:49] =================== [SKIPPED] xe_migrate ===================
[20:14:49] ================== xe_dma_buf (1 subtest) ==================
[20:14:49] ==================== xe_dma_buf_kunit =====================
[20:14:49] ================ [SKIPPED] xe_dma_buf_kunit ================
[20:14:49] =================== [SKIPPED] xe_dma_buf ===================
[20:14:49] ================= xe_bo_shrink (1 subtest) =================
[20:14:49] =================== xe_bo_shrink_kunit ====================
[20:14:49] =============== [SKIPPED] xe_bo_shrink_kunit ===============
[20:14:49] ================== [SKIPPED] xe_bo_shrink ==================
[20:14:49] ==================== xe_bo (2 subtests) ====================
[20:14:49] ================== xe_ccs_migrate_kunit ===================
[20:14:49] ============== [SKIPPED] xe_ccs_migrate_kunit ==============
[20:14:49] ==================== xe_bo_evict_kunit ====================
[20:14:49] =============== [SKIPPED] xe_bo_evict_kunit ================
[20:14:49] ===================== [SKIPPED] xe_bo ======================
[20:14:49] ==================== args (11 subtests) ====================
[20:14:49] [PASSED] count_args_test
[20:14:49] [PASSED] call_args_example
[20:14:49] [PASSED] call_args_test
[20:14:49] [PASSED] drop_first_arg_example
[20:14:49] [PASSED] drop_first_arg_test
[20:14:49] [PASSED] first_arg_example
[20:14:49] [PASSED] first_arg_test
[20:14:49] [PASSED] last_arg_example
[20:14:49] [PASSED] last_arg_test
[20:14:49] [PASSED] pick_arg_example
[20:14:49] [PASSED] sep_comma_example
[20:14:49] ====================== [PASSED] args =======================
[20:14:49] =================== xe_pci (3 subtests) ====================
[20:14:49] ==================== check_graphics_ip ====================
[20:14:49] [PASSED] 12.70 Xe_LPG
[20:14:49] [PASSED] 12.71 Xe_LPG
[20:14:49] [PASSED] 12.74 Xe_LPG+
[20:14:49] [PASSED] 20.01 Xe2_HPG
[20:14:49] [PASSED] 20.02 Xe2_HPG
[20:14:49] [PASSED] 20.04 Xe2_LPG
[20:14:49] [PASSED] 30.00 Xe3_LPG
[20:14:49] [PASSED] 30.01 Xe3_LPG
[20:14:49] [PASSED] 30.03 Xe3_LPG
[20:14:49] ================ [PASSED] check_graphics_ip ================
[20:14:49] ===================== check_media_ip ======================
[20:14:49] [PASSED] 13.00 Xe_LPM+
[20:14:49] [PASSED] 13.01 Xe2_HPM
[20:14:49] [PASSED] 20.00 Xe2_LPM
[20:14:49] [PASSED] 30.00 Xe3_LPM
[20:14:49] [PASSED] 30.02 Xe3_LPM
[20:14:49] ================= [PASSED] check_media_ip ==================
[20:14:49] ================= check_platform_gt_count =================
[20:14:49] [PASSED] 0x9A60 (TIGERLAKE)
[20:14:49] [PASSED] 0x9A68 (TIGERLAKE)
[20:14:49] [PASSED] 0x9A70 (TIGERLAKE)
[20:14:49] [PASSED] 0x9A40 (TIGERLAKE)
[20:14:49] [PASSED] 0x9A49 (TIGERLAKE)
[20:14:49] [PASSED] 0x9A59 (TIGERLAKE)
[20:14:49] [PASSED] 0x9A78 (TIGERLAKE)
[20:14:49] [PASSED] 0x9AC0 (TIGERLAKE)
[20:14:49] [PASSED] 0x9AC9 (TIGERLAKE)
[20:14:49] [PASSED] 0x9AD9 (TIGERLAKE)
[20:14:49] [PASSED] 0x9AF8 (TIGERLAKE)
[20:14:49] [PASSED] 0x4C80 (ROCKETLAKE)
[20:14:49] [PASSED] 0x4C8A (ROCKETLAKE)
[20:14:49] [PASSED] 0x4C8B (ROCKETLAKE)
[20:14:49] [PASSED] 0x4C8C (ROCKETLAKE)
[20:14:49] [PASSED] 0x4C90 (ROCKETLAKE)
[20:14:49] [PASSED] 0x4C9A (ROCKETLAKE)
[20:14:49] [PASSED] 0x4680 (ALDERLAKE_S)
[20:14:49] [PASSED] 0x4682 (ALDERLAKE_S)
[20:14:49] [PASSED] 0x4688 (ALDERLAKE_S)
[20:14:49] [PASSED] 0x468A (ALDERLAKE_S)
[20:14:49] [PASSED] 0x468B (ALDERLAKE_S)
[20:14:49] [PASSED] 0x4690 (ALDERLAKE_S)
[20:14:49] [PASSED] 0x4692 (ALDERLAKE_S)
[20:14:49] [PASSED] 0x4693 (ALDERLAKE_S)
[20:14:49] [PASSED] 0x46A0 (ALDERLAKE_P)
[20:14:49] [PASSED] 0x46A1 (ALDERLAKE_P)
[20:14:49] [PASSED] 0x46A2 (ALDERLAKE_P)
[20:14:49] [PASSED] 0x46A3 (ALDERLAKE_P)
[20:14:49] [PASSED] 0x46A6 (ALDERLAKE_P)
[20:14:49] [PASSED] 0x46A8 (ALDERLAKE_P)
[20:14:49] [PASSED] 0x46AA (ALDERLAKE_P)
[20:14:49] [PASSED] 0x462A (ALDERLAKE_P)
[20:14:49] [PASSED] 0x4626 (ALDERLAKE_P)
[20:14:49] [PASSED] 0x4628 (ALDERLAKE_P)
[20:14:49] [PASSED] 0x46B0 (ALDERLAKE_P)
[20:14:49] [PASSED] 0x46B1 (ALDERLAKE_P)
[20:14:49] [PASSED] 0x46B2 (ALDERLAKE_P)
[20:14:49] [PASSED] 0x46B3 (ALDERLAKE_P)
[20:14:49] [PASSED] 0x46C0 (ALDERLAKE_P)
[20:14:49] [PASSED] 0x46C1 (ALDERLAKE_P)
[20:14:49] [PASSED] 0x46C2 (ALDERLAKE_P)
[20:14:49] [PASSED] 0x46C3 (ALDERLAKE_P)
[20:14:49] [PASSED] 0x46D0 (ALDERLAKE_N)
[20:14:49] [PASSED] 0x46D1 (ALDERLAKE_N)
[20:14:49] [PASSED] 0x46D2 (ALDERLAKE_N)
[20:14:49] [PASSED] 0x46D3 (ALDERLAKE_N)
[20:14:49] [PASSED] 0x46D4 (ALDERLAKE_N)
[20:14:49] [PASSED] 0xA721 (ALDERLAKE_P)
[20:14:49] [PASSED] 0xA7A1 (ALDERLAKE_P)
[20:14:49] [PASSED] 0xA7A9 (ALDERLAKE_P)
[20:14:49] [PASSED] 0xA7AC (ALDERLAKE_P)
[20:14:49] [PASSED] 0xA7AD (ALDERLAKE_P)
[20:14:49] [PASSED] 0xA720 (ALDERLAKE_P)
[20:14:49] [PASSED] 0xA7A0 (ALDERLAKE_P)
[20:14:49] [PASSED] 0xA7A8 (ALDERLAKE_P)
[20:14:49] [PASSED] 0xA7AA (ALDERLAKE_P)
[20:14:49] [PASSED] 0xA7AB (ALDERLAKE_P)
[20:14:49] [PASSED] 0xA780 (ALDERLAKE_S)
[20:14:49] [PASSED] 0xA781 (ALDERLAKE_S)
[20:14:49] [PASSED] 0xA782 (ALDERLAKE_S)
[20:14:49] [PASSED] 0xA783 (ALDERLAKE_S)
[20:14:49] [PASSED] 0xA788 (ALDERLAKE_S)
[20:14:49] [PASSED] 0xA789 (ALDERLAKE_S)
[20:14:49] [PASSED] 0xA78A (ALDERLAKE_S)
[20:14:49] [PASSED] 0xA78B (ALDERLAKE_S)
[20:14:49] [PASSED] 0x4905 (DG1)
[20:14:49] [PASSED] 0x4906 (DG1)
[20:14:49] [PASSED] 0x4907 (DG1)
[20:14:49] [PASSED] 0x4908 (DG1)
[20:14:49] [PASSED] 0x4909 (DG1)
[20:14:49] [PASSED] 0x56C0 (DG2)
[20:14:49] [PASSED] 0x56C2 (DG2)
[20:14:49] [PASSED] 0x56C1 (DG2)
[20:14:49] [PASSED] 0x7D51 (METEORLAKE)
[20:14:49] [PASSED] 0x7DD1 (METEORLAKE)
[20:14:49] [PASSED] 0x7D41 (METEORLAKE)
[20:14:49] [PASSED] 0x7D67 (METEORLAKE)
[20:14:49] [PASSED] 0xB640 (METEORLAKE)
[20:14:49] [PASSED] 0x56A0 (DG2)
[20:14:49] [PASSED] 0x56A1 (DG2)
[20:14:49] [PASSED] 0x56A2 (DG2)
[20:14:49] [PASSED] 0x56BE (DG2)
[20:14:49] [PASSED] 0x56BF (DG2)
[20:14:49] [PASSED] 0x5690 (DG2)
[20:14:49] [PASSED] 0x5691 (DG2)
[20:14:49] [PASSED] 0x5692 (DG2)
[20:14:49] [PASSED] 0x56A5 (DG2)
[20:14:49] [PASSED] 0x56A6 (DG2)
[20:14:49] [PASSED] 0x56B0 (DG2)
[20:14:49] [PASSED] 0x56B1 (DG2)
[20:14:49] [PASSED] 0x56BA (DG2)
[20:14:49] [PASSED] 0x56BB (DG2)
[20:14:49] [PASSED] 0x56BC (DG2)
[20:14:49] [PASSED] 0x56BD (DG2)
[20:14:49] [PASSED] 0x5693 (DG2)
[20:14:49] [PASSED] 0x5694 (DG2)
[20:14:49] [PASSED] 0x5695 (DG2)
[20:14:49] [PASSED] 0x56A3 (DG2)
[20:14:49] [PASSED] 0x56A4 (DG2)
[20:14:49] [PASSED] 0x56B2 (DG2)
[20:14:49] [PASSED] 0x56B3 (DG2)
[20:14:49] [PASSED] 0x5696 (DG2)
[20:14:49] [PASSED] 0x5697 (DG2)
[20:14:49] [PASSED] 0xB69 (PVC)
[20:14:49] [PASSED] 0xB6E (PVC)
[20:14:49] [PASSED] 0xBD4 (PVC)
[20:14:49] [PASSED] 0xBD5 (PVC)
[20:14:49] [PASSED] 0xBD6 (PVC)
[20:14:49] [PASSED] 0xBD7 (PVC)
[20:14:49] [PASSED] 0xBD8 (PVC)
[20:14:49] [PASSED] 0xBD9 (PVC)
[20:14:49] [PASSED] 0xBDA (PVC)
[20:14:49] [PASSED] 0xBDB (PVC)
[20:14:49] [PASSED] 0xBE0 (PVC)
[20:14:49] [PASSED] 0xBE1 (PVC)
[20:14:49] [PASSED] 0xBE5 (PVC)
[20:14:49] [PASSED] 0x7D40 (METEORLAKE)
[20:14:49] [PASSED] 0x7D45 (METEORLAKE)
[20:14:49] [PASSED] 0x7D55 (METEORLAKE)
[20:14:49] [PASSED] 0x7D60 (METEORLAKE)
[20:14:49] [PASSED] 0x7DD5 (METEORLAKE)
[20:14:49] [PASSED] 0x6420 (LUNARLAKE)
[20:14:49] [PASSED] 0x64A0 (LUNARLAKE)
[20:14:49] [PASSED] 0x64B0 (LUNARLAKE)
[20:14:49] [PASSED] 0xE202 (BATTLEMAGE)
[20:14:49] [PASSED] 0xE209 (BATTLEMAGE)
[20:14:49] [PASSED] 0xE20B (BATTLEMAGE)
[20:14:49] [PASSED] 0xE20C (BATTLEMAGE)
[20:14:49] [PASSED] 0xE20D (BATTLEMAGE)
[20:14:49] [PASSED] 0xE210 (BATTLEMAGE)
[20:14:49] [PASSED] 0xE211 (BATTLEMAGE)
[20:14:49] [PASSED] 0xE212 (BATTLEMAGE)
[20:14:49] [PASSED] 0xE216 (BATTLEMAGE)
[20:14:49] [PASSED] 0xE220 (BATTLEMAGE)
[20:14:49] [PASSED] 0xE221 (BATTLEMAGE)
[20:14:49] [PASSED] 0xE222 (BATTLEMAGE)
[20:14:49] [PASSED] 0xE223 (BATTLEMAGE)
[20:14:49] [PASSED] 0xB080 (PANTHERLAKE)
[20:14:49] [PASSED] 0xB081 (PANTHERLAKE)
[20:14:49] [PASSED] 0xB082 (PANTHERLAKE)
[20:14:49] [PASSED] 0xB083 (PANTHERLAKE)
[20:14:49] [PASSED] 0xB084 (PANTHERLAKE)
[20:14:49] [PASSED] 0xB085 (PANTHERLAKE)
[20:14:49] [PASSED] 0xB086 (PANTHERLAKE)
[20:14:49] [PASSED] 0xB087 (PANTHERLAKE)
[20:14:49] [PASSED] 0xB08F (PANTHERLAKE)
[20:14:49] [PASSED] 0xB090 (PANTHERLAKE)
[20:14:49] [PASSED] 0xB0A0 (PANTHERLAKE)
[20:14:49] [PASSED] 0xB0B0 (PANTHERLAKE)
[20:14:49] [PASSED] 0xFD80 (PANTHERLAKE)
[20:14:49] [PASSED] 0xFD81 (PANTHERLAKE)
[20:14:49] ============= [PASSED] check_platform_gt_count =============
[20:14:49] ===================== [PASSED] xe_pci ======================
[20:14:49] =================== xe_rtp (2 subtests) ====================
[20:14:49] =============== xe_rtp_process_to_sr_tests ================
[20:14:49] [PASSED] coalesce-same-reg
[20:14:49] [PASSED] no-match-no-add
[20:14:49] [PASSED] match-or
[20:14:49] [PASSED] match-or-xfail
[20:14:49] [PASSED] no-match-no-add-multiple-rules
[20:14:49] [PASSED] two-regs-two-entries
[20:14:49] [PASSED] clr-one-set-other
[20:14:49] [PASSED] set-field
[20:14:49] [PASSED] conflict-duplicate
[20:14:49] [PASSED] conflict-not-disjoint
[20:14:49] [PASSED] conflict-reg-type
[20:14:49] =========== [PASSED] xe_rtp_process_to_sr_tests ============
[20:14:49] ================== xe_rtp_process_tests ===================
[20:14:49] [PASSED] active1
[20:14:49] [PASSED] active2
[20:14:49] [PASSED] active-inactive
[20:14:49] [PASSED] inactive-active
[20:14:49] [PASSED] inactive-1st_or_active-inactive
[20:14:49] [PASSED] inactive-2nd_or_active-inactive
[20:14:49] [PASSED] inactive-last_or_active-inactive
[20:14:49] [PASSED] inactive-no_or_active-inactive
[20:14:49] ============== [PASSED] xe_rtp_process_tests ===============
[20:14:49] ===================== [PASSED] xe_rtp ======================
[20:14:49] ==================== xe_wa (1 subtest) =====================
[20:14:49] ======================== xe_wa_gt =========================
[20:14:49] [PASSED] TIGERLAKE (B0)
[20:14:49] [PASSED] DG1 (A0)
[20:14:49] [PASSED] DG1 (B0)
[20:14:49] [PASSED] ALDERLAKE_S (A0)
[20:14:49] [PASSED] ALDERLAKE_S (B0)
[20:14:49] [PASSED] ALDERLAKE_S (C0)
[20:14:49] [PASSED] ALDERLAKE_S (D0)
[20:14:49] [PASSED] ALDERLAKE_P (A0)
[20:14:49] [PASSED] ALDERLAKE_P (B0)
[20:14:49] [PASSED] ALDERLAKE_P (C0)
[20:14:49] [PASSED] ALDERLAKE_S_RPLS (D0)
[20:14:49] [PASSED] ALDERLAKE_P_RPLU (E0)
[20:14:49] [PASSED] DG2_G10 (C0)
[20:14:49] [PASSED] DG2_G11 (B1)
[20:14:49] [PASSED] DG2_G12 (A1)
[20:14:49] [PASSED] METEORLAKE (g:A0, m:A0)
[20:14:49] [PASSED] METEORLAKE (g:A0, m:A0)
[20:14:49] [PASSED] METEORLAKE (g:A0, m:A0)
[20:14:49] [PASSED] LUNARLAKE (g:A0, m:A0)
[20:14:49] [PASSED] LUNARLAKE (g:B0, m:A0)
stty: 'standard input': Inappropriate ioctl for device
[20:14:49] [PASSED] BATTLEMAGE (g:A0, m:A1)
[20:14:49] ==================== [PASSED] xe_wa_gt =====================
[20:14:49] ====================== [PASSED] xe_wa ======================
[20:14:49] ============================================================
[20:14:49] Testing complete. Ran 297 tests: passed: 281, skipped: 16
[20:14:49] Elapsed time: 33.054s total, 4.221s configuring, 28.516s building, 0.272s running
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/tests/.kunitconfig
[20:14:49] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[20:14:51] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[20:15:13] Starting KUnit Kernel (1/1)...
[20:15:13] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[20:15:13] == drm_test_atomic_get_connector_for_encoder (1 subtest) ===
[20:15:13] [PASSED] drm_test_drm_atomic_get_connector_for_encoder
[20:15:13] ==== [PASSED] drm_test_atomic_get_connector_for_encoder ====
[20:15:13] =========== drm_validate_clone_mode (2 subtests) ===========
[20:15:13] ============== drm_test_check_in_clone_mode ===============
[20:15:13] [PASSED] in_clone_mode
[20:15:13] [PASSED] not_in_clone_mode
[20:15:13] ========== [PASSED] drm_test_check_in_clone_mode ===========
[20:15:13] =============== drm_test_check_valid_clones ===============
[20:15:13] [PASSED] not_in_clone_mode
[20:15:13] [PASSED] valid_clone
[20:15:13] [PASSED] invalid_clone
[20:15:13] =========== [PASSED] drm_test_check_valid_clones ===========
[20:15:13] ============= [PASSED] drm_validate_clone_mode =============
[20:15:13] ============= drm_validate_modeset (1 subtest) =============
[20:15:13] [PASSED] drm_test_check_connector_changed_modeset
[20:15:13] ============== [PASSED] drm_validate_modeset ===============
[20:15:13] ====== drm_test_bridge_get_current_state (2 subtests) ======
[20:15:13] [PASSED] drm_test_drm_bridge_get_current_state_atomic
[20:15:13] [PASSED] drm_test_drm_bridge_get_current_state_legacy
[20:15:13] ======== [PASSED] drm_test_bridge_get_current_state ========
[20:15:13] ====== drm_test_bridge_helper_reset_crtc (3 subtests) ======
[20:15:13] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic
[20:15:13] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic_disabled
[20:15:13] [PASSED] drm_test_drm_bridge_helper_reset_crtc_legacy
[20:15:13] ======== [PASSED] drm_test_bridge_helper_reset_crtc ========
[20:15:13] ============== drm_bridge_alloc (2 subtests) ===============
[20:15:13] [PASSED] drm_test_drm_bridge_alloc_basic
[20:15:13] [PASSED] drm_test_drm_bridge_alloc_get_put
[20:15:13] ================ [PASSED] drm_bridge_alloc =================
[20:15:13] ================== drm_buddy (7 subtests) ==================
[20:15:13] [PASSED] drm_test_buddy_alloc_limit
[20:15:13] [PASSED] drm_test_buddy_alloc_optimistic
[20:15:13] [PASSED] drm_test_buddy_alloc_pessimistic
[20:15:13] [PASSED] drm_test_buddy_alloc_pathological
[20:15:14] [PASSED] drm_test_buddy_alloc_contiguous
[20:15:14] [PASSED] drm_test_buddy_alloc_clear
[20:15:14] [PASSED] drm_test_buddy_alloc_range_bias
[20:15:14] ==================== [PASSED] drm_buddy ====================
[20:15:14] ============= drm_cmdline_parser (40 subtests) =============
[20:15:14] [PASSED] drm_test_cmdline_force_d_only
[20:15:14] [PASSED] drm_test_cmdline_force_D_only_dvi
[20:15:14] [PASSED] drm_test_cmdline_force_D_only_hdmi
[20:15:14] [PASSED] drm_test_cmdline_force_D_only_not_digital
[20:15:14] [PASSED] drm_test_cmdline_force_e_only
[20:15:14] [PASSED] drm_test_cmdline_res
[20:15:14] [PASSED] drm_test_cmdline_res_vesa
[20:15:14] [PASSED] drm_test_cmdline_res_vesa_rblank
[20:15:14] [PASSED] drm_test_cmdline_res_rblank
[20:15:14] [PASSED] drm_test_cmdline_res_bpp
[20:15:14] [PASSED] drm_test_cmdline_res_refresh
[20:15:14] [PASSED] drm_test_cmdline_res_bpp_refresh
[20:15:14] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced
[20:15:14] [PASSED] drm_test_cmdline_res_bpp_refresh_margins
[20:15:14] [PASSED] drm_test_cmdline_res_bpp_refresh_force_off
[20:15:14] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on
[20:15:14] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_analog
[20:15:14] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_digital
[20:15:14] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced_margins_force_on
[20:15:14] [PASSED] drm_test_cmdline_res_margins_force_on
[20:15:14] [PASSED] drm_test_cmdline_res_vesa_margins
[20:15:14] [PASSED] drm_test_cmdline_name
[20:15:14] [PASSED] drm_test_cmdline_name_bpp
[20:15:14] [PASSED] drm_test_cmdline_name_option
[20:15:14] [PASSED] drm_test_cmdline_name_bpp_option
[20:15:14] [PASSED] drm_test_cmdline_rotate_0
[20:15:14] [PASSED] drm_test_cmdline_rotate_90
[20:15:14] [PASSED] drm_test_cmdline_rotate_180
[20:15:14] [PASSED] drm_test_cmdline_rotate_270
[20:15:14] [PASSED] drm_test_cmdline_hmirror
[20:15:14] [PASSED] drm_test_cmdline_vmirror
[20:15:14] [PASSED] drm_test_cmdline_margin_options
[20:15:14] [PASSED] drm_test_cmdline_multiple_options
[20:15:14] [PASSED] drm_test_cmdline_bpp_extra_and_option
[20:15:14] [PASSED] drm_test_cmdline_extra_and_option
[20:15:14] [PASSED] drm_test_cmdline_freestanding_options
[20:15:14] [PASSED] drm_test_cmdline_freestanding_force_e_and_options
[20:15:14] [PASSED] drm_test_cmdline_panel_orientation
[20:15:14] ================ drm_test_cmdline_invalid =================
[20:15:14] [PASSED] margin_only
[20:15:14] [PASSED] interlace_only
[20:15:14] [PASSED] res_missing_x
[20:15:14] [PASSED] res_missing_y
[20:15:14] [PASSED] res_bad_y
[20:15:14] [PASSED] res_missing_y_bpp
[20:15:14] [PASSED] res_bad_bpp
[20:15:14] [PASSED] res_bad_refresh
[20:15:14] [PASSED] res_bpp_refresh_force_on_off
[20:15:14] [PASSED] res_invalid_mode
[20:15:14] [PASSED] res_bpp_wrong_place_mode
[20:15:14] [PASSED] name_bpp_refresh
[20:15:14] [PASSED] name_refresh
[20:15:14] [PASSED] name_refresh_wrong_mode
[20:15:14] [PASSED] name_refresh_invalid_mode
[20:15:14] [PASSED] rotate_multiple
[20:15:14] [PASSED] rotate_invalid_val
[20:15:14] [PASSED] rotate_truncated
[20:15:14] [PASSED] invalid_option
[20:15:14] [PASSED] invalid_tv_option
[20:15:14] [PASSED] truncated_tv_option
[20:15:14] ============ [PASSED] drm_test_cmdline_invalid =============
[20:15:14] =============== drm_test_cmdline_tv_options ===============
[20:15:14] [PASSED] NTSC
[20:15:14] [PASSED] NTSC_443
[20:15:14] [PASSED] NTSC_J
[20:15:14] [PASSED] PAL
[20:15:14] [PASSED] PAL_M
[20:15:14] [PASSED] PAL_N
[20:15:14] [PASSED] SECAM
[20:15:14] [PASSED] MONO_525
[20:15:14] [PASSED] MONO_625
[20:15:14] =========== [PASSED] drm_test_cmdline_tv_options ===========
[20:15:14] =============== [PASSED] drm_cmdline_parser ================
[20:15:14] ========== drmm_connector_hdmi_init (20 subtests) ==========
[20:15:14] [PASSED] drm_test_connector_hdmi_init_valid
[20:15:14] [PASSED] drm_test_connector_hdmi_init_bpc_8
[20:15:14] [PASSED] drm_test_connector_hdmi_init_bpc_10
[20:15:14] [PASSED] drm_test_connector_hdmi_init_bpc_12
[20:15:14] [PASSED] drm_test_connector_hdmi_init_bpc_invalid
[20:15:14] [PASSED] drm_test_connector_hdmi_init_bpc_null
[20:15:14] [PASSED] drm_test_connector_hdmi_init_formats_empty
[20:15:14] [PASSED] drm_test_connector_hdmi_init_formats_no_rgb
[20:15:14] === drm_test_connector_hdmi_init_formats_yuv420_allowed ===
[20:15:14] [PASSED] supported_formats=0x9 yuv420_allowed=1
[20:15:14] [PASSED] supported_formats=0x9 yuv420_allowed=0
[20:15:14] [PASSED] supported_formats=0x3 yuv420_allowed=1
[20:15:14] [PASSED] supported_formats=0x3 yuv420_allowed=0
[20:15:14] === [PASSED] drm_test_connector_hdmi_init_formats_yuv420_allowed ===
[20:15:14] [PASSED] drm_test_connector_hdmi_init_null_ddc
[20:15:14] [PASSED] drm_test_connector_hdmi_init_null_product
[20:15:14] [PASSED] drm_test_connector_hdmi_init_null_vendor
[20:15:14] [PASSED] drm_test_connector_hdmi_init_product_length_exact
[20:15:14] [PASSED] drm_test_connector_hdmi_init_product_length_too_long
[20:15:14] [PASSED] drm_test_connector_hdmi_init_product_valid
[20:15:14] [PASSED] drm_test_connector_hdmi_init_vendor_length_exact
[20:15:14] [PASSED] drm_test_connector_hdmi_init_vendor_length_too_long
[20:15:14] [PASSED] drm_test_connector_hdmi_init_vendor_valid
[20:15:14] ========= drm_test_connector_hdmi_init_type_valid =========
[20:15:14] [PASSED] HDMI-A
[20:15:14] [PASSED] HDMI-B
[20:15:14] ===== [PASSED] drm_test_connector_hdmi_init_type_valid =====
[20:15:14] ======== drm_test_connector_hdmi_init_type_invalid ========
[20:15:14] [PASSED] Unknown
[20:15:14] [PASSED] VGA
[20:15:14] [PASSED] DVI-I
[20:15:14] [PASSED] DVI-D
[20:15:14] [PASSED] DVI-A
[20:15:14] [PASSED] Composite
[20:15:14] [PASSED] SVIDEO
[20:15:14] [PASSED] LVDS
[20:15:14] [PASSED] Component
[20:15:14] [PASSED] DIN
[20:15:14] [PASSED] DP
[20:15:14] [PASSED] TV
[20:15:14] [PASSED] eDP
[20:15:14] [PASSED] Virtual
[20:15:14] [PASSED] DSI
[20:15:14] [PASSED] DPI
[20:15:14] [PASSED] Writeback
[20:15:14] [PASSED] SPI
[20:15:14] [PASSED] USB
[20:15:14] ==== [PASSED] drm_test_connector_hdmi_init_type_invalid ====
[20:15:14] ============ [PASSED] drmm_connector_hdmi_init =============
[20:15:14] ============= drmm_connector_init (3 subtests) =============
[20:15:14] [PASSED] drm_test_drmm_connector_init
[20:15:14] [PASSED] drm_test_drmm_connector_init_null_ddc
[20:15:14] ========= drm_test_drmm_connector_init_type_valid =========
[20:15:14] [PASSED] Unknown
[20:15:14] [PASSED] VGA
[20:15:14] [PASSED] DVI-I
[20:15:14] [PASSED] DVI-D
[20:15:14] [PASSED] DVI-A
[20:15:14] [PASSED] Composite
[20:15:14] [PASSED] SVIDEO
[20:15:14] [PASSED] LVDS
[20:15:14] [PASSED] Component
[20:15:14] [PASSED] DIN
[20:15:14] [PASSED] DP
[20:15:14] [PASSED] HDMI-A
[20:15:14] [PASSED] HDMI-B
[20:15:14] [PASSED] TV
[20:15:14] [PASSED] eDP
[20:15:14] [PASSED] Virtual
[20:15:14] [PASSED] DSI
[20:15:14] [PASSED] DPI
[20:15:14] [PASSED] Writeback
[20:15:14] [PASSED] SPI
[20:15:14] [PASSED] USB
[20:15:14] ===== [PASSED] drm_test_drmm_connector_init_type_valid =====
[20:15:14] =============== [PASSED] drmm_connector_init ===============
[20:15:14] ========= drm_connector_dynamic_init (6 subtests) ==========
[20:15:14] [PASSED] drm_test_drm_connector_dynamic_init
[20:15:14] [PASSED] drm_test_drm_connector_dynamic_init_null_ddc
[20:15:14] [PASSED] drm_test_drm_connector_dynamic_init_not_added
[20:15:14] [PASSED] drm_test_drm_connector_dynamic_init_properties
[20:15:14] ===== drm_test_drm_connector_dynamic_init_type_valid ======
[20:15:14] [PASSED] Unknown
[20:15:14] [PASSED] VGA
[20:15:14] [PASSED] DVI-I
[20:15:14] [PASSED] DVI-D
[20:15:14] [PASSED] DVI-A
[20:15:14] [PASSED] Composite
[20:15:14] [PASSED] SVIDEO
[20:15:14] [PASSED] LVDS
[20:15:14] [PASSED] Component
[20:15:14] [PASSED] DIN
[20:15:14] [PASSED] DP
[20:15:14] [PASSED] HDMI-A
[20:15:14] [PASSED] HDMI-B
[20:15:14] [PASSED] TV
[20:15:14] [PASSED] eDP
[20:15:14] [PASSED] Virtual
[20:15:14] [PASSED] DSI
[20:15:14] [PASSED] DPI
[20:15:14] [PASSED] Writeback
[20:15:14] [PASSED] SPI
[20:15:14] [PASSED] USB
[20:15:14] = [PASSED] drm_test_drm_connector_dynamic_init_type_valid ==
[20:15:14] ======== drm_test_drm_connector_dynamic_init_name =========
[20:15:14] [PASSED] Unknown
[20:15:14] [PASSED] VGA
[20:15:14] [PASSED] DVI-I
[20:15:14] [PASSED] DVI-D
[20:15:14] [PASSED] DVI-A
[20:15:14] [PASSED] Composite
[20:15:14] [PASSED] SVIDEO
[20:15:14] [PASSED] LVDS
[20:15:14] [PASSED] Component
[20:15:14] [PASSED] DIN
[20:15:14] [PASSED] DP
[20:15:14] [PASSED] HDMI-A
[20:15:14] [PASSED] HDMI-B
[20:15:14] [PASSED] TV
[20:15:14] [PASSED] eDP
[20:15:14] [PASSED] Virtual
[20:15:14] [PASSED] DSI
[20:15:14] [PASSED] DPI
[20:15:14] [PASSED] Writeback
[20:15:14] [PASSED] SPI
[20:15:14] [PASSED] USB
[20:15:14] ==== [PASSED] drm_test_drm_connector_dynamic_init_name =====
[20:15:14] =========== [PASSED] drm_connector_dynamic_init ============
[20:15:14] ==== drm_connector_dynamic_register_early (4 subtests) =====
[20:15:14] [PASSED] drm_test_drm_connector_dynamic_register_early_on_list
[20:15:14] [PASSED] drm_test_drm_connector_dynamic_register_early_defer
[20:15:14] [PASSED] drm_test_drm_connector_dynamic_register_early_no_init
[20:15:14] [PASSED] drm_test_drm_connector_dynamic_register_early_no_mode_object
[20:15:14] ====== [PASSED] drm_connector_dynamic_register_early =======
[20:15:14] ======= drm_connector_dynamic_register (7 subtests) ========
[20:15:14] [PASSED] drm_test_drm_connector_dynamic_register_on_list
[20:15:14] [PASSED] drm_test_drm_connector_dynamic_register_no_defer
[20:15:14] [PASSED] drm_test_drm_connector_dynamic_register_no_init
[20:15:14] [PASSED] drm_test_drm_connector_dynamic_register_mode_object
[20:15:14] [PASSED] drm_test_drm_connector_dynamic_register_sysfs
[20:15:14] [PASSED] drm_test_drm_connector_dynamic_register_sysfs_name
[20:15:14] [PASSED] drm_test_drm_connector_dynamic_register_debugfs
[20:15:14] ========= [PASSED] drm_connector_dynamic_register ==========
[20:15:14] = drm_connector_attach_broadcast_rgb_property (2 subtests) =
[20:15:14] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property
[20:15:14] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property_hdmi_connector
[20:15:14] === [PASSED] drm_connector_attach_broadcast_rgb_property ===
[20:15:14] ========== drm_get_tv_mode_from_name (2 subtests) ==========
[20:15:14] ========== drm_test_get_tv_mode_from_name_valid ===========
[20:15:14] [PASSED] NTSC
[20:15:14] [PASSED] NTSC-443
[20:15:14] [PASSED] NTSC-J
[20:15:14] [PASSED] PAL
[20:15:14] [PASSED] PAL-M
[20:15:14] [PASSED] PAL-N
[20:15:14] [PASSED] SECAM
[20:15:14] [PASSED] Mono
[20:15:14] ====== [PASSED] drm_test_get_tv_mode_from_name_valid =======
[20:15:14] [PASSED] drm_test_get_tv_mode_from_name_truncated
[20:15:14] ============ [PASSED] drm_get_tv_mode_from_name ============
[20:15:14] = drm_test_connector_hdmi_compute_mode_clock (12 subtests) =
[20:15:14] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb
[20:15:14] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc
[20:15:14] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc_vic_1
[20:15:14] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc
[20:15:14] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc_vic_1
[20:15:14] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_double
[20:15:14] = drm_test_connector_hdmi_compute_mode_clock_yuv420_valid =
[20:15:14] [PASSED] VIC 96
[20:15:14] [PASSED] VIC 97
[20:15:14] [PASSED] VIC 101
[20:15:14] [PASSED] VIC 102
[20:15:14] [PASSED] VIC 106
[20:15:14] [PASSED] VIC 107
[20:15:14] === [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_valid ===
[20:15:14] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_10_bpc
[20:15:14] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_12_bpc
[20:15:14] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_8_bpc
[20:15:14] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_10_bpc
[20:15:14] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_12_bpc
[20:15:14] === [PASSED] drm_test_connector_hdmi_compute_mode_clock ====
[20:15:14] == drm_hdmi_connector_get_broadcast_rgb_name (2 subtests) ==
[20:15:14] === drm_test_drm_hdmi_connector_get_broadcast_rgb_name ====
[20:15:14] [PASSED] Automatic
[20:15:14] [PASSED] Full
[20:15:14] [PASSED] Limited 16:235
[20:15:14] === [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name ===
[20:15:14] [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name_invalid
[20:15:14] ==== [PASSED] drm_hdmi_connector_get_broadcast_rgb_name ====
[20:15:14] == drm_hdmi_connector_get_output_format_name (2 subtests) ==
[20:15:14] === drm_test_drm_hdmi_connector_get_output_format_name ====
[20:15:14] [PASSED] RGB
[20:15:14] [PASSED] YUV 4:2:0
[20:15:14] [PASSED] YUV 4:2:2
[20:15:14] [PASSED] YUV 4:4:4
[20:15:14] === [PASSED] drm_test_drm_hdmi_connector_get_output_format_name ===
[20:15:14] [PASSED] drm_test_drm_hdmi_connector_get_output_format_name_invalid
[20:15:14] ==== [PASSED] drm_hdmi_connector_get_output_format_name ====
[20:15:14] ============= drm_damage_helper (21 subtests) ==============
[20:15:14] [PASSED] drm_test_damage_iter_no_damage
[20:15:14] [PASSED] drm_test_damage_iter_no_damage_fractional_src
[20:15:14] [PASSED] drm_test_damage_iter_no_damage_src_moved
[20:15:14] [PASSED] drm_test_damage_iter_no_damage_fractional_src_moved
[20:15:14] [PASSED] drm_test_damage_iter_no_damage_not_visible
[20:15:14] [PASSED] drm_test_damage_iter_no_damage_no_crtc
[20:15:14] [PASSED] drm_test_damage_iter_no_damage_no_fb
[20:15:14] [PASSED] drm_test_damage_iter_simple_damage
[20:15:14] [PASSED] drm_test_damage_iter_single_damage
[20:15:14] [PASSED] drm_test_damage_iter_single_damage_intersect_src
[20:15:14] [PASSED] drm_test_damage_iter_single_damage_outside_src
[20:15:14] [PASSED] drm_test_damage_iter_single_damage_fractional_src
[20:15:14] [PASSED] drm_test_damage_iter_single_damage_intersect_fractional_src
[20:15:14] [PASSED] drm_test_damage_iter_single_damage_outside_fractional_src
[20:15:14] [PASSED] drm_test_damage_iter_single_damage_src_moved
[20:15:14] [PASSED] drm_test_damage_iter_single_damage_fractional_src_moved
[20:15:14] [PASSED] drm_test_damage_iter_damage
[20:15:14] [PASSED] drm_test_damage_iter_damage_one_intersect
[20:15:14] [PASSED] drm_test_damage_iter_damage_one_outside
[20:15:14] [PASSED] drm_test_damage_iter_damage_src_moved
[20:15:14] [PASSED] drm_test_damage_iter_damage_not_visible
[20:15:14] ================ [PASSED] drm_damage_helper ================
[20:15:14] ============== drm_dp_mst_helper (3 subtests) ==============
[20:15:14] ============== drm_test_dp_mst_calc_pbn_mode ==============
[20:15:14] [PASSED] Clock 154000 BPP 30 DSC disabled
[20:15:14] [PASSED] Clock 234000 BPP 30 DSC disabled
[20:15:14] [PASSED] Clock 297000 BPP 24 DSC disabled
[20:15:14] [PASSED] Clock 332880 BPP 24 DSC enabled
[20:15:14] [PASSED] Clock 324540 BPP 24 DSC enabled
[20:15:14] ========== [PASSED] drm_test_dp_mst_calc_pbn_mode ==========
[20:15:14] ============== drm_test_dp_mst_calc_pbn_div ===============
[20:15:14] [PASSED] Link rate 2000000 lane count 4
[20:15:14] [PASSED] Link rate 2000000 lane count 2
[20:15:14] [PASSED] Link rate 2000000 lane count 1
[20:15:14] [PASSED] Link rate 1350000 lane count 4
[20:15:14] [PASSED] Link rate 1350000 lane count 2
[20:15:14] [PASSED] Link rate 1350000 lane count 1
[20:15:14] [PASSED] Link rate 1000000 lane count 4
[20:15:14] [PASSED] Link rate 1000000 lane count 2
[20:15:14] [PASSED] Link rate 1000000 lane count 1
[20:15:14] [PASSED] Link rate 810000 lane count 4
[20:15:14] [PASSED] Link rate 810000 lane count 2
[20:15:14] [PASSED] Link rate 810000 lane count 1
[20:15:14] [PASSED] Link rate 540000 lane count 4
[20:15:14] [PASSED] Link rate 540000 lane count 2
[20:15:14] [PASSED] Link rate 540000 lane count 1
[20:15:14] [PASSED] Link rate 270000 lane count 4
[20:15:14] [PASSED] Link rate 270000 lane count 2
[20:15:14] [PASSED] Link rate 270000 lane count 1
[20:15:14] [PASSED] Link rate 162000 lane count 4
[20:15:14] [PASSED] Link rate 162000 lane count 2
[20:15:14] [PASSED] Link rate 162000 lane count 1
[20:15:14] ========== [PASSED] drm_test_dp_mst_calc_pbn_div ===========
[20:15:14] ========= drm_test_dp_mst_sideband_msg_req_decode =========
[20:15:14] [PASSED] DP_ENUM_PATH_RESOURCES with port number
[20:15:14] [PASSED] DP_POWER_UP_PHY with port number
[20:15:14] [PASSED] DP_POWER_DOWN_PHY with port number
[20:15:14] [PASSED] DP_ALLOCATE_PAYLOAD with SDP stream sinks
[20:15:14] [PASSED] DP_ALLOCATE_PAYLOAD with port number
[20:15:14] [PASSED] DP_ALLOCATE_PAYLOAD with VCPI
[20:15:14] [PASSED] DP_ALLOCATE_PAYLOAD with PBN
[20:15:14] [PASSED] DP_QUERY_PAYLOAD with port number
[20:15:14] [PASSED] DP_QUERY_PAYLOAD with VCPI
[20:15:14] [PASSED] DP_REMOTE_DPCD_READ with port number
[20:15:14] [PASSED] DP_REMOTE_DPCD_READ with DPCD address
[20:15:14] [PASSED] DP_REMOTE_DPCD_READ with max number of bytes
[20:15:14] [PASSED] DP_REMOTE_DPCD_WRITE with port number
[20:15:14] [PASSED] DP_REMOTE_DPCD_WRITE with DPCD address
[20:15:14] [PASSED] DP_REMOTE_DPCD_WRITE with data array
[20:15:14] [PASSED] DP_REMOTE_I2C_READ with port number
[20:15:14] [PASSED] DP_REMOTE_I2C_READ with I2C device ID
[20:15:14] [PASSED] DP_REMOTE_I2C_READ with transactions array
[20:15:14] [PASSED] DP_REMOTE_I2C_WRITE with port number
[20:15:14] [PASSED] DP_REMOTE_I2C_WRITE with I2C device ID
[20:15:14] [PASSED] DP_REMOTE_I2C_WRITE with data array
[20:15:14] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream ID
[20:15:14] [PASSED] DP_QUERY_STREAM_ENC_STATUS with client ID
[20:15:14] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream event
[20:15:14] [PASSED] DP_QUERY_STREAM_ENC_STATUS with valid stream event
[20:15:14] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream behavior
[20:15:14] [PASSED] DP_QUERY_STREAM_ENC_STATUS with a valid stream behavior
[20:15:14] ===== [PASSED] drm_test_dp_mst_sideband_msg_req_decode =====
[20:15:14] ================ [PASSED] drm_dp_mst_helper ================
[20:15:14] ================== drm_exec (7 subtests) ===================
[20:15:14] [PASSED] sanitycheck
[20:15:14] [PASSED] test_lock
[20:15:14] [PASSED] test_lock_unlock
[20:15:14] [PASSED] test_duplicates
[20:15:14] [PASSED] test_prepare
[20:15:14] [PASSED] test_prepare_array
[20:15:14] [PASSED] test_multiple_loops
[20:15:14] ==================== [PASSED] drm_exec =====================
[20:15:14] =========== drm_format_helper_test (17 subtests) ===========
[20:15:14] ============== drm_test_fb_xrgb8888_to_gray8 ==============
[20:15:14] [PASSED] single_pixel_source_buffer
[20:15:14] [PASSED] single_pixel_clip_rectangle
[20:15:14] [PASSED] well_known_colors
[20:15:14] [PASSED] destination_pitch
[20:15:14] ========== [PASSED] drm_test_fb_xrgb8888_to_gray8 ==========
[20:15:14] ============= drm_test_fb_xrgb8888_to_rgb332 ==============
[20:15:14] [PASSED] single_pixel_source_buffer
[20:15:14] [PASSED] single_pixel_clip_rectangle
[20:15:14] [PASSED] well_known_colors
[20:15:14] [PASSED] destination_pitch
[20:15:14] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb332 ==========
[20:15:14] ============= drm_test_fb_xrgb8888_to_rgb565 ==============
[20:15:14] [PASSED] single_pixel_source_buffer
[20:15:14] [PASSED] single_pixel_clip_rectangle
[20:15:14] [PASSED] well_known_colors
[20:15:14] [PASSED] destination_pitch
[20:15:14] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb565 ==========
[20:15:14] ============ drm_test_fb_xrgb8888_to_xrgb1555 =============
[20:15:14] [PASSED] single_pixel_source_buffer
[20:15:14] [PASSED] single_pixel_clip_rectangle
[20:15:14] [PASSED] well_known_colors
[20:15:14] [PASSED] destination_pitch
[20:15:14] ======== [PASSED] drm_test_fb_xrgb8888_to_xrgb1555 =========
[20:15:14] ============ drm_test_fb_xrgb8888_to_argb1555 =============
[20:15:14] [PASSED] single_pixel_source_buffer
[20:15:14] [PASSED] single_pixel_clip_rectangle
[20:15:14] [PASSED] well_known_colors
[20:15:14] [PASSED] destination_pitch
[20:15:14] ======== [PASSED] drm_test_fb_xrgb8888_to_argb1555 =========
[20:15:14] ============ drm_test_fb_xrgb8888_to_rgba5551 =============
[20:15:14] [PASSED] single_pixel_source_buffer
[20:15:14] [PASSED] single_pixel_clip_rectangle
[20:15:14] [PASSED] well_known_colors
[20:15:14] [PASSED] destination_pitch
[20:15:14] ======== [PASSED] drm_test_fb_xrgb8888_to_rgba5551 =========
[20:15:14] ============= drm_test_fb_xrgb8888_to_rgb888 ==============
[20:15:14] [PASSED] single_pixel_source_buffer
[20:15:14] [PASSED] single_pixel_clip_rectangle
[20:15:14] [PASSED] well_known_colors
[20:15:14] [PASSED] destination_pitch
[20:15:14] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb888 ==========
[20:15:14] ============= drm_test_fb_xrgb8888_to_bgr888 ==============
[20:15:14] [PASSED] single_pixel_source_buffer
[20:15:14] [PASSED] single_pixel_clip_rectangle
[20:15:14] [PASSED] well_known_colors
[20:15:14] [PASSED] destination_pitch
[20:15:14] ========= [PASSED] drm_test_fb_xrgb8888_to_bgr888 ==========
[20:15:14] ============ drm_test_fb_xrgb8888_to_argb8888 =============
[20:15:14] [PASSED] single_pixel_source_buffer
[20:15:14] [PASSED] single_pixel_clip_rectangle
[20:15:14] [PASSED] well_known_colors
[20:15:14] [PASSED] destination_pitch
[20:15:14] ======== [PASSED] drm_test_fb_xrgb8888_to_argb8888 =========
[20:15:14] =========== drm_test_fb_xrgb8888_to_xrgb2101010 ===========
[20:15:14] [PASSED] single_pixel_source_buffer
[20:15:14] [PASSED] single_pixel_clip_rectangle
[20:15:14] [PASSED] well_known_colors
[20:15:14] [PASSED] destination_pitch
[20:15:14] ======= [PASSED] drm_test_fb_xrgb8888_to_xrgb2101010 =======
[20:15:14] =========== drm_test_fb_xrgb8888_to_argb2101010 ===========
[20:15:14] [PASSED] single_pixel_source_buffer
[20:15:14] [PASSED] single_pixel_clip_rectangle
[20:15:14] [PASSED] well_known_colors
[20:15:14] [PASSED] destination_pitch
[20:15:14] ======= [PASSED] drm_test_fb_xrgb8888_to_argb2101010 =======
[20:15:14] ============== drm_test_fb_xrgb8888_to_mono ===============
[20:15:14] [PASSED] single_pixel_source_buffer
[20:15:14] [PASSED] single_pixel_clip_rectangle
[20:15:14] [PASSED] well_known_colors
[20:15:14] [PASSED] destination_pitch
[20:15:14] ========== [PASSED] drm_test_fb_xrgb8888_to_mono ===========
[20:15:14] ==================== drm_test_fb_swab =====================
[20:15:14] [PASSED] single_pixel_source_buffer
[20:15:14] [PASSED] single_pixel_clip_rectangle
[20:15:14] [PASSED] well_known_colors
[20:15:14] [PASSED] destination_pitch
[20:15:14] ================ [PASSED] drm_test_fb_swab =================
[20:15:14] ============ drm_test_fb_xrgb8888_to_xbgr8888 =============
[20:15:14] [PASSED] single_pixel_source_buffer
[20:15:14] [PASSED] single_pixel_clip_rectangle
[20:15:14] [PASSED] well_known_colors
[20:15:14] [PASSED] destination_pitch
[20:15:14] ======== [PASSED] drm_test_fb_xrgb8888_to_xbgr8888 =========
[20:15:14] ============ drm_test_fb_xrgb8888_to_abgr8888 =============
[20:15:14] [PASSED] single_pixel_source_buffer
[20:15:14] [PASSED] single_pixel_clip_rectangle
[20:15:14] [PASSED] well_known_colors
[20:15:14] [PASSED] destination_pitch
[20:15:14] ======== [PASSED] drm_test_fb_xrgb8888_to_abgr8888 =========
[20:15:14] ================= drm_test_fb_clip_offset =================
[20:15:14] [PASSED] pass through
[20:15:14] [PASSED] horizontal offset
[20:15:14] [PASSED] vertical offset
[20:15:14] [PASSED] horizontal and vertical offset
[20:15:14] [PASSED] horizontal offset (custom pitch)
[20:15:14] [PASSED] vertical offset (custom pitch)
[20:15:14] [PASSED] horizontal and vertical offset (custom pitch)
[20:15:14] ============= [PASSED] drm_test_fb_clip_offset =============
[20:15:14] =================== drm_test_fb_memcpy ====================
[20:15:14] [PASSED] single_pixel_source_buffer: XR24 little-endian (0x34325258)
[20:15:14] [PASSED] single_pixel_source_buffer: XRA8 little-endian (0x38415258)
[20:15:14] [PASSED] single_pixel_source_buffer: YU24 little-endian (0x34325559)
[20:15:14] [PASSED] single_pixel_clip_rectangle: XB24 little-endian (0x34324258)
[20:15:14] [PASSED] single_pixel_clip_rectangle: XRA8 little-endian (0x38415258)
[20:15:14] [PASSED] single_pixel_clip_rectangle: YU24 little-endian (0x34325559)
[20:15:14] [PASSED] well_known_colors: XB24 little-endian (0x34324258)
[20:15:14] [PASSED] well_known_colors: XRA8 little-endian (0x38415258)
[20:15:14] [PASSED] well_known_colors: YU24 little-endian (0x34325559)
[20:15:14] [PASSED] destination_pitch: XB24 little-endian (0x34324258)
[20:15:14] [PASSED] destination_pitch: XRA8 little-endian (0x38415258)
[20:15:14] [PASSED] destination_pitch: YU24 little-endian (0x34325559)
[20:15:14] =============== [PASSED] drm_test_fb_memcpy ================
[20:15:14] ============= [PASSED] drm_format_helper_test ==============
[20:15:14] ================= drm_format (18 subtests) =================
[20:15:14] [PASSED] drm_test_format_block_width_invalid
[20:15:14] [PASSED] drm_test_format_block_width_one_plane
[20:15:14] [PASSED] drm_test_format_block_width_two_plane
[20:15:14] [PASSED] drm_test_format_block_width_three_plane
[20:15:14] [PASSED] drm_test_format_block_width_tiled
[20:15:14] [PASSED] drm_test_format_block_height_invalid
[20:15:14] [PASSED] drm_test_format_block_height_one_plane
[20:15:14] [PASSED] drm_test_format_block_height_two_plane
[20:15:14] [PASSED] drm_test_format_block_height_three_plane
[20:15:14] [PASSED] drm_test_format_block_height_tiled
[20:15:14] [PASSED] drm_test_format_min_pitch_invalid
[20:15:14] [PASSED] drm_test_format_min_pitch_one_plane_8bpp
[20:15:14] [PASSED] drm_test_format_min_pitch_one_plane_16bpp
[20:15:14] [PASSED] drm_test_format_min_pitch_one_plane_24bpp
[20:15:14] [PASSED] drm_test_format_min_pitch_one_plane_32bpp
[20:15:14] [PASSED] drm_test_format_min_pitch_two_plane
[20:15:14] [PASSED] drm_test_format_min_pitch_three_plane_8bpp
[20:15:14] [PASSED] drm_test_format_min_pitch_tiled
[20:15:14] =================== [PASSED] drm_format ====================
[20:15:14] ============== drm_framebuffer (10 subtests) ===============
[20:15:14] ========== drm_test_framebuffer_check_src_coords ==========
[20:15:14] [PASSED] Success: source fits into fb
[20:15:14] [PASSED] Fail: overflowing fb with x-axis coordinate
[20:15:14] [PASSED] Fail: overflowing fb with y-axis coordinate
[20:15:14] [PASSED] Fail: overflowing fb with source width
[20:15:14] [PASSED] Fail: overflowing fb with source height
[20:15:14] ====== [PASSED] drm_test_framebuffer_check_src_coords ======
[20:15:14] [PASSED] drm_test_framebuffer_cleanup
[20:15:14] =============== drm_test_framebuffer_create ===============
[20:15:14] [PASSED] ABGR8888 normal sizes
[20:15:14] [PASSED] ABGR8888 max sizes
[20:15:14] [PASSED] ABGR8888 pitch greater than min required
[20:15:14] [PASSED] ABGR8888 pitch less than min required
[20:15:14] [PASSED] ABGR8888 Invalid width
[20:15:14] [PASSED] ABGR8888 Invalid buffer handle
[20:15:14] [PASSED] No pixel format
[20:15:14] [PASSED] ABGR8888 Width 0
[20:15:14] [PASSED] ABGR8888 Height 0
[20:15:14] [PASSED] ABGR8888 Out of bound height * pitch combination
[20:15:14] [PASSED] ABGR8888 Large buffer offset
[20:15:14] [PASSED] ABGR8888 Buffer offset for inexistent plane
[20:15:14] [PASSED] ABGR8888 Invalid flag
[20:15:14] [PASSED] ABGR8888 Set DRM_MODE_FB_MODIFIERS without modifiers
[20:15:14] [PASSED] ABGR8888 Valid buffer modifier
[20:15:14] [PASSED] ABGR8888 Invalid buffer modifier(DRM_FORMAT_MOD_SAMSUNG_64_32_TILE)
[20:15:14] [PASSED] ABGR8888 Extra pitches without DRM_MODE_FB_MODIFIERS
[20:15:14] [PASSED] ABGR8888 Extra pitches with DRM_MODE_FB_MODIFIERS
[20:15:14] [PASSED] NV12 Normal sizes
[20:15:14] [PASSED] NV12 Max sizes
[20:15:14] [PASSED] NV12 Invalid pitch
[20:15:14] [PASSED] NV12 Invalid modifier/missing DRM_MODE_FB_MODIFIERS flag
[20:15:14] [PASSED] NV12 different modifier per-plane
[20:15:14] [PASSED] NV12 with DRM_FORMAT_MOD_SAMSUNG_64_32_TILE
[20:15:14] [PASSED] NV12 Valid modifiers without DRM_MODE_FB_MODIFIERS
[20:15:14] [PASSED] NV12 Modifier for inexistent plane
[20:15:14] [PASSED] NV12 Handle for inexistent plane
[20:15:14] [PASSED] NV12 Handle for inexistent plane without DRM_MODE_FB_MODIFIERS
[20:15:14] [PASSED] YVU420 DRM_MODE_FB_MODIFIERS set without modifier
[20:15:14] [PASSED] YVU420 Normal sizes
[20:15:14] [PASSED] YVU420 Max sizes
[20:15:14] [PASSED] YVU420 Invalid pitch
[20:15:14] [PASSED] YVU420 Different pitches
[20:15:14] [PASSED] YVU420 Different buffer offsets/pitches
[20:15:14] [PASSED] YVU420 Modifier set just for plane 0, without DRM_MODE_FB_MODIFIERS
[20:15:14] [PASSED] YVU420 Modifier set just for planes 0, 1, without DRM_MODE_FB_MODIFIERS
[20:15:14] [PASSED] YVU420 Modifier set just for plane 0, 1, with DRM_MODE_FB_MODIFIERS
[20:15:14] [PASSED] YVU420 Valid modifier
[20:15:14] [PASSED] YVU420 Different modifiers per plane
[20:15:14] [PASSED] YVU420 Modifier for inexistent plane
[20:15:14] [PASSED] YUV420_10BIT Invalid modifier(DRM_FORMAT_MOD_LINEAR)
[20:15:14] [PASSED] X0L2 Normal sizes
[20:15:14] [PASSED] X0L2 Max sizes
[20:15:14] [PASSED] X0L2 Invalid pitch
[20:15:14] [PASSED] X0L2 Pitch greater than minimum required
[20:15:14] [PASSED] X0L2 Handle for inexistent plane
[20:15:14] [PASSED] X0L2 Offset for inexistent plane, without DRM_MODE_FB_MODIFIERS set
[20:15:14] [PASSED] X0L2 Modifier without DRM_MODE_FB_MODIFIERS set
[20:15:14] [PASSED] X0L2 Valid modifier
[20:15:14] [PASSED] X0L2 Modifier for inexistent plane
[20:15:14] =========== [PASSED] drm_test_framebuffer_create ===========
[20:15:14] [PASSED] drm_test_framebuffer_free
[20:15:14] [PASSED] drm_test_framebuffer_init
[20:15:14] [PASSED] drm_test_framebuffer_init_bad_format
[20:15:14] [PASSED] drm_test_framebuffer_init_dev_mismatch
[20:15:14] [PASSED] drm_test_framebuffer_lookup
[20:15:14] [PASSED] drm_test_framebuffer_lookup_inexistent
[20:15:14] [PASSED] drm_test_framebuffer_modifiers_not_supported
[20:15:14] ================= [PASSED] drm_framebuffer =================
[20:15:14] ================ drm_gem_shmem (8 subtests) ================
[20:15:14] [PASSED] drm_gem_shmem_test_obj_create
[20:15:14] [PASSED] drm_gem_shmem_test_obj_create_private
[20:15:14] [PASSED] drm_gem_shmem_test_pin_pages
[20:15:14] [PASSED] drm_gem_shmem_test_vmap
[20:15:14] [PASSED] drm_gem_shmem_test_get_pages_sgt
[20:15:14] [PASSED] drm_gem_shmem_test_get_sg_table
[20:15:14] [PASSED] drm_gem_shmem_test_madvise
[20:15:14] [PASSED] drm_gem_shmem_test_purge
[20:15:14] ================== [PASSED] drm_gem_shmem ==================
[20:15:14] === drm_atomic_helper_connector_hdmi_check (27 subtests) ===
[20:15:14] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode
[20:15:14] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode_vic_1
[20:15:14] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode
[20:15:14] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode_vic_1
[20:15:14] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode
[20:15:14] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode_vic_1
[20:15:14] ====== drm_test_check_broadcast_rgb_cea_mode_yuv420 =======
[20:15:14] [PASSED] Automatic
[20:15:14] [PASSED] Full
[20:15:14] [PASSED] Limited 16:235
[20:15:14] == [PASSED] drm_test_check_broadcast_rgb_cea_mode_yuv420 ===
[20:15:14] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_changed
[20:15:14] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_not_changed
[20:15:14] [PASSED] drm_test_check_disable_connector
[20:15:14] [PASSED] drm_test_check_hdmi_funcs_reject_rate
[20:15:14] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_rgb
[20:15:14] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_yuv420
[20:15:14] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv422
[20:15:14] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv420
[20:15:14] [PASSED] drm_test_check_driver_unsupported_fallback_yuv420
[20:15:14] [PASSED] drm_test_check_output_bpc_crtc_mode_changed
[20:15:14] [PASSED] drm_test_check_output_bpc_crtc_mode_not_changed
[20:15:14] [PASSED] drm_test_check_output_bpc_dvi
[20:15:14] [PASSED] drm_test_check_output_bpc_format_vic_1
[20:15:14] [PASSED] drm_test_check_output_bpc_format_display_8bpc_only
[20:15:14] [PASSED] drm_test_check_output_bpc_format_display_rgb_only
[20:15:14] [PASSED] drm_test_check_output_bpc_format_driver_8bpc_only
[20:15:14] [PASSED] drm_test_check_output_bpc_format_driver_rgb_only
[20:15:14] [PASSED] drm_test_check_tmds_char_rate_rgb_8bpc
[20:15:14] [PASSED] drm_test_check_tmds_char_rate_rgb_10bpc
[20:15:14] [PASSED] drm_test_check_tmds_char_rate_rgb_12bpc
[20:15:14] ===== [PASSED] drm_atomic_helper_connector_hdmi_check ======
[20:15:14] === drm_atomic_helper_connector_hdmi_reset (6 subtests) ====
[20:15:14] [PASSED] drm_test_check_broadcast_rgb_value
[20:15:14] [PASSED] drm_test_check_bpc_8_value
[20:15:14] [PASSED] drm_test_check_bpc_10_value
[20:15:14] [PASSED] drm_test_check_bpc_12_value
[20:15:14] [PASSED] drm_test_check_format_value
[20:15:14] [PASSED] drm_test_check_tmds_char_value
[20:15:14] ===== [PASSED] drm_atomic_helper_connector_hdmi_reset ======
[20:15:14] = drm_atomic_helper_connector_hdmi_mode_valid (4 subtests) =
[20:15:14] [PASSED] drm_test_check_mode_valid
[20:15:14] [PASSED] drm_test_check_mode_valid_reject
[20:15:14] [PASSED] drm_test_check_mode_valid_reject_rate
[20:15:14] [PASSED] drm_test_check_mode_valid_reject_max_clock
[20:15:14] === [PASSED] drm_atomic_helper_connector_hdmi_mode_valid ===
[20:15:14] ================= drm_managed (2 subtests) =================
[20:15:14] [PASSED] drm_test_managed_release_action
[20:15:14] [PASSED] drm_test_managed_run_action
[20:15:14] =================== [PASSED] drm_managed ===================
[20:15:14] =================== drm_mm (6 subtests) ====================
[20:15:14] [PASSED] drm_test_mm_init
[20:15:14] [PASSED] drm_test_mm_debug
[20:15:14] [PASSED] drm_test_mm_align32
[20:15:14] [PASSED] drm_test_mm_align64
[20:15:14] [PASSED] drm_test_mm_lowest
[20:15:14] [PASSED] drm_test_mm_highest
[20:15:14] ===================== [PASSED] drm_mm ======================
[20:15:14] ============= drm_modes_analog_tv (5 subtests) =============
[20:15:14] [PASSED] drm_test_modes_analog_tv_mono_576i
[20:15:14] [PASSED] drm_test_modes_analog_tv_ntsc_480i
[20:15:14] [PASSED] drm_test_modes_analog_tv_ntsc_480i_inlined
[20:15:14] [PASSED] drm_test_modes_analog_tv_pal_576i
[20:15:14] [PASSED] drm_test_modes_analog_tv_pal_576i_inlined
[20:15:14] =============== [PASSED] drm_modes_analog_tv ===============
[20:15:14] ============== drm_plane_helper (2 subtests) ===============
[20:15:14] =============== drm_test_check_plane_state ================
[20:15:14] [PASSED] clipping_simple
[20:15:14] [PASSED] clipping_rotate_reflect
[20:15:14] [PASSED] positioning_simple
[20:15:14] [PASSED] upscaling
[20:15:14] [PASSED] downscaling
[20:15:14] [PASSED] rounding1
[20:15:14] [PASSED] rounding2
[20:15:14] [PASSED] rounding3
[20:15:14] [PASSED] rounding4
[20:15:14] =========== [PASSED] drm_test_check_plane_state ============
[20:15:14] =========== drm_test_check_invalid_plane_state ============
[20:15:14] [PASSED] positioning_invalid
[20:15:14] [PASSED] upscaling_invalid
[20:15:14] [PASSED] downscaling_invalid
[20:15:14] ======= [PASSED] drm_test_check_invalid_plane_state ========
[20:15:14] ================ [PASSED] drm_plane_helper =================
[20:15:14] ====== drm_connector_helper_tv_get_modes (1 subtest) =======
[20:15:14] ====== drm_test_connector_helper_tv_get_modes_check =======
[20:15:14] [PASSED] None
[20:15:14] [PASSED] PAL
[20:15:14] [PASSED] NTSC
[20:15:14] [PASSED] Both, NTSC Default
[20:15:14] [PASSED] Both, PAL Default
[20:15:14] [PASSED] Both, NTSC Default, with PAL on command-line
[20:15:14] [PASSED] Both, PAL Default, with NTSC on command-line
[20:15:14] == [PASSED] drm_test_connector_helper_tv_get_modes_check ===
[20:15:14] ======== [PASSED] drm_connector_helper_tv_get_modes ========
[20:15:14] ================== drm_rect (9 subtests) ===================
[20:15:14] [PASSED] drm_test_rect_clip_scaled_div_by_zero
[20:15:14] [PASSED] drm_test_rect_clip_scaled_not_clipped
[20:15:14] [PASSED] drm_test_rect_clip_scaled_clipped
[20:15:14] [PASSED] drm_test_rect_clip_scaled_signed_vs_unsigned
[20:15:14] ================= drm_test_rect_intersect =================
[20:15:14] [PASSED] top-left x bottom-right: 2x2+1+1 x 2x2+0+0
[20:15:14] [PASSED] top-right x bottom-left: 2x2+0+0 x 2x2+1-1
[20:15:14] [PASSED] bottom-left x top-right: 2x2+1-1 x 2x2+0+0
[20:15:14] [PASSED] bottom-right x top-left: 2x2+0+0 x 2x2+1+1
[20:15:14] [PASSED] right x left: 2x1+0+0 x 3x1+1+0
[20:15:14] [PASSED] left x right: 3x1+1+0 x 2x1+0+0
[20:15:14] [PASSED] up x bottom: 1x2+0+0 x 1x3+0-1
[20:15:14] [PASSED] bottom x up: 1x3+0-1 x 1x2+0+0
[20:15:14] [PASSED] touching corner: 1x1+0+0 x 2x2+1+1
[20:15:14] [PASSED] touching side: 1x1+0+0 x 1x1+1+0
[20:15:14] [PASSED] equal rects: 2x2+0+0 x 2x2+0+0
[20:15:14] [PASSED] inside another: 2x2+0+0 x 1x1+1+1
[20:15:14] [PASSED] far away: 1x1+0+0 x 1x1+3+6
[20:15:14] [PASSED] points intersecting: 0x0+5+10 x 0x0+5+10
[20:15:14] [PASSED] points not intersecting: 0x0+0+0 x 0x0+5+10
[20:15:14] ============= [PASSED] drm_test_rect_intersect =============
[20:15:14] ================ drm_test_rect_calc_hscale ================
[20:15:14] [PASSED] normal use
[20:15:14] [PASSED] out of max range
[20:15:14] [PASSED] out of min range
[20:15:14] [PASSED] zero dst
[20:15:14] [PASSED] negative src
[20:15:14] [PASSED] negative dst
[20:15:14] ============ [PASSED] drm_test_rect_calc_hscale ============
[20:15:14] ================ drm_test_rect_calc_vscale ================
[20:15:14] [PASSED] normal use
[20:15:14] [PASSED] out of max range
[20:15:14] [PASSED] out of min range
[20:15:14] [PASSED] zero dst
[20:15:14] [PASSED] negative src
[20:15:14] [PASSED] negative dst
[20:15:14] ============ [PASSED] drm_test_rect_calc_vscale ============
[20:15:14] ================== drm_test_rect_rotate ===================
[20:15:14] [PASSED] reflect-x
[20:15:14] [PASSED] reflect-y
[20:15:14] [PASSED] rotate-0
[20:15:14] [PASSED] rotate-90
[20:15:14] [PASSED] rotate-180
[20:15:14] [PASSED] rotate-270
stty: 'standard input': Inappropriate ioctl for device
[20:15:14] ============== [PASSED] drm_test_rect_rotate ===============
[20:15:14] ================ drm_test_rect_rotate_inv =================
[20:15:14] [PASSED] reflect-x
[20:15:14] [PASSED] reflect-y
[20:15:14] [PASSED] rotate-0
[20:15:14] [PASSED] rotate-90
[20:15:14] [PASSED] rotate-180
[20:15:14] [PASSED] rotate-270
[20:15:14] ============ [PASSED] drm_test_rect_rotate_inv =============
[20:15:14] ==================== [PASSED] drm_rect =====================
[20:15:14] ============ drm_sysfb_modeset_test (1 subtest) ============
[20:15:14] ============ drm_test_sysfb_build_fourcc_list =============
[20:15:14] [PASSED] no native formats
[20:15:14] [PASSED] XRGB8888 as native format
[20:15:14] [PASSED] remove duplicates
[20:15:14] [PASSED] convert alpha formats
[20:15:14] [PASSED] random formats
[20:15:14] ======== [PASSED] drm_test_sysfb_build_fourcc_list =========
[20:15:14] ============= [PASSED] drm_sysfb_modeset_test ==============
[20:15:14] ============================================================
[20:15:14] Testing complete. Ran 616 tests: passed: 616
[20:15:14] Elapsed time: 24.498s total, 1.743s configuring, 22.589s building, 0.143s running
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/ttm/tests/.kunitconfig
[20:15:14] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[20:15:15] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[20:15:23] Starting KUnit Kernel (1/1)...
[20:15:23] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[20:15:23] ================= ttm_device (5 subtests) ==================
[20:15:23] [PASSED] ttm_device_init_basic
[20:15:23] [PASSED] ttm_device_init_multiple
[20:15:23] [PASSED] ttm_device_fini_basic
[20:15:23] [PASSED] ttm_device_init_no_vma_man
[20:15:23] ================== ttm_device_init_pools ==================
[20:15:23] [PASSED] No DMA allocations, no DMA32 required
[20:15:23] [PASSED] DMA allocations, DMA32 required
[20:15:23] [PASSED] No DMA allocations, DMA32 required
[20:15:23] [PASSED] DMA allocations, no DMA32 required
[20:15:23] ============== [PASSED] ttm_device_init_pools ==============
[20:15:23] =================== [PASSED] ttm_device ====================
[20:15:23] ================== ttm_pool (8 subtests) ===================
[20:15:23] ================== ttm_pool_alloc_basic ===================
[20:15:23] [PASSED] One page
[20:15:23] [PASSED] More than one page
[20:15:23] [PASSED] Above the allocation limit
[20:15:23] [PASSED] One page, with coherent DMA mappings enabled
[20:15:23] [PASSED] Above the allocation limit, with coherent DMA mappings enabled
[20:15:23] ============== [PASSED] ttm_pool_alloc_basic ===============
[20:15:23] ============== ttm_pool_alloc_basic_dma_addr ==============
[20:15:23] [PASSED] One page
[20:15:23] [PASSED] More than one page
[20:15:23] [PASSED] Above the allocation limit
[20:15:23] [PASSED] One page, with coherent DMA mappings enabled
[20:15:23] [PASSED] Above the allocation limit, with coherent DMA mappings enabled
[20:15:23] ========== [PASSED] ttm_pool_alloc_basic_dma_addr ==========
[20:15:23] [PASSED] ttm_pool_alloc_order_caching_match
[20:15:23] [PASSED] ttm_pool_alloc_caching_mismatch
[20:15:23] [PASSED] ttm_pool_alloc_order_mismatch
[20:15:23] [PASSED] ttm_pool_free_dma_alloc
[20:15:23] [PASSED] ttm_pool_free_no_dma_alloc
[20:15:23] [PASSED] ttm_pool_fini_basic
[20:15:23] ==================== [PASSED] ttm_pool =====================
[20:15:23] ================ ttm_resource (8 subtests) =================
[20:15:23] ================= ttm_resource_init_basic =================
[20:15:23] [PASSED] Init resource in TTM_PL_SYSTEM
[20:15:23] [PASSED] Init resource in TTM_PL_VRAM
[20:15:23] [PASSED] Init resource in a private placement
[20:15:23] [PASSED] Init resource in TTM_PL_SYSTEM, set placement flags
[20:15:23] ============= [PASSED] ttm_resource_init_basic =============
[20:15:23] [PASSED] ttm_resource_init_pinned
[20:15:23] [PASSED] ttm_resource_fini_basic
[20:15:23] [PASSED] ttm_resource_manager_init_basic
[20:15:23] [PASSED] ttm_resource_manager_usage_basic
[20:15:23] [PASSED] ttm_resource_manager_set_used_basic
[20:15:23] [PASSED] ttm_sys_man_alloc_basic
[20:15:23] [PASSED] ttm_sys_man_free_basic
[20:15:23] ================== [PASSED] ttm_resource ===================
[20:15:23] =================== ttm_tt (15 subtests) ===================
[20:15:23] ==================== ttm_tt_init_basic ====================
[20:15:23] [PASSED] Page-aligned size
[20:15:23] [PASSED] Extra pages requested
[20:15:23] ================ [PASSED] ttm_tt_init_basic ================
[20:15:23] [PASSED] ttm_tt_init_misaligned
[20:15:23] [PASSED] ttm_tt_fini_basic
[20:15:23] [PASSED] ttm_tt_fini_sg
[20:15:23] [PASSED] ttm_tt_fini_shmem
[20:15:23] [PASSED] ttm_tt_create_basic
[20:15:23] [PASSED] ttm_tt_create_invalid_bo_type
[20:15:23] [PASSED] ttm_tt_create_ttm_exists
[20:15:23] [PASSED] ttm_tt_create_failed
[20:15:23] [PASSED] ttm_tt_destroy_basic
[20:15:23] [PASSED] ttm_tt_populate_null_ttm
[20:15:23] [PASSED] ttm_tt_populate_populated_ttm
[20:15:23] [PASSED] ttm_tt_unpopulate_basic
[20:15:23] [PASSED] ttm_tt_unpopulate_empty_ttm
[20:15:23] [PASSED] ttm_tt_swapin_basic
[20:15:23] ===================== [PASSED] ttm_tt ======================
[20:15:23] =================== ttm_bo (14 subtests) ===================
[20:15:23] =========== ttm_bo_reserve_optimistic_no_ticket ===========
[20:15:23] [PASSED] Cannot be interrupted and sleeps
[20:15:23] [PASSED] Cannot be interrupted, locks straight away
[20:15:23] [PASSED] Can be interrupted, sleeps
[20:15:23] ======= [PASSED] ttm_bo_reserve_optimistic_no_ticket =======
[20:15:23] [PASSED] ttm_bo_reserve_locked_no_sleep
[20:15:23] [PASSED] ttm_bo_reserve_no_wait_ticket
[20:15:23] [PASSED] ttm_bo_reserve_double_resv
[20:15:23] [PASSED] ttm_bo_reserve_interrupted
[20:15:23] [PASSED] ttm_bo_reserve_deadlock
[20:15:23] [PASSED] ttm_bo_unreserve_basic
[20:15:23] [PASSED] ttm_bo_unreserve_pinned
[20:15:23] [PASSED] ttm_bo_unreserve_bulk
[20:15:23] [PASSED] ttm_bo_put_basic
[20:15:23] [PASSED] ttm_bo_put_shared_resv
[20:15:23] [PASSED] ttm_bo_pin_basic
[20:15:23] [PASSED] ttm_bo_pin_unpin_resource
[20:15:23] [PASSED] ttm_bo_multiple_pin_one_unpin
[20:15:23] ===================== [PASSED] ttm_bo ======================
[20:15:23] ============== ttm_bo_validate (21 subtests) ===============
[20:15:23] ============== ttm_bo_init_reserved_sys_man ===============
[20:15:23] [PASSED] Buffer object for userspace
[20:15:23] [PASSED] Kernel buffer object
[20:15:23] [PASSED] Shared buffer object
[20:15:23] ========== [PASSED] ttm_bo_init_reserved_sys_man ===========
[20:15:23] ============== ttm_bo_init_reserved_mock_man ==============
[20:15:23] [PASSED] Buffer object for userspace
[20:15:23] [PASSED] Kernel buffer object
[20:15:23] [PASSED] Shared buffer object
[20:15:23] ========== [PASSED] ttm_bo_init_reserved_mock_man ==========
[20:15:23] [PASSED] ttm_bo_init_reserved_resv
[20:15:23] ================== ttm_bo_validate_basic ==================
[20:15:23] [PASSED] Buffer object for userspace
[20:15:23] [PASSED] Kernel buffer object
[20:15:23] [PASSED] Shared buffer object
[20:15:23] ============== [PASSED] ttm_bo_validate_basic ==============
[20:15:23] [PASSED] ttm_bo_validate_invalid_placement
[20:15:23] ============= ttm_bo_validate_same_placement ==============
[20:15:23] [PASSED] System manager
[20:15:23] [PASSED] VRAM manager
[20:15:23] ========= [PASSED] ttm_bo_validate_same_placement ==========
[20:15:23] [PASSED] ttm_bo_validate_failed_alloc
[20:15:23] [PASSED] ttm_bo_validate_pinned
[20:15:23] [PASSED] ttm_bo_validate_busy_placement
[20:15:23] ================ ttm_bo_validate_multihop =================
[20:15:23] [PASSED] Buffer object for userspace
[20:15:23] [PASSED] Kernel buffer object
[20:15:23] [PASSED] Shared buffer object
[20:15:23] ============ [PASSED] ttm_bo_validate_multihop =============
[20:15:23] ========== ttm_bo_validate_no_placement_signaled ==========
[20:15:23] [PASSED] Buffer object in system domain, no page vector
[20:15:23] [PASSED] Buffer object in system domain with an existing page vector
[20:15:23] ====== [PASSED] ttm_bo_validate_no_placement_signaled ======
[20:15:23] ======== ttm_bo_validate_no_placement_not_signaled ========
[20:15:23] [PASSED] Buffer object for userspace
[20:15:23] [PASSED] Kernel buffer object
[20:15:23] [PASSED] Shared buffer object
[20:15:23] ==== [PASSED] ttm_bo_validate_no_placement_not_signaled ====
[20:15:23] [PASSED] ttm_bo_validate_move_fence_signaled
[20:15:24] ========= ttm_bo_validate_move_fence_not_signaled =========
[20:15:24] [PASSED] Waits for GPU
[20:15:24] [PASSED] Tries to lock straight away
[20:15:24] ===== [PASSED] ttm_bo_validate_move_fence_not_signaled =====
[20:15:24] [PASSED] ttm_bo_validate_happy_evict
[20:15:24] [PASSED] ttm_bo_validate_all_pinned_evict
[20:15:24] [PASSED] ttm_bo_validate_allowed_only_evict
[20:15:24] [PASSED] ttm_bo_validate_deleted_evict
[20:15:24] [PASSED] ttm_bo_validate_busy_domain_evict
[20:15:24] [PASSED] ttm_bo_validate_evict_gutting
[20:15:24] [PASSED] ttm_bo_validate_recrusive_evict
stty: 'standard input': Inappropriate ioctl for device
[20:15:24] ================= [PASSED] ttm_bo_validate =================
[20:15:24] ============================================================
[20:15:24] Testing complete. Ran 101 tests: passed: 101
[20:15:24] Elapsed time: 9.898s total, 1.742s configuring, 7.890s building, 0.230s running
+ cleanup
++ stat -c %u:%g /kernel
+ chown -R 1003:1003 /kernel
^ permalink raw reply [flat|nested] 17+ messages in thread
* ✓ Xe.CI.BAT: success for drm/gpuvm: Rename 'map' to 'op' in drm_gpuvm_map_req
2025-08-20 15:23 [PATCH] drm/gpuvm: Rename 'map' to 'op' in drm_gpuvm_map_req Himal Prasad Ghimiray
` (4 preceding siblings ...)
2025-08-20 20:15 ` ✓ CI.KUnit: success for " Patchwork
@ 2025-08-20 21:19 ` Patchwork
2025-08-21 20:15 ` ✗ Xe.CI.Full: failure " Patchwork
6 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2025-08-20 21:19 UTC (permalink / raw)
To: Ghimiray, Himal Prasad; +Cc: intel-xe
[-- Attachment #1: Type: text/plain, Size: 971 bytes --]
== Series Details ==
Series: drm/gpuvm: Rename 'map' to 'op' in drm_gpuvm_map_req
URL : https://patchwork.freedesktop.org/series/153233/
State : success
== Summary ==
CI Bug Log - changes from xe-3588-67f294a52e4b22d1b5bb86dd5dd3ac33e640717a_BAT -> xe-pw-153233v1_BAT
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (11 -> 9)
------------------------------
Missing (2): bat-adlp-vm bat-ptl-vm
Changes
-------
No changes found
Build changes
-------------
* Linux: xe-3588-67f294a52e4b22d1b5bb86dd5dd3ac33e640717a -> xe-pw-153233v1
IGT_8499: e5e236fad9e36c3a868bc851262ee34ca57f9e5c @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
xe-3588-67f294a52e4b22d1b5bb86dd5dd3ac33e640717a: 67f294a52e4b22d1b5bb86dd5dd3ac33e640717a
xe-pw-153233v1: 153233v1
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/index.html
[-- Attachment #2: Type: text/html, Size: 1539 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/gpuvm: Rename 'map' to 'op' in drm_gpuvm_map_req
2025-08-20 16:07 ` Boris Brezillon
@ 2025-08-21 11:01 ` Boris Brezillon
2025-08-21 11:25 ` Boris Brezillon
0 siblings, 1 reply; 17+ messages in thread
From: Boris Brezillon @ 2025-08-21 11:01 UTC (permalink / raw)
To: Himal Prasad Ghimiray
Cc: intel-xe, Boris Brezillon, Danilo Krummrich, Matt Coster,
Rob Clark, Matthew Brost, dri-devel
On Wed, 20 Aug 2025 18:07:42 +0200
Boris Brezillon <boris.brezillon@collabora.com> wrote:
> On Wed, 20 Aug 2025 20:53:35 +0530
> Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com> wrote:
>
> > Renamed 'map' to 'op' in drm_gpuvm_map_req for clarity and added
> > corresponding documentation. No functional changes introduced.
> >
> > Fixes: baf1638c0956 ("drm/gpuvm: Introduce drm_gpuvm_madvise_ops_create")
> > Fixes: 000a45dce7ad ("drm/gpuvm: Pass map arguments through a struct")
> > Suggested-by: Boris Brezillon <bbrezillon@kernel.org>
> > Suggested-by: Danilo Krummrich <dakr@kernel.org>
> > Cc: Danilo Krummrich <dakr@kernel.org>
> > Cc: Matt Coster <matt.coster@imgtec.com>
> > Cc: Boris Brezillon <bbrezillon@kernel.org>
> > Cc: Rob Clark <robin.clark@oss.qualcomm.com>
> > Cc: Matthew Brost <matthew.brost@intel.com>
> > Cc: <dri-devel@lists.freedesktop.org>
> > Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
>
> Acked-by: Boris Brezillon <boris.brezillon@collabora.com>
>
> > ---
> > drivers/gpu/drm/drm_gpuvm.c | 36 +++++++++++++-------------
> > drivers/gpu/drm/imagination/pvr_vm.c | 8 +++---
> > drivers/gpu/drm/msm/msm_gem_vma.c | 16 ++++++------
> > drivers/gpu/drm/nouveau/nouveau_uvmm.c | 8 +++---
> > drivers/gpu/drm/panthor/panthor_mmu.c | 8 +++---
> > drivers/gpu/drm/xe/xe_vm.c | 8 +++---
> > include/drm/drm_gpuvm.h | 4 +--
> > 7 files changed, 44 insertions(+), 44 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/drm_gpuvm.c b/drivers/gpu/drm/drm_gpuvm.c
> > index 39f934a91a7b..e9aaf9b287e7 100644
> > --- a/drivers/gpu/drm/drm_gpuvm.c
> > +++ b/drivers/gpu/drm/drm_gpuvm.c
> > @@ -552,11 +552,11 @@
> > * struct drm_gem_object *obj, u64 offset)
> > * {
> > * struct drm_gpuvm_map_req map_req = {
> > - * .map.va.addr = addr,
> > - * .map.va.range = range,
> > - * .map.gem.obj = obj,
> > - * .map.gem.offset = offset,
> > - * };
> > + * .op.va.addr = addr,
> > + * .op.va.range = range,
> > + * .op.gem.obj = obj,
> > + * .op.gem.offset = offset,
> > + * };
> > * struct drm_gpuva_ops *ops;
> > * struct drm_gpuva_op *op
> > * struct drm_gpuvm_bo *vm_bo;
> > @@ -2132,10 +2132,10 @@ op_map_cb(const struct drm_gpuvm_ops *fn, void *priv,
> > return 0;
> >
> > op.op = DRM_GPUVA_OP_MAP;
> > - op.map.va.addr = req->map.va.addr;
> > - op.map.va.range = req->map.va.range;
> > - op.map.gem.obj = req->map.gem.obj;
> > - op.map.gem.offset = req->map.gem.offset;
> > + op.map.va.addr = req->op.va.addr;
> > + op.map.va.range = req->op.va.range;
> > + op.map.gem.obj = req->op.gem.obj;
> > + op.map.gem.offset = req->op.gem.offset;
> >
> > return fn->sm_step_map(&op, priv);
> > }
> > @@ -2180,12 +2180,12 @@ __drm_gpuvm_sm_map(struct drm_gpuvm *gpuvm,
> > const struct drm_gpuvm_map_req *req,
> > bool madvise)
> > {
> > - struct drm_gem_object *req_obj = req->map.gem.obj;
> > + struct drm_gem_object *req_obj = req->op.gem.obj;
> > const struct drm_gpuvm_map_req *op_map = madvise ? NULL : req;
> > struct drm_gpuva *va, *next;
> > - u64 req_offset = req->map.gem.offset;
> > - u64 req_range = req->map.va.range;
> > - u64 req_addr = req->map.va.addr;
> > + u64 req_offset = req->op.gem.offset;
> > + u64 req_range = req->op.va.range;
> > + u64 req_addr = req->op.va.addr;
> > u64 req_end = req_addr + req_range;
> > int ret;
> >
> > @@ -2272,8 +2272,8 @@ __drm_gpuvm_sm_map(struct drm_gpuvm *gpuvm,
> >
> > if (madvise) {
> > struct drm_gpuvm_map_req map_req = {
> > - .map.va.addr = req_addr,
> > - .map.va.range = end - req_addr,
> > + .op.va.addr = req_addr,
> > + .op.va.range = end - req_addr,
> > };
> >
> > ret = op_map_cb(ops, priv, &map_req);
> > @@ -2340,8 +2340,8 @@ __drm_gpuvm_sm_map(struct drm_gpuvm *gpuvm,
> >
> > if (madvise) {
> > struct drm_gpuvm_map_req map_req = {
> > - .map.va.addr = addr,
> > - .map.va.range = req_end - addr,
> > + .op.va.addr = addr,
> > + .op.va.range = req_end - addr,
> > };
> >
> > return op_map_cb(ops, priv, &map_req);
> > @@ -2583,7 +2583,7 @@ drm_gpuvm_sm_map_exec_lock(struct drm_gpuvm *gpuvm,
> > struct drm_exec *exec, unsigned int num_fences,
> > struct drm_gpuvm_map_req *req)
> > {
> > - struct drm_gem_object *req_obj = req->map.gem.obj;
> > + struct drm_gem_object *req_obj = req->op.gem.obj;
> >
> > if (req_obj) {
> > int ret = drm_exec_prepare_obj(exec, req_obj, num_fences);
> > diff --git a/drivers/gpu/drm/imagination/pvr_vm.c b/drivers/gpu/drm/imagination/pvr_vm.c
> > index 3d97990170bf..983165eb3e6a 100644
> > --- a/drivers/gpu/drm/imagination/pvr_vm.c
> > +++ b/drivers/gpu/drm/imagination/pvr_vm.c
> > @@ -187,10 +187,10 @@ static int pvr_vm_bind_op_exec(struct pvr_vm_bind_op *bind_op)
> > switch (bind_op->type) {
> > case PVR_VM_BIND_TYPE_MAP: {
> > const struct drm_gpuvm_map_req map_req = {
> > - .map.va.addr = bind_op->device_addr,
> > - .map.va.range = bind_op->size,
> > - .map.gem.obj = gem_from_pvr_gem(bind_op->pvr_obj),
> > - .map.gem.offset = bind_op->offset,
> > + .op.va.addr = bind_op->device_addr,
> > + .op.va.range = bind_op->size,
> > + .op.gem.obj = gem_from_pvr_gem(bind_op->pvr_obj),
> > + .op.gem.offset = bind_op->offset,
> > };
> >
> > return drm_gpuvm_sm_map(&bind_op->vm_ctx->gpuvm_mgr,
> > diff --git a/drivers/gpu/drm/msm/msm_gem_vma.c b/drivers/gpu/drm/msm/msm_gem_vma.c
> > index 210604181c05..9b5d003bc5a2 100644
> > --- a/drivers/gpu/drm/msm/msm_gem_vma.c
> > +++ b/drivers/gpu/drm/msm/msm_gem_vma.c
> > @@ -1179,10 +1179,10 @@ vm_bind_job_lock_objects(struct msm_vm_bind_job *job, struct drm_exec *exec)
> > case MSM_VM_BIND_OP_MAP:
> > case MSM_VM_BIND_OP_MAP_NULL: {
> > struct drm_gpuvm_map_req map_req = {
> > - .map.va.addr = op->iova,
> > - .map.va.range = op->range,
> > - .map.gem.obj = op->obj,
> > - .map.gem.offset = op->obj_offset,
> > + .op.va.addr = op->iova,
> > + .op.va.range = op->range,
> > + .op.gem.obj = op->obj,
> > + .op.gem.offset = op->obj_offset,
> > };
> >
> > ret = drm_gpuvm_sm_map_exec_lock(job->vm, exec, 1, &map_req);
> > @@ -1296,10 +1296,10 @@ vm_bind_job_prepare(struct msm_vm_bind_job *job)
> > fallthrough;
> > case MSM_VM_BIND_OP_MAP_NULL: {
> > struct drm_gpuvm_map_req map_req = {
> > - .map.va.addr = op->iova,
> > - .map.va.range = op->range,
> > - .map.gem.obj = op->obj,
> > - .map.gem.offset = op->obj_offset,
> > + .op.va.addr = op->iova,
> > + .op.va.range = op->range,
> > + .op.gem.obj = op->obj,
> > + .op.gem.offset = op->obj_offset,
> > };
> >
> > ret = drm_gpuvm_sm_map(job->vm, &arg, &map_req);
> > diff --git a/drivers/gpu/drm/nouveau/nouveau_uvmm.c b/drivers/gpu/drm/nouveau/nouveau_uvmm.c
> > index d94a85509176..314121a857e7 100644
> > --- a/drivers/gpu/drm/nouveau/nouveau_uvmm.c
> > +++ b/drivers/gpu/drm/nouveau/nouveau_uvmm.c
> > @@ -1277,10 +1277,10 @@ nouveau_uvmm_bind_job_submit(struct nouveau_job *job,
> > case OP_MAP: {
> > struct nouveau_uvma_region *reg;
> > struct drm_gpuvm_map_req map_req = {
> > - .map.va.addr = op->va.addr,
> > - .map.va.range = op->va.range,
> > - .map.gem.obj = op->gem.obj,
> > - .map.gem.offset = op->gem.offset,
> > + .op.va.addr = op->va.addr,
> > + .op.va.range = op->va.range,
> > + .op.gem.obj = op->gem.obj,
> > + .op.gem.offset = op->gem.offset,
> > };
> >
> > reg = nouveau_uvma_region_find_first(uvmm,
> > diff --git a/drivers/gpu/drm/panthor/panthor_mmu.c b/drivers/gpu/drm/panthor/panthor_mmu.c
> > index 2003b91a8409..3799e2c6ea59 100644
> > --- a/drivers/gpu/drm/panthor/panthor_mmu.c
> > +++ b/drivers/gpu/drm/panthor/panthor_mmu.c
> > @@ -2204,10 +2204,10 @@ panthor_vm_exec_op(struct panthor_vm *vm, struct panthor_vm_op_ctx *op,
> > switch (op_type) {
> > case DRM_PANTHOR_VM_BIND_OP_TYPE_MAP: {
> > const struct drm_gpuvm_map_req map_req = {
> > - .map.va.addr = op->va.addr,
> > - .map.va.range = op->va.range,
> > - .map.gem.obj = op->map.vm_bo->obj,
> > - .map.gem.offset = op->map.bo_offset,
> > + .op.va.addr = op->va.addr,
> > + .op.va.range = op->va.range,
> > + .op.gem.obj = op->map.vm_bo->obj,
> > + .op.gem.offset = op->map.bo_offset,
> > };
> >
> > if (vm->unusable) {
> > diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
> > index f35d69c0b4c6..66b54b152446 100644
> > --- a/drivers/gpu/drm/xe/xe_vm.c
> > +++ b/drivers/gpu/drm/xe/xe_vm.c
> > @@ -2339,10 +2339,10 @@ vm_bind_ioctl_ops_create(struct xe_vm *vm, struct xe_vma_ops *vops,
> > case DRM_XE_VM_BIND_OP_MAP:
> > case DRM_XE_VM_BIND_OP_MAP_USERPTR: {
> > struct drm_gpuvm_map_req map_req = {
> > - .map.va.addr = addr,
> > - .map.va.range = range,
> > - .map.gem.obj = obj,
> > - .map.gem.offset = bo_offset_or_userptr,
> > + .op.va.addr = addr,
> > + .op.va.range = range,
> > + .op.gem.obj = obj,
> > + .op.gem.offset = bo_offset_or_userptr,
> > };
> >
> > ops = drm_gpuvm_sm_map_ops_create(&vm->gpuvm, &map_req);
> > diff --git a/include/drm/drm_gpuvm.h b/include/drm/drm_gpuvm.h
> > index 4a22b9d848f7..751c96a817ed 100644
> > --- a/include/drm/drm_gpuvm.h
> > +++ b/include/drm/drm_gpuvm.h
> > @@ -1054,9 +1054,9 @@ struct drm_gpuva_ops {
> > */
> > struct drm_gpuvm_map_req {
> > /**
> > - * @op_map: struct drm_gpuva_op_map
> > + * @op: struct drm_gpuva_op_map
> > */
> > - struct drm_gpuva_op_map map;
> > + struct drm_gpuva_op_map op;
On a second thought, I'm now wondering why we need drm_gpuvm_map_req in
the first place. It would kinda make sense if it was containing an
bool madvise;
field, so you don't have to pass it around, but even then, I'm
wondering if we wouldn't be better off adding this field to
drm_gpuva_op_map instead and passing an drm_gpuva_op_map object to
the various map helpers (like Danilo suggested in his review of the
REPEATED mode series Caterina sent).
> > };
> >
> > struct drm_gpuva_ops *
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/gpuvm: Rename 'map' to 'op' in drm_gpuvm_map_req
2025-08-21 11:01 ` Boris Brezillon
@ 2025-08-21 11:25 ` Boris Brezillon
2025-08-21 12:55 ` Danilo Krummrich
0 siblings, 1 reply; 17+ messages in thread
From: Boris Brezillon @ 2025-08-21 11:25 UTC (permalink / raw)
To: Himal Prasad Ghimiray
Cc: intel-xe, Boris Brezillon, Danilo Krummrich, Matt Coster,
Rob Clark, Matthew Brost, dri-devel
On Thu, 21 Aug 2025 13:01:46 +0200
Boris Brezillon <boris.brezillon@collabora.com> wrote:
> On Wed, 20 Aug 2025 18:07:42 +0200
> Boris Brezillon <boris.brezillon@collabora.com> wrote:
>
> > On Wed, 20 Aug 2025 20:53:35 +0530
> > Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com> wrote:
> >
> > > Renamed 'map' to 'op' in drm_gpuvm_map_req for clarity and added
> > > corresponding documentation. No functional changes introduced.
> > >
> > > Fixes: baf1638c0956 ("drm/gpuvm: Introduce drm_gpuvm_madvise_ops_create")
> > > Fixes: 000a45dce7ad ("drm/gpuvm: Pass map arguments through a struct")
> > > Suggested-by: Boris Brezillon <bbrezillon@kernel.org>
> > > Suggested-by: Danilo Krummrich <dakr@kernel.org>
> > > Cc: Danilo Krummrich <dakr@kernel.org>
> > > Cc: Matt Coster <matt.coster@imgtec.com>
> > > Cc: Boris Brezillon <bbrezillon@kernel.org>
> > > Cc: Rob Clark <robin.clark@oss.qualcomm.com>
> > > Cc: Matthew Brost <matthew.brost@intel.com>
> > > Cc: <dri-devel@lists.freedesktop.org>
> > > Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
> >
> > Acked-by: Boris Brezillon <boris.brezillon@collabora.com>
> >
> > > ---
> > > drivers/gpu/drm/drm_gpuvm.c | 36 +++++++++++++-------------
> > > drivers/gpu/drm/imagination/pvr_vm.c | 8 +++---
> > > drivers/gpu/drm/msm/msm_gem_vma.c | 16 ++++++------
> > > drivers/gpu/drm/nouveau/nouveau_uvmm.c | 8 +++---
> > > drivers/gpu/drm/panthor/panthor_mmu.c | 8 +++---
> > > drivers/gpu/drm/xe/xe_vm.c | 8 +++---
> > > include/drm/drm_gpuvm.h | 4 +--
> > > 7 files changed, 44 insertions(+), 44 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/drm_gpuvm.c b/drivers/gpu/drm/drm_gpuvm.c
> > > index 39f934a91a7b..e9aaf9b287e7 100644
> > > --- a/drivers/gpu/drm/drm_gpuvm.c
> > > +++ b/drivers/gpu/drm/drm_gpuvm.c
> > > @@ -552,11 +552,11 @@
> > > * struct drm_gem_object *obj, u64 offset)
> > > * {
> > > * struct drm_gpuvm_map_req map_req = {
> > > - * .map.va.addr = addr,
> > > - * .map.va.range = range,
> > > - * .map.gem.obj = obj,
> > > - * .map.gem.offset = offset,
> > > - * };
> > > + * .op.va.addr = addr,
> > > + * .op.va.range = range,
> > > + * .op.gem.obj = obj,
> > > + * .op.gem.offset = offset,
> > > + * };
> > > * struct drm_gpuva_ops *ops;
> > > * struct drm_gpuva_op *op
> > > * struct drm_gpuvm_bo *vm_bo;
> > > @@ -2132,10 +2132,10 @@ op_map_cb(const struct drm_gpuvm_ops *fn, void *priv,
> > > return 0;
> > >
> > > op.op = DRM_GPUVA_OP_MAP;
> > > - op.map.va.addr = req->map.va.addr;
> > > - op.map.va.range = req->map.va.range;
> > > - op.map.gem.obj = req->map.gem.obj;
> > > - op.map.gem.offset = req->map.gem.offset;
> > > + op.map.va.addr = req->op.va.addr;
> > > + op.map.va.range = req->op.va.range;
> > > + op.map.gem.obj = req->op.gem.obj;
> > > + op.map.gem.offset = req->op.gem.offset;
> > >
> > > return fn->sm_step_map(&op, priv);
> > > }
> > > @@ -2180,12 +2180,12 @@ __drm_gpuvm_sm_map(struct drm_gpuvm *gpuvm,
> > > const struct drm_gpuvm_map_req *req,
> > > bool madvise)
> > > {
> > > - struct drm_gem_object *req_obj = req->map.gem.obj;
> > > + struct drm_gem_object *req_obj = req->op.gem.obj;
> > > const struct drm_gpuvm_map_req *op_map = madvise ? NULL : req;
> > > struct drm_gpuva *va, *next;
> > > - u64 req_offset = req->map.gem.offset;
> > > - u64 req_range = req->map.va.range;
> > > - u64 req_addr = req->map.va.addr;
> > > + u64 req_offset = req->op.gem.offset;
> > > + u64 req_range = req->op.va.range;
> > > + u64 req_addr = req->op.va.addr;
> > > u64 req_end = req_addr + req_range;
> > > int ret;
> > >
> > > @@ -2272,8 +2272,8 @@ __drm_gpuvm_sm_map(struct drm_gpuvm *gpuvm,
> > >
> > > if (madvise) {
> > > struct drm_gpuvm_map_req map_req = {
> > > - .map.va.addr = req_addr,
> > > - .map.va.range = end - req_addr,
> > > + .op.va.addr = req_addr,
> > > + .op.va.range = end - req_addr,
> > > };
> > >
> > > ret = op_map_cb(ops, priv, &map_req);
> > > @@ -2340,8 +2340,8 @@ __drm_gpuvm_sm_map(struct drm_gpuvm *gpuvm,
> > >
> > > if (madvise) {
> > > struct drm_gpuvm_map_req map_req = {
> > > - .map.va.addr = addr,
> > > - .map.va.range = req_end - addr,
> > > + .op.va.addr = addr,
> > > + .op.va.range = req_end - addr,
> > > };
> > >
> > > return op_map_cb(ops, priv, &map_req);
> > > @@ -2583,7 +2583,7 @@ drm_gpuvm_sm_map_exec_lock(struct drm_gpuvm *gpuvm,
> > > struct drm_exec *exec, unsigned int num_fences,
> > > struct drm_gpuvm_map_req *req)
> > > {
> > > - struct drm_gem_object *req_obj = req->map.gem.obj;
> > > + struct drm_gem_object *req_obj = req->op.gem.obj;
> > >
> > > if (req_obj) {
> > > int ret = drm_exec_prepare_obj(exec, req_obj, num_fences);
> > > diff --git a/drivers/gpu/drm/imagination/pvr_vm.c b/drivers/gpu/drm/imagination/pvr_vm.c
> > > index 3d97990170bf..983165eb3e6a 100644
> > > --- a/drivers/gpu/drm/imagination/pvr_vm.c
> > > +++ b/drivers/gpu/drm/imagination/pvr_vm.c
> > > @@ -187,10 +187,10 @@ static int pvr_vm_bind_op_exec(struct pvr_vm_bind_op *bind_op)
> > > switch (bind_op->type) {
> > > case PVR_VM_BIND_TYPE_MAP: {
> > > const struct drm_gpuvm_map_req map_req = {
> > > - .map.va.addr = bind_op->device_addr,
> > > - .map.va.range = bind_op->size,
> > > - .map.gem.obj = gem_from_pvr_gem(bind_op->pvr_obj),
> > > - .map.gem.offset = bind_op->offset,
> > > + .op.va.addr = bind_op->device_addr,
> > > + .op.va.range = bind_op->size,
> > > + .op.gem.obj = gem_from_pvr_gem(bind_op->pvr_obj),
> > > + .op.gem.offset = bind_op->offset,
> > > };
> > >
> > > return drm_gpuvm_sm_map(&bind_op->vm_ctx->gpuvm_mgr,
> > > diff --git a/drivers/gpu/drm/msm/msm_gem_vma.c b/drivers/gpu/drm/msm/msm_gem_vma.c
> > > index 210604181c05..9b5d003bc5a2 100644
> > > --- a/drivers/gpu/drm/msm/msm_gem_vma.c
> > > +++ b/drivers/gpu/drm/msm/msm_gem_vma.c
> > > @@ -1179,10 +1179,10 @@ vm_bind_job_lock_objects(struct msm_vm_bind_job *job, struct drm_exec *exec)
> > > case MSM_VM_BIND_OP_MAP:
> > > case MSM_VM_BIND_OP_MAP_NULL: {
> > > struct drm_gpuvm_map_req map_req = {
> > > - .map.va.addr = op->iova,
> > > - .map.va.range = op->range,
> > > - .map.gem.obj = op->obj,
> > > - .map.gem.offset = op->obj_offset,
> > > + .op.va.addr = op->iova,
> > > + .op.va.range = op->range,
> > > + .op.gem.obj = op->obj,
> > > + .op.gem.offset = op->obj_offset,
> > > };
> > >
> > > ret = drm_gpuvm_sm_map_exec_lock(job->vm, exec, 1, &map_req);
> > > @@ -1296,10 +1296,10 @@ vm_bind_job_prepare(struct msm_vm_bind_job *job)
> > > fallthrough;
> > > case MSM_VM_BIND_OP_MAP_NULL: {
> > > struct drm_gpuvm_map_req map_req = {
> > > - .map.va.addr = op->iova,
> > > - .map.va.range = op->range,
> > > - .map.gem.obj = op->obj,
> > > - .map.gem.offset = op->obj_offset,
> > > + .op.va.addr = op->iova,
> > > + .op.va.range = op->range,
> > > + .op.gem.obj = op->obj,
> > > + .op.gem.offset = op->obj_offset,
> > > };
> > >
> > > ret = drm_gpuvm_sm_map(job->vm, &arg, &map_req);
> > > diff --git a/drivers/gpu/drm/nouveau/nouveau_uvmm.c b/drivers/gpu/drm/nouveau/nouveau_uvmm.c
> > > index d94a85509176..314121a857e7 100644
> > > --- a/drivers/gpu/drm/nouveau/nouveau_uvmm.c
> > > +++ b/drivers/gpu/drm/nouveau/nouveau_uvmm.c
> > > @@ -1277,10 +1277,10 @@ nouveau_uvmm_bind_job_submit(struct nouveau_job *job,
> > > case OP_MAP: {
> > > struct nouveau_uvma_region *reg;
> > > struct drm_gpuvm_map_req map_req = {
> > > - .map.va.addr = op->va.addr,
> > > - .map.va.range = op->va.range,
> > > - .map.gem.obj = op->gem.obj,
> > > - .map.gem.offset = op->gem.offset,
> > > + .op.va.addr = op->va.addr,
> > > + .op.va.range = op->va.range,
> > > + .op.gem.obj = op->gem.obj,
> > > + .op.gem.offset = op->gem.offset,
> > > };
> > >
> > > reg = nouveau_uvma_region_find_first(uvmm,
> > > diff --git a/drivers/gpu/drm/panthor/panthor_mmu.c b/drivers/gpu/drm/panthor/panthor_mmu.c
> > > index 2003b91a8409..3799e2c6ea59 100644
> > > --- a/drivers/gpu/drm/panthor/panthor_mmu.c
> > > +++ b/drivers/gpu/drm/panthor/panthor_mmu.c
> > > @@ -2204,10 +2204,10 @@ panthor_vm_exec_op(struct panthor_vm *vm, struct panthor_vm_op_ctx *op,
> > > switch (op_type) {
> > > case DRM_PANTHOR_VM_BIND_OP_TYPE_MAP: {
> > > const struct drm_gpuvm_map_req map_req = {
> > > - .map.va.addr = op->va.addr,
> > > - .map.va.range = op->va.range,
> > > - .map.gem.obj = op->map.vm_bo->obj,
> > > - .map.gem.offset = op->map.bo_offset,
> > > + .op.va.addr = op->va.addr,
> > > + .op.va.range = op->va.range,
> > > + .op.gem.obj = op->map.vm_bo->obj,
> > > + .op.gem.offset = op->map.bo_offset,
> > > };
> > >
> > > if (vm->unusable) {
> > > diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
> > > index f35d69c0b4c6..66b54b152446 100644
> > > --- a/drivers/gpu/drm/xe/xe_vm.c
> > > +++ b/drivers/gpu/drm/xe/xe_vm.c
> > > @@ -2339,10 +2339,10 @@ vm_bind_ioctl_ops_create(struct xe_vm *vm, struct xe_vma_ops *vops,
> > > case DRM_XE_VM_BIND_OP_MAP:
> > > case DRM_XE_VM_BIND_OP_MAP_USERPTR: {
> > > struct drm_gpuvm_map_req map_req = {
> > > - .map.va.addr = addr,
> > > - .map.va.range = range,
> > > - .map.gem.obj = obj,
> > > - .map.gem.offset = bo_offset_or_userptr,
> > > + .op.va.addr = addr,
> > > + .op.va.range = range,
> > > + .op.gem.obj = obj,
> > > + .op.gem.offset = bo_offset_or_userptr,
> > > };
> > >
> > > ops = drm_gpuvm_sm_map_ops_create(&vm->gpuvm, &map_req);
> > > diff --git a/include/drm/drm_gpuvm.h b/include/drm/drm_gpuvm.h
> > > index 4a22b9d848f7..751c96a817ed 100644
> > > --- a/include/drm/drm_gpuvm.h
> > > +++ b/include/drm/drm_gpuvm.h
> > > @@ -1054,9 +1054,9 @@ struct drm_gpuva_ops {
> > > */
> > > struct drm_gpuvm_map_req {
> > > /**
> > > - * @op_map: struct drm_gpuva_op_map
> > > + * @op: struct drm_gpuva_op_map
> > > */
> > > - struct drm_gpuva_op_map map;
> > > + struct drm_gpuva_op_map op;
>
> On a second thought, I'm now wondering why we need drm_gpuvm_map_req in
> the first place. It would kinda make sense if it was containing an
>
> bool madvise;
>
> field, so you don't have to pass it around, but even then, I'm
> wondering if we wouldn't be better off adding this field to
> drm_gpuva_op_map instead and passing an drm_gpuva_op_map object to
> the various map helpers (like Danilo suggested in his review of the
> REPEATED mode series Caterina sent).
More on that: the very reason I introduced drm_gpuvm_map_req in the
first place is so we have a clear differentiation between an overall
map request and the sub-operations that are created to fulfill it.
Looks like this was not a concern for Danilo and he was happy with us
using _op_map for this.
The other reason we might want to add drm_gpuvm_map_req is so that
information we only need while splitting a req don't pollute
drm_gpuva_op_map. Given I was going to pass the flags to the driver's
callback anyway (meaning it's needed at the op_map level), and given
you're passing madvise as a separate bool argument to various helpers
(_map_req just contains the op, not the madvise bool), I don't think
this aspect matters.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/gpuvm: Rename 'map' to 'op' in drm_gpuvm_map_req
2025-08-21 11:25 ` Boris Brezillon
@ 2025-08-21 12:55 ` Danilo Krummrich
2025-08-21 13:01 ` Boris Brezillon
0 siblings, 1 reply; 17+ messages in thread
From: Danilo Krummrich @ 2025-08-21 12:55 UTC (permalink / raw)
To: Boris Brezillon
Cc: Himal Prasad Ghimiray, intel-xe, Boris Brezillon, Matt Coster,
Rob Clark, Matthew Brost, dri-devel
On Thu Aug 21, 2025 at 1:25 PM CEST, Boris Brezillon wrote:
> On Thu, 21 Aug 2025 13:01:46 +0200
> Boris Brezillon <boris.brezillon@collabora.com> wrote:
>> On a second thought, I'm now wondering why we need drm_gpuvm_map_req in
>> the first place. It would kinda make sense if it was containing an
>>
>> bool madvise;
>>
>> field, so you don't have to pass it around, but even then, I'm
>> wondering if we wouldn't be better off adding this field to
>> drm_gpuva_op_map instead and passing an drm_gpuva_op_map object to
>> the various map helpers (like Danilo suggested in his review of the
>> REPEATED mode series Caterina sent).
>
> More on that: the very reason I introduced drm_gpuvm_map_req in the
> first place is so we have a clear differentiation between an overall
> map request and the sub-operations that are created to fulfill it.
> Looks like this was not a concern for Danilo and he was happy with us
> using _op_map for this.
>
> The other reason we might want to add drm_gpuvm_map_req is so that
> information we only need while splitting a req don't pollute
> drm_gpuva_op_map. Given I was going to pass the flags to the driver's
> callback anyway (meaning it's needed at the op_map level), and given
> you're passing madvise as a separate bool argument to various helpers
> (_map_req just contains the op, not the madvise bool), I don't think
> this aspect matters.
Good catch! Indeed, when Himal picked up your struct drm_gpuvm_map_req patch,
there were additional flags included in the structure. Now that it is
essentially a transparent wrapper, I prefer to use struct drm_gpuva_op_map
directly.
However, given that you still have patches in flight that will add a flags field
to struct drm_gpuvm_map_req I think it's probably fine to introduce it right
away. Or did you drop this plan of adding those flags?
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/gpuvm: Rename 'map' to 'op' in drm_gpuvm_map_req
2025-08-21 12:55 ` Danilo Krummrich
@ 2025-08-21 13:01 ` Boris Brezillon
2025-08-21 13:30 ` Ghimiray, Himal Prasad
2025-08-21 13:35 ` Danilo Krummrich
0 siblings, 2 replies; 17+ messages in thread
From: Boris Brezillon @ 2025-08-21 13:01 UTC (permalink / raw)
To: Danilo Krummrich
Cc: Himal Prasad Ghimiray, intel-xe, Boris Brezillon, Matt Coster,
Rob Clark, Matthew Brost, dri-devel
On Thu, 21 Aug 2025 14:55:06 +0200
"Danilo Krummrich" <dakr@kernel.org> wrote:
> On Thu Aug 21, 2025 at 1:25 PM CEST, Boris Brezillon wrote:
> > On Thu, 21 Aug 2025 13:01:46 +0200
> > Boris Brezillon <boris.brezillon@collabora.com> wrote:
> >> On a second thought, I'm now wondering why we need drm_gpuvm_map_req in
> >> the first place. It would kinda make sense if it was containing an
> >>
> >> bool madvise;
> >>
> >> field, so you don't have to pass it around, but even then, I'm
> >> wondering if we wouldn't be better off adding this field to
> >> drm_gpuva_op_map instead and passing an drm_gpuva_op_map object to
> >> the various map helpers (like Danilo suggested in his review of the
> >> REPEATED mode series Caterina sent).
> >
> > More on that: the very reason I introduced drm_gpuvm_map_req in the
> > first place is so we have a clear differentiation between an overall
> > map request and the sub-operations that are created to fulfill it.
> > Looks like this was not a concern for Danilo and he was happy with us
> > using _op_map for this.
> >
> > The other reason we might want to add drm_gpuvm_map_req is so that
> > information we only need while splitting a req don't pollute
> > drm_gpuva_op_map. Given I was going to pass the flags to the driver's
> > callback anyway (meaning it's needed at the op_map level), and given
> > you're passing madvise as a separate bool argument to various helpers
> > (_map_req just contains the op, not the madvise bool), I don't think
> > this aspect matters.
>
> Good catch! Indeed, when Himal picked up your struct drm_gpuvm_map_req patch,
> there were additional flags included in the structure. Now that it is
> essentially a transparent wrapper, I prefer to use struct drm_gpuva_op_map
> directly.
>
> However, given that you still have patches in flight that will add a flags field
> to struct drm_gpuvm_map_req I think it's probably fine to introduce it right
> away. Or did you drop this plan of adding those flags?
I need the flags field in the op_map too (so I can propagate it to the
drm_gpuva object), so I'd rather go with an op_map object directly and
kill drm_gpuvm_map_req now.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/gpuvm: Rename 'map' to 'op' in drm_gpuvm_map_req
2025-08-21 13:01 ` Boris Brezillon
@ 2025-08-21 13:30 ` Ghimiray, Himal Prasad
2025-08-21 13:35 ` Danilo Krummrich
1 sibling, 0 replies; 17+ messages in thread
From: Ghimiray, Himal Prasad @ 2025-08-21 13:30 UTC (permalink / raw)
To: Boris Brezillon, Danilo Krummrich
Cc: intel-xe, Boris Brezillon, Matt Coster, Rob Clark, Matthew Brost,
dri-devel
On 21-08-2025 18:31, Boris Brezillon wrote:
> On Thu, 21 Aug 2025 14:55:06 +0200
> "Danilo Krummrich" <dakr@kernel.org> wrote:
>
>> On Thu Aug 21, 2025 at 1:25 PM CEST, Boris Brezillon wrote:
>>> On Thu, 21 Aug 2025 13:01:46 +0200
>>> Boris Brezillon <boris.brezillon@collabora.com> wrote:
>>>> On a second thought, I'm now wondering why we need drm_gpuvm_map_req in
>>>> the first place. It would kinda make sense if it was containing an
>>>>
>>>> bool madvise;
>>>>
>>>> field, so you don't have to pass it around, but even then, I'm
>>>> wondering if we wouldn't be better off adding this field to
>>>> drm_gpuva_op_map instead and passing an drm_gpuva_op_map object to
>>>> the various map helpers (like Danilo suggested in his review of the
>>>> REPEATED mode series Caterina sent).
>>>
>>> More on that: the very reason I introduced drm_gpuvm_map_req in the
>>> first place is so we have a clear differentiation between an overall
>>> map request and the sub-operations that are created to fulfill it.
>>> Looks like this was not a concern for Danilo and he was happy with us
>>> using _op_map for this.
>>>
>>> The other reason we might want to add drm_gpuvm_map_req is so that
>>> information we only need while splitting a req don't pollute
>>> drm_gpuva_op_map. Given I was going to pass the flags to the driver's
>>> callback anyway (meaning it's needed at the op_map level), and given
>>> you're passing madvise as a separate bool argument to various helpers
>>> (_map_req just contains the op, not the madvise bool), I don't think
>>> this aspect matters.
>>
>> Good catch! Indeed, when Himal picked up your struct drm_gpuvm_map_req patch,
>> there were additional flags included in the structure. Now that it is
>> essentially a transparent wrapper, I prefer to use struct drm_gpuva_op_map
>> directly.
>>
>> However, given that you still have patches in flight that will add a flags field
>> to struct drm_gpuvm_map_req I think it's probably fine to introduce it right
>> away. Or did you drop this plan of adding those flags?
>
> I need the flags field in the op_map too (so I can propagate it to the
> drm_gpuva object), so I'd rather go with an op_map object directly and
> kill drm_gpuvm_map_req now.
Thanks, Boris, for your comments, and Danilo for joining the discussion.
The patch I built upon is this version, where I dropped
drm_gpuvm_map_req and opted to use drm_gpuva_op_map directly.[1]
As I understand it, the initial recommendation was to introduce
drm_gpuvm_map_req with a flag to control the split/merge logic in
gpuvm_layer. However, with the introduction of madvise, we eventually
decided to proceed with a separate API, so the flag wasn’t added.
If needed, drm_gpuva_op_map can still introduce a flag for
driver-specific use cases.
If we’re confident that the flags in drm_gpuvm_map_req and
drm_gpuva_op_map will always align, I’m okay with dropping map_req.
Until we reach a final decision, I’ll hold off on submitting this patch.
[1] https://patchwork.freedesktop.org/patch/666205/?series=149550&rev=5
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/gpuvm: Rename 'map' to 'op' in drm_gpuvm_map_req
2025-08-21 13:01 ` Boris Brezillon
2025-08-21 13:30 ` Ghimiray, Himal Prasad
@ 2025-08-21 13:35 ` Danilo Krummrich
2025-08-21 16:55 ` Ghimiray, Himal Prasad
1 sibling, 1 reply; 17+ messages in thread
From: Danilo Krummrich @ 2025-08-21 13:35 UTC (permalink / raw)
To: Boris Brezillon
Cc: Himal Prasad Ghimiray, intel-xe, Boris Brezillon, Matt Coster,
Rob Clark, Matthew Brost, dri-devel
On Thu Aug 21, 2025 at 3:01 PM CEST, Boris Brezillon wrote:
> On Thu, 21 Aug 2025 14:55:06 +0200
> "Danilo Krummrich" <dakr@kernel.org> wrote:
>
>> On Thu Aug 21, 2025 at 1:25 PM CEST, Boris Brezillon wrote:
>> > On Thu, 21 Aug 2025 13:01:46 +0200
>> > Boris Brezillon <boris.brezillon@collabora.com> wrote:
>> >> On a second thought, I'm now wondering why we need drm_gpuvm_map_req in
>> >> the first place. It would kinda make sense if it was containing an
>> >>
>> >> bool madvise;
>> >>
>> >> field, so you don't have to pass it around, but even then, I'm
>> >> wondering if we wouldn't be better off adding this field to
>> >> drm_gpuva_op_map instead and passing an drm_gpuva_op_map object to
>> >> the various map helpers (like Danilo suggested in his review of the
>> >> REPEATED mode series Caterina sent).
>> >
>> > More on that: the very reason I introduced drm_gpuvm_map_req in the
>> > first place is so we have a clear differentiation between an overall
>> > map request and the sub-operations that are created to fulfill it.
>> > Looks like this was not a concern for Danilo and he was happy with us
>> > using _op_map for this.
>> >
>> > The other reason we might want to add drm_gpuvm_map_req is so that
>> > information we only need while splitting a req don't pollute
>> > drm_gpuva_op_map. Given I was going to pass the flags to the driver's
>> > callback anyway (meaning it's needed at the op_map level), and given
>> > you're passing madvise as a separate bool argument to various helpers
>> > (_map_req just contains the op, not the madvise bool), I don't think
>> > this aspect matters.
>>
>> Good catch! Indeed, when Himal picked up your struct drm_gpuvm_map_req patch,
>> there were additional flags included in the structure. Now that it is
>> essentially a transparent wrapper, I prefer to use struct drm_gpuva_op_map
>> directly.
>>
>> However, given that you still have patches in flight that will add a flags field
>> to struct drm_gpuvm_map_req I think it's probably fine to introduce it right
>> away. Or did you drop this plan of adding those flags?
>
> I need the flags field in the op_map too (so I can propagate it to the
> drm_gpuva object), so I'd rather go with an op_map object directly and
> kill drm_gpuvm_map_req now.
In this case I agree, let's use struct drm_gpuva_op_map directly.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/gpuvm: Rename 'map' to 'op' in drm_gpuvm_map_req
2025-08-21 13:35 ` Danilo Krummrich
@ 2025-08-21 16:55 ` Ghimiray, Himal Prasad
2025-08-22 7:35 ` Boris Brezillon
0 siblings, 1 reply; 17+ messages in thread
From: Ghimiray, Himal Prasad @ 2025-08-21 16:55 UTC (permalink / raw)
To: Danilo Krummrich, Boris Brezillon
Cc: intel-xe, Boris Brezillon, Matt Coster, Rob Clark, Matthew Brost,
dri-devel
On 21-08-2025 19:05, Danilo Krummrich wrote:
> On Thu Aug 21, 2025 at 3:01 PM CEST, Boris Brezillon wrote:
>> On Thu, 21 Aug 2025 14:55:06 +0200
>> "Danilo Krummrich" <dakr@kernel.org> wrote:
>>
>>> On Thu Aug 21, 2025 at 1:25 PM CEST, Boris Brezillon wrote:
>>>> On Thu, 21 Aug 2025 13:01:46 +0200
>>>> Boris Brezillon <boris.brezillon@collabora.com> wrote:
>>>>> On a second thought, I'm now wondering why we need drm_gpuvm_map_req in
>>>>> the first place. It would kinda make sense if it was containing an
>>>>>
>>>>> bool madvise;
>>>>>
>>>>> field, so you don't have to pass it around, but even then, I'm
>>>>> wondering if we wouldn't be better off adding this field to
>>>>> drm_gpuva_op_map instead and passing an drm_gpuva_op_map object to
>>>>> the various map helpers (like Danilo suggested in his review of the
>>>>> REPEATED mode series Caterina sent).
>>>>
>>>> More on that: the very reason I introduced drm_gpuvm_map_req in the
>>>> first place is so we have a clear differentiation between an overall
>>>> map request and the sub-operations that are created to fulfill it.
>>>> Looks like this was not a concern for Danilo and he was happy with us
>>>> using _op_map for this.
>>>>
>>>> The other reason we might want to add drm_gpuvm_map_req is so that
>>>> information we only need while splitting a req don't pollute
>>>> drm_gpuva_op_map. Given I was going to pass the flags to the driver's
>>>> callback anyway (meaning it's needed at the op_map level), and given
>>>> you're passing madvise as a separate bool argument to various helpers
>>>> (_map_req just contains the op, not the madvise bool), I don't think
>>>> this aspect matters.
>>>
>>> Good catch! Indeed, when Himal picked up your struct drm_gpuvm_map_req patch,
>>> there were additional flags included in the structure. Now that it is
>>> essentially a transparent wrapper, I prefer to use struct drm_gpuva_op_map
>>> directly.
>>>
>>> However, given that you still have patches in flight that will add a flags field
>>> to struct drm_gpuvm_map_req I think it's probably fine to introduce it right
>>> away. Or did you drop this plan of adding those flags?
>>
>> I need the flags field in the op_map too (so I can propagate it to the
>> drm_gpuva object), so I'd rather go with an op_map object directly and
>> kill drm_gpuvm_map_req now.
>
> In this case I agree, let's use struct drm_gpuva_op_map directly.
According to the kernel documentation for the drm_gpuva_op_map
structure, it is intended to represent a single map operation generated
as the output of ops_create or the GPU VA manager. Using it as a direct
input to ops_create contradicts this definition.
For drm_gpuvm_sm_map_ops_create, the values align with those in
drm_gpuvm_map_req. However, this is not the case for
drm_gpuvm_madvise_ops_create.
If we plan to proceed with deprecating drm_gpuvm_map_req, we need to
clarify the fundamental definition of drm_gpuva_op_map:
Should it represent a user-requested map, or an operation generated by
the GPU VA manager?
^ permalink raw reply [flat|nested] 17+ messages in thread
* ✗ Xe.CI.Full: failure for drm/gpuvm: Rename 'map' to 'op' in drm_gpuvm_map_req
2025-08-20 15:23 [PATCH] drm/gpuvm: Rename 'map' to 'op' in drm_gpuvm_map_req Himal Prasad Ghimiray
` (5 preceding siblings ...)
2025-08-20 21:19 ` ✓ Xe.CI.BAT: " Patchwork
@ 2025-08-21 20:15 ` Patchwork
6 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2025-08-21 20:15 UTC (permalink / raw)
To: Himal Prasad Ghimiray; +Cc: intel-xe
[-- Attachment #1: Type: text/plain, Size: 37177 bytes --]
== Series Details ==
Series: drm/gpuvm: Rename 'map' to 'op' in drm_gpuvm_map_req
URL : https://patchwork.freedesktop.org/series/153233/
State : failure
== Summary ==
CI Bug Log - changes from xe-3588-67f294a52e4b22d1b5bb86dd5dd3ac33e640717a_FULL -> xe-pw-153233v1_FULL
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with xe-pw-153233v1_FULL absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in xe-pw-153233v1_FULL, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (4 -> 4)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in xe-pw-153233v1_FULL:
### IGT changes ###
#### Possible regressions ####
* igt@xe_exec_balancer@many-execqueues-cm-virtual-rebind:
- shard-bmg: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3588-67f294a52e4b22d1b5bb86dd5dd3ac33e640717a/shard-bmg-8/igt@xe_exec_balancer@many-execqueues-cm-virtual-rebind.html
[2]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-bmg-6/igt@xe_exec_balancer@many-execqueues-cm-virtual-rebind.html
* igt@xe_exec_system_allocator@many-stride-new:
- shard-lnl: [PASS][3] -> [INCOMPLETE][4]
[3]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3588-67f294a52e4b22d1b5bb86dd5dd3ac33e640717a/shard-lnl-4/igt@xe_exec_system_allocator@many-stride-new.html
[4]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-lnl-5/igt@xe_exec_system_allocator@many-stride-new.html
Known issues
------------
Here are the changes found in xe-pw-153233v1_FULL that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_async_flips@invalid-async-flip-atomic:
- shard-dg2-set2: NOTRUN -> [SKIP][5] ([Intel XE#3768])
[5]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-dg2-433/igt@kms_async_flips@invalid-async-flip-atomic.html
* igt@kms_atomic_transition@plane-all-modeset-transition-fencing-internal-panels:
- shard-dg2-set2: NOTRUN -> [SKIP][6] ([Intel XE#455])
[6]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-dg2-434/igt@kms_atomic_transition@plane-all-modeset-transition-fencing-internal-panels.html
* igt@kms_big_fb@x-tiled-32bpp-rotate-90:
- shard-dg2-set2: NOTRUN -> [SKIP][7] ([Intel XE#316])
[7]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-dg2-433/igt@kms_big_fb@x-tiled-32bpp-rotate-90.html
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0:
- shard-adlp: [PASS][8] -> [DMESG-WARN][9] ([Intel XE#2953] / [Intel XE#4173]) +2 other tests dmesg-warn
[8]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3588-67f294a52e4b22d1b5bb86dd5dd3ac33e640717a/shard-adlp-4/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0.html
[9]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-adlp-4/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0:
- shard-dg2-set2: NOTRUN -> [SKIP][10] ([Intel XE#1124])
[10]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-dg2-433/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0.html
* igt@kms_bw@linear-tiling-1-displays-2160x1440p:
- shard-dg2-set2: NOTRUN -> [SKIP][11] ([Intel XE#367])
[11]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-dg2-434/igt@kms_bw@linear-tiling-1-displays-2160x1440p.html
* igt@kms_ccs@bad-aux-stride-y-tiled-gen12-rc-ccs-cc:
- shard-bmg: NOTRUN -> [SKIP][12] ([Intel XE#2887])
[12]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-bmg-6/igt@kms_ccs@bad-aux-stride-y-tiled-gen12-rc-ccs-cc.html
* igt@kms_ccs@ccs-on-another-bo-y-tiled-gen12-rc-ccs-cc@pipe-d-dp-4:
- shard-dg2-set2: NOTRUN -> [SKIP][13] ([Intel XE#455] / [Intel XE#787]) +20 other tests skip
[13]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-dg2-436/igt@kms_ccs@ccs-on-another-bo-y-tiled-gen12-rc-ccs-cc@pipe-d-dp-4.html
* igt@kms_ccs@crc-primary-basic-4-tiled-mtl-rc-ccs@pipe-b-hdmi-a-6:
- shard-dg2-set2: NOTRUN -> [SKIP][14] ([Intel XE#787]) +139 other tests skip
[14]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-dg2-466/igt@kms_ccs@crc-primary-basic-4-tiled-mtl-rc-ccs@pipe-b-hdmi-a-6.html
* igt@kms_ccs@crc-primary-rotation-180-4-tiled-lnl-ccs@pipe-b-dp-2:
- shard-bmg: NOTRUN -> [SKIP][15] ([Intel XE#2652] / [Intel XE#787]) +3 other tests skip
[15]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-bmg-8/igt@kms_ccs@crc-primary-rotation-180-4-tiled-lnl-ccs@pipe-b-dp-2.html
* igt@kms_ccs@random-ccs-data-4-tiled-dg2-mc-ccs@pipe-a-hdmi-a-6:
- shard-dg2-set2: [PASS][16] -> [INCOMPLETE][17] ([Intel XE#1727] / [Intel XE#3113]) +1 other test incomplete
[16]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3588-67f294a52e4b22d1b5bb86dd5dd3ac33e640717a/shard-dg2-434/igt@kms_ccs@random-ccs-data-4-tiled-dg2-mc-ccs@pipe-a-hdmi-a-6.html
[17]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-dg2-464/igt@kms_ccs@random-ccs-data-4-tiled-dg2-mc-ccs@pipe-a-hdmi-a-6.html
* igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs:
- shard-dg2-set2: [PASS][18] -> [INCOMPLETE][19] ([Intel XE#1727] / [Intel XE#3113] / [Intel XE#3124] / [Intel XE#4345])
[18]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3588-67f294a52e4b22d1b5bb86dd5dd3ac33e640717a/shard-dg2-432/igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs.html
[19]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-dg2-466/igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs.html
* igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs@pipe-d-dp-4:
- shard-dg2-set2: NOTRUN -> [INCOMPLETE][20] ([Intel XE#3124])
[20]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-dg2-466/igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs@pipe-d-dp-4.html
* igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs@pipe-d-hdmi-a-6:
- shard-dg2-set2: NOTRUN -> [DMESG-WARN][21] ([Intel XE#1727] / [Intel XE#3113])
[21]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-dg2-466/igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs@pipe-d-hdmi-a-6.html
* igt@kms_ccs@random-ccs-data-4-tiled-lnl-ccs:
- shard-dg2-set2: NOTRUN -> [SKIP][22] ([Intel XE#2907])
[22]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-dg2-434/igt@kms_ccs@random-ccs-data-4-tiled-lnl-ccs.html
* igt@kms_chamelium_color@ctm-0-50:
- shard-dg2-set2: NOTRUN -> [SKIP][23] ([Intel XE#306])
[23]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-dg2-433/igt@kms_chamelium_color@ctm-0-50.html
* igt@kms_chamelium_frames@hdmi-crc-nonplanar-formats:
- shard-dg2-set2: NOTRUN -> [SKIP][24] ([Intel XE#373]) +2 other tests skip
[24]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-dg2-434/igt@kms_chamelium_frames@hdmi-crc-nonplanar-formats.html
* igt@kms_content_protection@atomic-dpms@pipe-a-dp-2:
- shard-dg2-set2: NOTRUN -> [FAIL][25] ([Intel XE#1178]) +2 other tests fail
[25]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-dg2-432/igt@kms_content_protection@atomic-dpms@pipe-a-dp-2.html
* igt@kms_content_protection@dp-mst-lic-type-1:
- shard-dg2-set2: NOTRUN -> [SKIP][26] ([Intel XE#307])
[26]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-dg2-434/igt@kms_content_protection@dp-mst-lic-type-1.html
* igt@kms_content_protection@lic-type-0@pipe-a-dp-4:
- shard-dg2-set2: NOTRUN -> [FAIL][27] ([Intel XE#3304])
[27]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-dg2-433/igt@kms_content_protection@lic-type-0@pipe-a-dp-4.html
* igt@kms_content_protection@uevent@pipe-a-dp-2:
- shard-bmg: NOTRUN -> [FAIL][28] ([Intel XE#1188])
[28]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-bmg-4/igt@kms_content_protection@uevent@pipe-a-dp-2.html
* igt@kms_cursor_crc@cursor-onscreen-512x170:
- shard-bmg: NOTRUN -> [SKIP][29] ([Intel XE#2321])
[29]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-bmg-6/igt@kms_cursor_crc@cursor-onscreen-512x170.html
* igt@kms_cursor_crc@cursor-random-512x170:
- shard-dg2-set2: NOTRUN -> [SKIP][30] ([Intel XE#308])
[30]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-dg2-433/igt@kms_cursor_crc@cursor-random-512x170.html
* igt@kms_cursor_legacy@2x-cursor-vs-flip-atomic:
- shard-bmg: [PASS][31] -> [SKIP][32] ([Intel XE#2291]) +1 other test skip
[31]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3588-67f294a52e4b22d1b5bb86dd5dd3ac33e640717a/shard-bmg-8/igt@kms_cursor_legacy@2x-cursor-vs-flip-atomic.html
[32]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-bmg-6/igt@kms_cursor_legacy@2x-cursor-vs-flip-atomic.html
* igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions-varying-size:
- shard-dg2-set2: NOTRUN -> [SKIP][33] ([Intel XE#323]) +1 other test skip
[33]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-dg2-433/igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions-varying-size.html
* igt@kms_flip@2x-plain-flip-fb-recreate-interruptible:
- shard-bmg: [PASS][34] -> [SKIP][35] ([Intel XE#2316]) +4 other tests skip
[34]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3588-67f294a52e4b22d1b5bb86dd5dd3ac33e640717a/shard-bmg-8/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible.html
[35]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-bmg-6/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible.html
* igt@kms_flip@basic-flip-vs-wf_vblank:
- shard-adlp: [PASS][36] -> [DMESG-WARN][37] ([Intel XE#4543]) +2 other tests dmesg-warn
[36]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3588-67f294a52e4b22d1b5bb86dd5dd3ac33e640717a/shard-adlp-3/igt@kms_flip@basic-flip-vs-wf_vblank.html
[37]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-adlp-2/igt@kms_flip@basic-flip-vs-wf_vblank.html
* igt@kms_flip_tiling@flip-change-tiling@pipe-c-hdmi-a-1-x-to-y:
- shard-adlp: [PASS][38] -> [DMESG-FAIL][39] ([Intel XE#4543])
[38]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3588-67f294a52e4b22d1b5bb86dd5dd3ac33e640717a/shard-adlp-2/igt@kms_flip_tiling@flip-change-tiling@pipe-c-hdmi-a-1-x-to-y.html
[39]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-adlp-9/igt@kms_flip_tiling@flip-change-tiling@pipe-c-hdmi-a-1-x-to-y.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt:
- shard-bmg: NOTRUN -> [SKIP][40] ([Intel XE#5390]) +1 other test skip
[40]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-bmg-6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt.html
* igt@kms_frontbuffer_tracking@fbcdrrs-2p-primscrn-pri-shrfb-draw-mmap-wc:
- shard-bmg: NOTRUN -> [SKIP][41] ([Intel XE#2312]) +1 other test skip
[41]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-bmg-6/igt@kms_frontbuffer_tracking@fbcdrrs-2p-primscrn-pri-shrfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbcdrrs-2p-primscrn-pri-shrfb-draw-render:
- shard-dg2-set2: NOTRUN -> [SKIP][42] ([Intel XE#651]) +6 other tests skip
[42]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-dg2-433/igt@kms_frontbuffer_tracking@fbcdrrs-2p-primscrn-pri-shrfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbcdrrs-rgb101010-draw-render:
- shard-bmg: NOTRUN -> [SKIP][43] ([Intel XE#2311])
[43]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-bmg-6/igt@kms_frontbuffer_tracking@fbcdrrs-rgb101010-draw-render.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-mmap-wc:
- shard-dg2-set2: NOTRUN -> [SKIP][44] ([Intel XE#653]) +7 other tests skip
[44]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-dg2-434/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-mmap-wc.html
* igt@kms_plane_cursor@primary:
- shard-dg2-set2: NOTRUN -> [FAIL][45] ([Intel XE#616])
[45]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-dg2-433/igt@kms_plane_cursor@primary.html
* igt@kms_psr2_sf@pr-overlay-primary-update-sf-dmg-area:
- shard-dg2-set2: NOTRUN -> [SKIP][46] ([Intel XE#1489] / [Intel XE#5899])
[46]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-dg2-433/igt@kms_psr2_sf@pr-overlay-primary-update-sf-dmg-area.html
* igt@kms_psr@fbc-pr-basic:
- shard-bmg: NOTRUN -> [SKIP][47] ([Intel XE#2234] / [Intel XE#2850] / [Intel XE#5899]) +1 other test skip
[47]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-bmg-6/igt@kms_psr@fbc-pr-basic.html
* igt@kms_psr@psr-cursor-plane-onoff:
- shard-dg2-set2: NOTRUN -> [SKIP][48] ([Intel XE#2850] / [Intel XE#5899] / [Intel XE#929]) +1 other test skip
[48]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-dg2-433/igt@kms_psr@psr-cursor-plane-onoff.html
* igt@kms_rotation_crc@primary-y-tiled-reflect-x-180:
- shard-dg2-set2: NOTRUN -> [SKIP][49] ([Intel XE#1127]) +1 other test skip
[49]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-dg2-433/igt@kms_rotation_crc@primary-y-tiled-reflect-x-180.html
* igt@kms_setmode@invalid-clone-single-crtc:
- shard-bmg: [PASS][50] -> [SKIP][51] ([Intel XE#1435])
[50]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3588-67f294a52e4b22d1b5bb86dd5dd3ac33e640717a/shard-bmg-8/igt@kms_setmode@invalid-clone-single-crtc.html
[51]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-bmg-6/igt@kms_setmode@invalid-clone-single-crtc.html
* igt@xe_eudebug@basic-close:
- shard-dg2-set2: NOTRUN -> [SKIP][52] ([Intel XE#4837]) +3 other tests skip
[52]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-dg2-433/igt@xe_eudebug@basic-close.html
* igt@xe_exec_basic@multigpu-no-exec-bindexecqueue:
- shard-bmg: NOTRUN -> [SKIP][53] ([Intel XE#2322])
[53]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-bmg-6/igt@xe_exec_basic@multigpu-no-exec-bindexecqueue.html
* igt@xe_exec_basic@multigpu-once-bindexecqueue-userptr-invalidate:
- shard-dg2-set2: [PASS][54] -> [SKIP][55] ([Intel XE#1392]) +7 other tests skip
[54]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3588-67f294a52e4b22d1b5bb86dd5dd3ac33e640717a/shard-dg2-463/igt@xe_exec_basic@multigpu-once-bindexecqueue-userptr-invalidate.html
[55]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-dg2-432/igt@xe_exec_basic@multigpu-once-bindexecqueue-userptr-invalidate.html
* igt@xe_exec_fault_mode@many-execqueues-userptr-invalidate-prefetch:
- shard-dg2-set2: NOTRUN -> [SKIP][56] ([Intel XE#288]) +3 other tests skip
[56]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-dg2-433/igt@xe_exec_fault_mode@many-execqueues-userptr-invalidate-prefetch.html
* igt@xe_exec_system_allocator@process-many-large-mmap-huge-nomemset:
- shard-bmg: NOTRUN -> [SKIP][57] ([Intel XE#4943])
[57]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-bmg-6/igt@xe_exec_system_allocator@process-many-large-mmap-huge-nomemset.html
* igt@xe_exec_system_allocator@threads-shared-vm-many-stride-new-race-nomemset:
- shard-dg2-set2: NOTRUN -> [SKIP][58] ([Intel XE#4915]) +52 other tests skip
[58]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-dg2-433/igt@xe_exec_system_allocator@threads-shared-vm-many-stride-new-race-nomemset.html
* igt@xe_oa@syncs-userptr-wait-cfg:
- shard-dg2-set2: NOTRUN -> [SKIP][59] ([Intel XE#3573])
[59]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-dg2-434/igt@xe_oa@syncs-userptr-wait-cfg.html
* igt@xe_peer2peer@read@read-gpua-vram01-gpub-system-p2p:
- shard-dg2-set2: NOTRUN -> [FAIL][60] ([Intel XE#1173])
[60]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-dg2-466/igt@xe_peer2peer@read@read-gpua-vram01-gpub-system-p2p.html
* igt@xe_pm@s2idle-basic-exec:
- shard-adlp: [PASS][61] -> [DMESG-WARN][62] ([Intel XE#2953] / [Intel XE#4173] / [Intel XE#4504])
[61]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3588-67f294a52e4b22d1b5bb86dd5dd3ac33e640717a/shard-adlp-4/igt@xe_pm@s2idle-basic-exec.html
[62]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-adlp-4/igt@xe_pm@s2idle-basic-exec.html
* igt@xe_query@multigpu-query-topology:
- shard-dg2-set2: NOTRUN -> [SKIP][63] ([Intel XE#944])
[63]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-dg2-433/igt@xe_query@multigpu-query-topology.html
#### Possible fixes ####
* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-async-flip:
- shard-adlp: [DMESG-FAIL][64] ([Intel XE#4543]) -> [PASS][65] +1 other test pass
[64]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3588-67f294a52e4b22d1b5bb86dd5dd3ac33e640717a/shard-adlp-9/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html
[65]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-adlp-1/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html
* igt@kms_bw@connected-linear-tiling-2-displays-2160x1440p:
- shard-bmg: [SKIP][66] ([Intel XE#2314] / [Intel XE#2894]) -> [PASS][67]
[66]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3588-67f294a52e4b22d1b5bb86dd5dd3ac33e640717a/shard-bmg-6/igt@kms_bw@connected-linear-tiling-2-displays-2160x1440p.html
[67]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-bmg-7/igt@kms_bw@connected-linear-tiling-2-displays-2160x1440p.html
* igt@kms_ccs@crc-sprite-planes-basic-4-tiled-bmg-ccs@pipe-a-dp-2:
- shard-bmg: [FAIL][68] ([Intel XE#5376]) -> [PASS][69] +1 other test pass
[68]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3588-67f294a52e4b22d1b5bb86dd5dd3ac33e640717a/shard-bmg-7/igt@kms_ccs@crc-sprite-planes-basic-4-tiled-bmg-ccs@pipe-a-dp-2.html
[69]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-bmg-7/igt@kms_ccs@crc-sprite-planes-basic-4-tiled-bmg-ccs@pipe-a-dp-2.html
* igt@kms_cursor_legacy@cursora-vs-flipb-atomic-transitions-varying-size:
- shard-bmg: [DMESG-WARN][70] ([Intel XE#5354]) -> [PASS][71]
[70]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3588-67f294a52e4b22d1b5bb86dd5dd3ac33e640717a/shard-bmg-7/igt@kms_cursor_legacy@cursora-vs-flipb-atomic-transitions-varying-size.html
[71]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-bmg-7/igt@kms_cursor_legacy@cursora-vs-flipb-atomic-transitions-varying-size.html
* igt@kms_cursor_legacy@cursora-vs-flipb-varying-size:
- shard-bmg: [SKIP][72] ([Intel XE#2291]) -> [PASS][73] +2 other tests pass
[72]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3588-67f294a52e4b22d1b5bb86dd5dd3ac33e640717a/shard-bmg-6/igt@kms_cursor_legacy@cursora-vs-flipb-varying-size.html
[73]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-bmg-8/igt@kms_cursor_legacy@cursora-vs-flipb-varying-size.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic:
- shard-bmg: [FAIL][74] ([Intel XE#4633]) -> [PASS][75]
[74]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3588-67f294a52e4b22d1b5bb86dd5dd3ac33e640717a/shard-bmg-6/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
[75]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-bmg-8/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
* igt@kms_cursor_legacy@flip-vs-cursor-legacy:
- shard-bmg: [FAIL][76] ([Intel XE#5299]) -> [PASS][77]
[76]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3588-67f294a52e4b22d1b5bb86dd5dd3ac33e640717a/shard-bmg-3/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
[77]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-bmg-5/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
* igt@kms_dp_aux_dev:
- shard-bmg: [SKIP][78] ([Intel XE#3009]) -> [PASS][79]
[78]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3588-67f294a52e4b22d1b5bb86dd5dd3ac33e640717a/shard-bmg-6/igt@kms_dp_aux_dev.html
[79]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-bmg-4/igt@kms_dp_aux_dev.html
* igt@kms_feature_discovery@display-2x:
- shard-bmg: [SKIP][80] ([Intel XE#2373]) -> [PASS][81]
[80]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3588-67f294a52e4b22d1b5bb86dd5dd3ac33e640717a/shard-bmg-6/igt@kms_feature_discovery@display-2x.html
[81]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-bmg-4/igt@kms_feature_discovery@display-2x.html
* igt@kms_flip@2x-flip-vs-dpms-on-nop:
- shard-bmg: [SKIP][82] ([Intel XE#2316]) -> [PASS][83] +3 other tests pass
[82]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3588-67f294a52e4b22d1b5bb86dd5dd3ac33e640717a/shard-bmg-6/igt@kms_flip@2x-flip-vs-dpms-on-nop.html
[83]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-bmg-8/igt@kms_flip@2x-flip-vs-dpms-on-nop.html
* igt@kms_flip@basic-plain-flip@b-hdmi-a1:
- shard-adlp: [DMESG-WARN][84] ([Intel XE#4543]) -> [PASS][85] +1 other test pass
[84]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3588-67f294a52e4b22d1b5bb86dd5dd3ac33e640717a/shard-adlp-9/igt@kms_flip@basic-plain-flip@b-hdmi-a1.html
[85]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-adlp-2/igt@kms_flip@basic-plain-flip@b-hdmi-a1.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1:
- shard-lnl: [FAIL][86] ([Intel XE#301]) -> [PASS][87] +1 other test pass
[86]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3588-67f294a52e4b22d1b5bb86dd5dd3ac33e640717a/shard-lnl-5/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html
[87]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-lnl-7/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html
* igt@kms_plane_scaling@plane-downscale-factor-0-5-with-modifiers@pipe-a:
- shard-adlp: [DMESG-WARN][88] ([Intel XE#2953] / [Intel XE#4173]) -> [PASS][89] +5 other tests pass
[88]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3588-67f294a52e4b22d1b5bb86dd5dd3ac33e640717a/shard-adlp-2/igt@kms_plane_scaling@plane-downscale-factor-0-5-with-modifiers@pipe-a.html
[89]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-adlp-8/igt@kms_plane_scaling@plane-downscale-factor-0-5-with-modifiers@pipe-a.html
* igt@kms_setmode@invalid-clone-single-crtc-stealing:
- shard-bmg: [SKIP][90] ([Intel XE#1435]) -> [PASS][91]
[90]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3588-67f294a52e4b22d1b5bb86dd5dd3ac33e640717a/shard-bmg-6/igt@kms_setmode@invalid-clone-single-crtc-stealing.html
[91]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-bmg-4/igt@kms_setmode@invalid-clone-single-crtc-stealing.html
* igt@kms_vrr@cmrr@pipe-a-edp-1:
- shard-lnl: [FAIL][92] ([Intel XE#4459]) -> [PASS][93] +1 other test pass
[92]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3588-67f294a52e4b22d1b5bb86dd5dd3ac33e640717a/shard-lnl-4/igt@kms_vrr@cmrr@pipe-a-edp-1.html
[93]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-lnl-5/igt@kms_vrr@cmrr@pipe-a-edp-1.html
* igt@kms_vrr@flipline:
- shard-lnl: [FAIL][94] ([Intel XE#4227]) -> [PASS][95] +1 other test pass
[94]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3588-67f294a52e4b22d1b5bb86dd5dd3ac33e640717a/shard-lnl-5/igt@kms_vrr@flipline.html
[95]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-lnl-1/igt@kms_vrr@flipline.html
* igt@xe_exec_basic@multigpu-once-basic-defer-bind:
- shard-dg2-set2: [SKIP][96] ([Intel XE#1392]) -> [PASS][97] +6 other tests pass
[96]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3588-67f294a52e4b22d1b5bb86dd5dd3ac33e640717a/shard-dg2-432/igt@xe_exec_basic@multigpu-once-basic-defer-bind.html
[97]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-dg2-436/igt@xe_exec_basic@multigpu-once-basic-defer-bind.html
* igt@xe_pmu@gt-frequency:
- shard-dg2-set2: [FAIL][98] ([Intel XE#4819]) -> [PASS][99] +1 other test pass
[98]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3588-67f294a52e4b22d1b5bb86dd5dd3ac33e640717a/shard-dg2-435/igt@xe_pmu@gt-frequency.html
[99]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-dg2-463/igt@xe_pmu@gt-frequency.html
#### Warnings ####
* igt@kms_content_protection@uevent:
- shard-bmg: [SKIP][100] ([Intel XE#2341]) -> [FAIL][101] ([Intel XE#1188])
[100]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3588-67f294a52e4b22d1b5bb86dd5dd3ac33e640717a/shard-bmg-6/igt@kms_content_protection@uevent.html
[101]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-bmg-4/igt@kms_content_protection@uevent.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-lnl: [FAIL][102] ([Intel XE#301] / [Intel XE#3149]) -> [FAIL][103] ([Intel XE#301])
[102]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3588-67f294a52e4b22d1b5bb86dd5dd3ac33e640717a/shard-lnl-5/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
[103]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-lnl-7/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
* igt@kms_frontbuffer_tracking@drrs-2p-primscrn-cur-indfb-draw-render:
- shard-bmg: [SKIP][104] ([Intel XE#2312]) -> [SKIP][105] ([Intel XE#2311]) +16 other tests skip
[104]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3588-67f294a52e4b22d1b5bb86dd5dd3ac33e640717a/shard-bmg-6/igt@kms_frontbuffer_tracking@drrs-2p-primscrn-cur-indfb-draw-render.html
[105]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-bmg-8/igt@kms_frontbuffer_tracking@drrs-2p-primscrn-cur-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-indfb-msflip-blt:
- shard-bmg: [SKIP][106] ([Intel XE#5390]) -> [SKIP][107] ([Intel XE#2312]) +4 other tests skip
[106]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3588-67f294a52e4b22d1b5bb86dd5dd3ac33e640717a/shard-bmg-8/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-indfb-msflip-blt.html
[107]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-bmg-6/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-indfb-msflip-blt.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-mmap-wc:
- shard-bmg: [SKIP][108] ([Intel XE#2312]) -> [SKIP][109] ([Intel XE#5390]) +7 other tests skip
[108]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3588-67f294a52e4b22d1b5bb86dd5dd3ac33e640717a/shard-bmg-6/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-mmap-wc.html
[109]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-bmg-7/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbcdrrs-2p-scndscrn-cur-indfb-draw-mmap-wc:
- shard-bmg: [SKIP][110] ([Intel XE#2311]) -> [SKIP][111] ([Intel XE#2312]) +7 other tests skip
[110]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3588-67f294a52e4b22d1b5bb86dd5dd3ac33e640717a/shard-bmg-8/igt@kms_frontbuffer_tracking@fbcdrrs-2p-scndscrn-cur-indfb-draw-mmap-wc.html
[111]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-bmg-6/igt@kms_frontbuffer_tracking@fbcdrrs-2p-scndscrn-cur-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-blt:
- shard-bmg: [SKIP][112] ([Intel XE#2312]) -> [SKIP][113] ([Intel XE#2313]) +15 other tests skip
[112]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3588-67f294a52e4b22d1b5bb86dd5dd3ac33e640717a/shard-bmg-6/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-blt.html
[113]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-bmg-4/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-blt.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-indfb-plflip-blt:
- shard-bmg: [SKIP][114] ([Intel XE#2313]) -> [SKIP][115] ([Intel XE#2312]) +12 other tests skip
[114]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3588-67f294a52e4b22d1b5bb86dd5dd3ac33e640717a/shard-bmg-8/igt@kms_frontbuffer_tracking@psr-2p-primscrn-indfb-plflip-blt.html
[115]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-bmg-6/igt@kms_frontbuffer_tracking@psr-2p-primscrn-indfb-plflip-blt.html
* igt@kms_hdr@brightness-with-hdr:
- shard-bmg: [SKIP][116] ([Intel XE#3374] / [Intel XE#3544]) -> [SKIP][117] ([Intel XE#3544])
[116]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3588-67f294a52e4b22d1b5bb86dd5dd3ac33e640717a/shard-bmg-7/igt@kms_hdr@brightness-with-hdr.html
[117]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-bmg-5/igt@kms_hdr@brightness-with-hdr.html
* igt@kms_plane_multiple@2x-tiling-yf:
- shard-bmg: [SKIP][118] ([Intel XE#5021]) -> [SKIP][119] ([Intel XE#4596])
[118]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3588-67f294a52e4b22d1b5bb86dd5dd3ac33e640717a/shard-bmg-8/igt@kms_plane_multiple@2x-tiling-yf.html
[119]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-bmg-6/igt@kms_plane_multiple@2x-tiling-yf.html
* igt@kms_tiled_display@basic-test-pattern:
- shard-dg2-set2: [FAIL][120] ([Intel XE#1729]) -> [SKIP][121] ([Intel XE#362])
[120]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3588-67f294a52e4b22d1b5bb86dd5dd3ac33e640717a/shard-dg2-435/igt@kms_tiled_display@basic-test-pattern.html
[121]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-dg2-463/igt@kms_tiled_display@basic-test-pattern.html
* igt@kms_tiled_display@basic-test-pattern-with-chamelium:
- shard-bmg: [SKIP][122] ([Intel XE#2509]) -> [SKIP][123] ([Intel XE#2426])
[122]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3588-67f294a52e4b22d1b5bb86dd5dd3ac33e640717a/shard-bmg-5/igt@kms_tiled_display@basic-test-pattern-with-chamelium.html
[123]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-bmg-7/igt@kms_tiled_display@basic-test-pattern-with-chamelium.html
* igt@xe_peer2peer@read:
- shard-dg2-set2: [SKIP][124] ([Intel XE#1061]) -> [FAIL][125] ([Intel XE#1173])
[124]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3588-67f294a52e4b22d1b5bb86dd5dd3ac33e640717a/shard-dg2-432/igt@xe_peer2peer@read.html
[125]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/shard-dg2-466/igt@xe_peer2peer@read.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[Intel XE#1061]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1061
[Intel XE#1124]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1124
[Intel XE#1127]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1127
[Intel XE#1173]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1173
[Intel XE#1178]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1178
[Intel XE#1188]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1188
[Intel XE#1392]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1392
[Intel XE#1435]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1435
[Intel XE#1489]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1489
[Intel XE#1727]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1727
[Intel XE#1729]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1729
[Intel XE#2234]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2234
[Intel XE#2291]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2291
[Intel XE#2311]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2311
[Intel XE#2312]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2312
[Intel XE#2313]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2313
[Intel XE#2314]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2314
[Intel XE#2316]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2316
[Intel XE#2321]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2321
[Intel XE#2322]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2322
[Intel XE#2341]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2341
[Intel XE#2373]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2373
[Intel XE#2426]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2426
[Intel XE#2509]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2509
[Intel XE#2652]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2652
[Intel XE#2850]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2850
[Intel XE#288]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/288
[Intel XE#2887]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2887
[Intel XE#2894]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2894
[Intel XE#2907]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2907
[Intel XE#2953]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2953
[Intel XE#3009]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3009
[Intel XE#301]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/301
[Intel XE#306]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/306
[Intel XE#307]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/307
[Intel XE#308]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/308
[Intel XE#3113]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3113
[Intel XE#3124]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3124
[Intel XE#3149]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3149
[Intel XE#316]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/316
[Intel XE#323]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/323
[Intel XE#3304]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3304
[Intel XE#3374]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3374
[Intel XE#3544]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3544
[Intel XE#3573]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3573
[Intel XE#362]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/362
[Intel XE#367]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/367
[Intel XE#373]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/373
[Intel XE#3768]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3768
[Intel XE#4173]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4173
[Intel XE#4227]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4227
[Intel XE#4345]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4345
[Intel XE#4459]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4459
[Intel XE#4504]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4504
[Intel XE#4543]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4543
[Intel XE#455]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/455
[Intel XE#4596]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4596
[Intel XE#4633]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4633
[Intel XE#4819]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4819
[Intel XE#4837]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4837
[Intel XE#4915]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4915
[Intel XE#4943]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4943
[Intel XE#5021]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5021
[Intel XE#5299]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5299
[Intel XE#5354]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5354
[Intel XE#5376]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5376
[Intel XE#5390]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5390
[Intel XE#5899]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5899
[Intel XE#616]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/616
[Intel XE#651]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/651
[Intel XE#653]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/653
[Intel XE#787]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/787
[Intel XE#929]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/929
[Intel XE#944]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/944
Build changes
-------------
* Linux: xe-3588-67f294a52e4b22d1b5bb86dd5dd3ac33e640717a -> xe-pw-153233v1
IGT_8499: e5e236fad9e36c3a868bc851262ee34ca57f9e5c @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
xe-3588-67f294a52e4b22d1b5bb86dd5dd3ac33e640717a: 67f294a52e4b22d1b5bb86dd5dd3ac33e640717a
xe-pw-153233v1: 153233v1
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-153233v1/index.html
[-- Attachment #2: Type: text/html, Size: 42203 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/gpuvm: Rename 'map' to 'op' in drm_gpuvm_map_req
2025-08-21 16:55 ` Ghimiray, Himal Prasad
@ 2025-08-22 7:35 ` Boris Brezillon
2025-08-22 7:52 ` Ghimiray, Himal Prasad
0 siblings, 1 reply; 17+ messages in thread
From: Boris Brezillon @ 2025-08-22 7:35 UTC (permalink / raw)
To: Ghimiray, Himal Prasad
Cc: Danilo Krummrich, intel-xe, Boris Brezillon, Matt Coster,
Rob Clark, Matthew Brost, dri-devel
On Thu, 21 Aug 2025 22:25:06 +0530
"Ghimiray, Himal Prasad" <himal.prasad.ghimiray@intel.com> wrote:
> On 21-08-2025 19:05, Danilo Krummrich wrote:
> > On Thu Aug 21, 2025 at 3:01 PM CEST, Boris Brezillon wrote:
> >> On Thu, 21 Aug 2025 14:55:06 +0200
> >> "Danilo Krummrich" <dakr@kernel.org> wrote:
> >>
> >>> On Thu Aug 21, 2025 at 1:25 PM CEST, Boris Brezillon wrote:
> >>>> On Thu, 21 Aug 2025 13:01:46 +0200
> >>>> Boris Brezillon <boris.brezillon@collabora.com> wrote:
> >>>>> On a second thought, I'm now wondering why we need drm_gpuvm_map_req in
> >>>>> the first place. It would kinda make sense if it was containing an
> >>>>>
> >>>>> bool madvise;
> >>>>>
> >>>>> field, so you don't have to pass it around, but even then, I'm
> >>>>> wondering if we wouldn't be better off adding this field to
> >>>>> drm_gpuva_op_map instead and passing an drm_gpuva_op_map object to
> >>>>> the various map helpers (like Danilo suggested in his review of the
> >>>>> REPEATED mode series Caterina sent).
> >>>>
> >>>> More on that: the very reason I introduced drm_gpuvm_map_req in the
> >>>> first place is so we have a clear differentiation between an overall
> >>>> map request and the sub-operations that are created to fulfill it.
> >>>> Looks like this was not a concern for Danilo and he was happy with us
> >>>> using _op_map for this.
> >>>>
> >>>> The other reason we might want to add drm_gpuvm_map_req is so that
> >>>> information we only need while splitting a req don't pollute
> >>>> drm_gpuva_op_map. Given I was going to pass the flags to the driver's
> >>>> callback anyway (meaning it's needed at the op_map level), and given
> >>>> you're passing madvise as a separate bool argument to various helpers
> >>>> (_map_req just contains the op, not the madvise bool), I don't think
> >>>> this aspect matters.
> >>>
> >>> Good catch! Indeed, when Himal picked up your struct drm_gpuvm_map_req patch,
> >>> there were additional flags included in the structure. Now that it is
> >>> essentially a transparent wrapper, I prefer to use struct drm_gpuva_op_map
> >>> directly.
> >>>
> >>> However, given that you still have patches in flight that will add a flags field
> >>> to struct drm_gpuvm_map_req I think it's probably fine to introduce it right
> >>> away. Or did you drop this plan of adding those flags?
> >>
> >> I need the flags field in the op_map too (so I can propagate it to the
> >> drm_gpuva object), so I'd rather go with an op_map object directly and
> >> kill drm_gpuvm_map_req now.
> >
> > In this case I agree, let's use struct drm_gpuva_op_map directly.
>
> According to the kernel documentation for the drm_gpuva_op_map
> structure, it is intended to represent a single map operation generated
> as the output of ops_create or the GPU VA manager. Using it as a direct
> input to ops_create contradicts this definition.
>
> For drm_gpuvm_sm_map_ops_create, the values align with those in
> drm_gpuvm_map_req. However, this is not the case for
> drm_gpuvm_madvise_ops_create.
>
> If we plan to proceed with deprecating drm_gpuvm_map_req, we need to
> clarify the fundamental definition of drm_gpuva_op_map:
> Should it represent a user-requested map, or an operation generated by
> the GPU VA manager?
I would say, update the doc to reflect it can be used to pass a user
map request too, but I'll let Danilo make the final call. BTW,
embedding an op in _map_req is equivalent to saying the _op_map object
can describe a user map request to me :P.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/gpuvm: Rename 'map' to 'op' in drm_gpuvm_map_req
2025-08-22 7:35 ` Boris Brezillon
@ 2025-08-22 7:52 ` Ghimiray, Himal Prasad
0 siblings, 0 replies; 17+ messages in thread
From: Ghimiray, Himal Prasad @ 2025-08-22 7:52 UTC (permalink / raw)
To: Boris Brezillon
Cc: Danilo Krummrich, intel-xe, Boris Brezillon, Matt Coster,
Rob Clark, Matthew Brost, dri-devel
On 22-08-2025 13:05, Boris Brezillon wrote:
> On Thu, 21 Aug 2025 22:25:06 +0530
> "Ghimiray, Himal Prasad" <himal.prasad.ghimiray@intel.com> wrote:
>
>> On 21-08-2025 19:05, Danilo Krummrich wrote:
>>> On Thu Aug 21, 2025 at 3:01 PM CEST, Boris Brezillon wrote:
>>>> On Thu, 21 Aug 2025 14:55:06 +0200
>>>> "Danilo Krummrich" <dakr@kernel.org> wrote:
>>>>
>>>>> On Thu Aug 21, 2025 at 1:25 PM CEST, Boris Brezillon wrote:
>>>>>> On Thu, 21 Aug 2025 13:01:46 +0200
>>>>>> Boris Brezillon <boris.brezillon@collabora.com> wrote:
>>>>>>> On a second thought, I'm now wondering why we need drm_gpuvm_map_req in
>>>>>>> the first place. It would kinda make sense if it was containing an
>>>>>>>
>>>>>>> bool madvise;
>>>>>>>
>>>>>>> field, so you don't have to pass it around, but even then, I'm
>>>>>>> wondering if we wouldn't be better off adding this field to
>>>>>>> drm_gpuva_op_map instead and passing an drm_gpuva_op_map object to
>>>>>>> the various map helpers (like Danilo suggested in his review of the
>>>>>>> REPEATED mode series Caterina sent).
>>>>>>
>>>>>> More on that: the very reason I introduced drm_gpuvm_map_req in the
>>>>>> first place is so we have a clear differentiation between an overall
>>>>>> map request and the sub-operations that are created to fulfill it.
>>>>>> Looks like this was not a concern for Danilo and he was happy with us
>>>>>> using _op_map for this.
>>>>>>
>>>>>> The other reason we might want to add drm_gpuvm_map_req is so that
>>>>>> information we only need while splitting a req don't pollute
>>>>>> drm_gpuva_op_map. Given I was going to pass the flags to the driver's
>>>>>> callback anyway (meaning it's needed at the op_map level), and given
>>>>>> you're passing madvise as a separate bool argument to various helpers
>>>>>> (_map_req just contains the op, not the madvise bool), I don't think
>>>>>> this aspect matters.
>>>>>
>>>>> Good catch! Indeed, when Himal picked up your struct drm_gpuvm_map_req patch,
>>>>> there were additional flags included in the structure. Now that it is
>>>>> essentially a transparent wrapper, I prefer to use struct drm_gpuva_op_map
>>>>> directly.
>>>>>
>>>>> However, given that you still have patches in flight that will add a flags field
>>>>> to struct drm_gpuvm_map_req I think it's probably fine to introduce it right
>>>>> away. Or did you drop this plan of adding those flags?
>>>>
>>>> I need the flags field in the op_map too (so I can propagate it to the
>>>> drm_gpuva object), so I'd rather go with an op_map object directly and
>>>> kill drm_gpuvm_map_req now.
>>>
>>> In this case I agree, let's use struct drm_gpuva_op_map directly.
>>
>> According to the kernel documentation for the drm_gpuva_op_map
>> structure, it is intended to represent a single map operation generated
>> as the output of ops_create or the GPU VA manager. Using it as a direct
>> input to ops_create contradicts this definition.
>>
>> For drm_gpuvm_sm_map_ops_create, the values align with those in
>> drm_gpuvm_map_req. However, this is not the case for
>> drm_gpuvm_madvise_ops_create.
>>
>> If we plan to proceed with deprecating drm_gpuvm_map_req, we need to
>> clarify the fundamental definition of drm_gpuva_op_map:
>> Should it represent a user-requested map, or an operation generated by
>> the GPU VA manager?
>
> I would say, update the doc to reflect it can be used to pass a user
> map request too, but I'll let Danilo make the final call. BTW,
> embedding an op in _map_req is equivalent to saying the _op_map object
> can describe a user map request to me :P.
True :P
^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2025-08-22 7:52 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-20 15:23 [PATCH] drm/gpuvm: Rename 'map' to 'op' in drm_gpuvm_map_req Himal Prasad Ghimiray
2025-08-20 16:07 ` Boris Brezillon
2025-08-21 11:01 ` Boris Brezillon
2025-08-21 11:25 ` Boris Brezillon
2025-08-21 12:55 ` Danilo Krummrich
2025-08-21 13:01 ` Boris Brezillon
2025-08-21 13:30 ` Ghimiray, Himal Prasad
2025-08-21 13:35 ` Danilo Krummrich
2025-08-21 16:55 ` Ghimiray, Himal Prasad
2025-08-22 7:35 ` Boris Brezillon
2025-08-22 7:52 ` Ghimiray, Himal Prasad
2025-08-20 16:38 ` Danilo Krummrich
2025-08-20 16:53 ` Rob Clark
2025-08-20 16:56 ` Matt Coster
2025-08-20 20:15 ` ✓ CI.KUnit: success for " Patchwork
2025-08-20 21:19 ` ✓ Xe.CI.BAT: " Patchwork
2025-08-21 20:15 ` ✗ Xe.CI.Full: failure " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).