Re: [PATCH v5 13/13] drm/xe/pxp: Enable PXP for MTL and LNL

[Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>]

On 1/31/2025 4:08 AM, Tvrtko Ursulin wrote:
>
> Hi,
>
> On 16/01/2025 00:11, Daniele Ceraolo Spurio wrote:
>> Now that are the pieces are there, we can turn the feature on.
>
> Would it be possible to have this on Aderlake too?

Not easily, because the pre-MTL PXP back-end is quite different due to 
the GSC not being there (need to go to CSME via MEI instead) and due to 
it using a different PXP version (4.2 instead of 4.3).
We're currently not planning on implementing PXP support for ADL in Xe, 
but full support is there in i915.

Daniele

>
> Regards,
>
> Tvrtko
>
>> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
>> Reviewed-by: John Harrison <John.C.Harrison@Intel.com>
>> ---
>>   drivers/gpu/drm/xe/xe_pci.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
>> index 44f59af94652..c9c88a818b2d 100644
>> --- a/drivers/gpu/drm/xe/xe_pci.c
>> +++ b/drivers/gpu/drm/xe/xe_pci.c
>> @@ -336,11 +336,13 @@ static const struct xe_device_desc mtl_desc = {
>>       .require_force_probe = true,
>>       PLATFORM(METEORLAKE),
>>       .has_display = true,
>> +    .has_pxp = true,
>>   };
>>     static const struct xe_device_desc lnl_desc = {
>>       PLATFORM(LUNARLAKE),
>>       .has_display = true,
>> +    .has_pxp = true,
>>   };
>>     static const struct xe_device_desc bmg_desc = {