Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Welty, Brian" <brian.welty@intel.com>
To: <John.C.Harrison@Intel.com>, <Intel-Xe@Lists.FreeDesktop.Org>
Subject: Re: [PATCH 2/2] drm/xe/guc: Update to GuC firmware 70.19.1
Date: Mon, 22 Jan 2024 14:14:56 -0800	[thread overview]
Message-ID: <069f1653-d286-4bce-84f7-e2198ba0c5e8@intel.com> (raw)
In-Reply-To: <20240122213708.1841488-3-John.C.Harrison@Intel.com>



On 1/22/2024 1:37 PM, John.C.Harrison@Intel.com wrote:
> From: John Harrison <John.C.Harrison@Intel.com>
> 
> UAPI compatibility version: 1.8.1

I've wondered for awhile why was lagging behind here....

Reviewed-by: Brian Welty <brian.welty@intel.com>

> 
> Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
> ---
>   drivers/gpu/drm/xe/xe_uc_fw.c | 16 ++++++++--------
>   1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_uc_fw.c b/drivers/gpu/drm/xe/xe_uc_fw.c
> index d3f0fe2101a7..8da6cbb8c9e2 100644
> --- a/drivers/gpu/drm/xe/xe_uc_fw.c
> +++ b/drivers/gpu/drm/xe/xe_uc_fw.c
> @@ -103,14 +103,14 @@ struct fw_blobs_by_type {
>   };
>   
>   #define XE_GUC_FIRMWARE_DEFS(fw_def, mmp_ver, major_ver)			\
> -	fw_def(METEORLAKE,	major_ver(i915,	guc,	mtl,	70, 7, 0))	\
> -	fw_def(DG2,		major_ver(i915,	guc,	dg2,	70, 5, 0))	\
> -	fw_def(DG1,		major_ver(i915,	guc,	dg1,	70, 5, 0))	\
> -	fw_def(ALDERLAKE_N,	major_ver(i915,	guc,	tgl,	70, 5, 0))	\
> -	fw_def(ALDERLAKE_P,	major_ver(i915,	guc,	adlp,	70, 5, 0))	\
> -	fw_def(ALDERLAKE_S,	major_ver(i915,	guc,	tgl,	70, 5, 0))	\
> -	fw_def(ROCKETLAKE,	major_ver(i915,	guc,	tgl,	70, 5, 0))	\
> -	fw_def(TIGERLAKE,	major_ver(i915,	guc,	tgl,	70, 5, 0))
> +	fw_def(METEORLAKE,	major_ver(i915,	guc,	mtl,	70, 19, 1))	\
> +	fw_def(DG2,		major_ver(i915,	guc,	dg2,	70, 19, 1))	\
> +	fw_def(DG1,		major_ver(i915,	guc,	dg1,	70, 19, 1))	\
> +	fw_def(ALDERLAKE_N,	major_ver(i915,	guc,	tgl,	70, 19, 1))	\
> +	fw_def(ALDERLAKE_P,	major_ver(i915,	guc,	adlp,	70, 19, 1))	\
> +	fw_def(ALDERLAKE_S,	major_ver(i915,	guc,	tgl,	70, 19, 1))	\
> +	fw_def(ROCKETLAKE,	major_ver(i915,	guc,	tgl,	70, 19, 1))	\
> +	fw_def(TIGERLAKE,	major_ver(i915,	guc,	tgl,	70, 19, 1))
>   
>   #define XE_HUC_FIRMWARE_DEFS(fw_def, mmp_ver, no_ver)		\
>   	fw_def(METEORLAKE,	no_ver(i915,	huc_gsc,	mtl))		\

  reply	other threads:[~2024-01-22 22:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-22 21:37 [PATCH 0/2] Update to GuC 70.19.1 John.C.Harrison
2024-01-22 21:37 ` [PATCH 1/2] drm/xe/uc: Include patch version in expectations John.C.Harrison
2024-01-22 22:15   ` Welty, Brian
2024-02-01 18:10   ` Lucas De Marchi
2024-01-22 21:37 ` [PATCH 2/2] drm/xe/guc: Update to GuC firmware 70.19.1 John.C.Harrison
2024-01-22 22:14   ` Welty, Brian [this message]
2024-01-23 16:41     ` Lucas De Marchi
2024-01-23 23:24       ` John Harrison
2024-01-24  4:45         ` Lucas De Marchi
2024-01-22 22:54 ` ✗ CI.Patch_applied: failure for Update to GuC 70.19.1 Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=069f1653-d286-4bce-84f7-e2198ba0c5e8@intel.com \
    --to=brian.welty@intel.com \
    --cc=Intel-Xe@Lists.FreeDesktop.Org \
    --cc=John.C.Harrison@Intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox