From: Nirmoy Das <nirmoy.das@intel.com>
To: <intel-xe@lists.freedesktop.org>
Cc: <stable@vger.kernel.org>,
Bommu Krishnaiah <krishnaiah.bommu@intel.com>,
Matthew Auld <matthew.auld@intel.com>,
Matthew Brost <matthew.brost@intel.com>
Subject: Re: [PATCH] drm/xe/ufence: ufence can be signaled right after wait_woken
Date: Fri, 11 Oct 2024 16:10:00 +0200 [thread overview]
Message-ID: <07151ff0-90b1-4ec8-9f64-f695fb411dbf@intel.com> (raw)
In-Reply-To: <20241011132532.3845488-1-nirmoy.das@intel.com>
On 10/11/2024 3:25 PM, Nirmoy Das wrote:
> do_comapre() can return success after wait_woken() which is treated as
> -ETIME here.
s/after wait_woken()/after timedout wait_woken()
I will resend with that change.
>
> Fixes: e670f0b4ef24 ("drm/xe/uapi: Return correct error code for xe_wait_user_fence_ioctl")
> Cc: <stable@vger.kernel.org> # v6.8+
> Cc: Bommu Krishnaiah <krishnaiah.bommu@intel.com>
> Link: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/1630
> Cc: Matthew Auld <matthew.auld@intel.com>
> Cc: Matthew Brost <matthew.brost@intel.com>
> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
> ---
> drivers/gpu/drm/xe/xe_wait_user_fence.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_wait_user_fence.c b/drivers/gpu/drm/xe/xe_wait_user_fence.c
> index d46fa8374980..d532283d4aa3 100644
> --- a/drivers/gpu/drm/xe/xe_wait_user_fence.c
> +++ b/drivers/gpu/drm/xe/xe_wait_user_fence.c
> @@ -169,7 +169,7 @@ int xe_wait_user_fence_ioctl(struct drm_device *dev, void *data,
> args->timeout = 0;
> }
>
> - if (!timeout && !(err < 0))
> + if (!timeout && err < 0)
> err = -ETIME;
>
> if (q)
next prev parent reply other threads:[~2024-10-11 14:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-11 13:25 [PATCH] drm/xe/ufence: ufence can be signaled right after wait_woken Nirmoy Das
2024-10-11 14:10 ` Nirmoy Das [this message]
2024-10-11 15:16 ` Matthew Auld
2024-10-11 15:44 ` Nirmoy Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07151ff0-90b1-4ec8-9f64-f695fb411dbf@intel.com \
--to=nirmoy.das@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=krishnaiah.bommu@intel.com \
--cc=matthew.auld@intel.com \
--cc=matthew.brost@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox