Re: [PATCH] drm/xe/guc: Add support for NPK as a GuC log target

[Jani Nikula <jani.nikula@linux.intel.com>]

On Tue, 07 Apr 2026, "Summers, Stuart" <stuart.summers@intel.com> wrote:
> On Tue, 2026-04-07 at 11:48 +0200, Michal Wajdeczko wrote:
>> 
>> On 4/7/2026 12:53 AM, Stuart Summers wrote:
>> > From: John Harrison <John.C.Harrison@Intel.com>
>> > 
>> > GuC provides the ability to gather logs through a hardware
>> > interface
>> > called NPK. For certain debugging scenarios this can be
>> > advantageous
>> > over getting logs from memory (or in addition to).
>> > 
>> > Add a hook for this alternate debugging mode via a configfs. This
>> > translates into a parameter passed to GuC during load time.
>> > 
>> > v2: Convert to configfs from modparam (Matt)
>> > v3: Configfs documentation formatting (Shuicheng)
>> >     Kerneldoc/comment add + configfs entry ordering
>> >     Only set the guc_log_target when GuC log is enabled (Daniele)
>> 
>> nit: we may keep change log under --- so it stays on the ML only
>
> Ok makes sense I'll do that on the next upload.

Is this an intentional deviation from the quite prevalent drm subsystem
style of including the changelog in the commit message?

I'm not dead set on either style personally, but I do not like
conflicting review feedback, and people not knowing what to do.


BR,
Jani.


-- 
Jani Nikula, Intel