Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: "Michael J. Ruhl" <michael.j.ruhl@intel.com>
Cc: platform-driver-x86@vger.kernel.org,
	intel-xe@lists.freedesktop.org,  Hans de Goede <hansg@kernel.org>,
	matthew.brost@intel.com,  rodrigo.vivi@intel.com,
	thomas.hellstrom@linux.intel.com,  airlied@gmail.com,
	simona@ffwll.ch, david.e.box@linux.intel.com,
	 anoop.c.vijay@intel.com, badal.nilawar@intel.com,
	 matthew.d.roper@intel.com, james.ausmus@intel.com
Subject: Re: [PATCH v21 01/19] platform/x86/intel/pmt: Introduce a callback for discovery data
Date: Fri, 20 Nov 2026 23:29:00 +0200 (EET)	[thread overview]
Message-ID: <07de3fd3-c7bb-74f2-9f3c-72c79271aed0@linux.intel.com> (raw)
In-Reply-To: <20261120205540.1220643-22-michael.j.ruhl@intel.com>

On Fri, 20 Nov 2026, Michael J. Ruhl wrote:

> Some devices require special handling to access discovery data.
> 
> Crescent Island GPUs have a windowed access to discovery and data.
> Because of this, direct access to the devices MMIO space can be unsafe.
> 
> A further difficuly is the read_data path requires a GUID which will
> not be known until after discovery, so the current read_data callback
> cannot be used.
> 
> Provide a callback that uses the capbility and disocvery index, for

typo x2.

> reading discovery data.
> 
> Reviewed-by: David E. Box <david.e.box@linux.intel.com>
> Suggested-by: David E. Box <david.e.box@linux.intel.com>
> Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
> ---
>  drivers/platform/x86/intel/pmt/class.c | 18 ++++++++++++------
>  include/linux/intel_vsec.h             | 10 ++++++++++
>  2 files changed, 22 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/platform/x86/intel/pmt/class.c b/drivers/platform/x86/intel/pmt/class.c
> index 2b11c4012f6a..601cdf68f0bc 100644
> --- a/drivers/platform/x86/intel/pmt/class.c
> +++ b/drivers/platform/x86/intel/pmt/class.c
> @@ -466,12 +466,17 @@ static int pmt_get_headers(struct intel_vsec_device *ivdev, int idx,
>  	switch (ivdev->src) {
>  	case INTEL_VSEC_DISC_PCI: {
>  		struct resource *disc_res = &ivdev->resource[idx];
> +		struct pmt_callbacks *cb = ivdev->priv_data;
>  		void __iomem *disc_table;
> +		int ret = 0;
>  
>  		disc_table = devm_ioremap_resource(dev, disc_res);
>  		if (IS_ERR(disc_table))
>  			return PTR_ERR(disc_table);
>  
> +		/* Used by crashlog driver */
> +		entry->disc_table = disc_table;
> +
>  		/*
>  		 * The mapped resource is sized by the namespace's DVSEC
>  		 * entry_size (in dwords), which can be less than the default
> @@ -480,13 +485,14 @@ static int pmt_get_headers(struct intel_vsec_device *ivdev, int idx,
>  		 * region.
>  		 */
>  		memset(entry->disc_header, 0, header_bytes);
> -		memcpy_fromio(entry->disc_header, disc_table,
> -			      min(header_bytes, resource_size(disc_res)));
> -
> -		/* Used by crashlog driver */
> -		entry->disc_table = disc_table;
>  
> -		return 0;
> +		if (cb && cb->read_discovery)
> +			ret = cb->read_discovery(ivdev->dev, ivdev->cap_id, idx,
> +						 entry->disc_header);
> +		else
> +			memcpy_fromio(entry->disc_header, disc_table,
> +				      min(header_bytes, resource_size(disc_res)));
> +		return ret;
>  	}
>  	case INTEL_VSEC_DISC_ACPI: {
>  		memcpy(entry->disc_header, &ivdev->acpi_disc[idx][0], header_bytes);
> diff --git a/include/linux/intel_vsec.h b/include/linux/intel_vsec.h
> index 8686e79c4f75..e4afdb6478e3 100644
> --- a/include/linux/intel_vsec.h
> +++ b/include/linux/intel_vsec.h
> @@ -94,6 +94,11 @@ enum intel_vsec_quirks {
>   * * data:  buffer for the data to be copied
>   * * off:   offset into the requested buffer
>   * * count: size of buffer
> + * @read_discovery: when specified called by client driver to read PMT discovery structs
> + * * dev:       device reference for the callback's use
> + * * cap_id:    ilog2 of VSEC_CAP value
> + * * idx:       index to access based on the capability header enumerated by intel_vsec_register()
> + * * disc_data: PMT_DISC_DWORDS dword sized buffer for the discovery data to be copied
>   * @read_reg: when specified called by client driver to read PMT state
>   * * dev:      device reference for the callback's use
>   * * guid:     ID of data to access
> @@ -104,9 +109,14 @@ enum intel_vsec_quirks {
>   * * guid:     ID of data to access
>   * * reg_data: register data
>   * * offset:   offset of register to write
> + *
> + * NOTE: Callbacks may be called from the client driver's probe and remove paths.
> + *       A parent MUST not hold a lock taken by the callbacks across the registration
> + *       path or while its devices are being removed.
>   */
>  struct pmt_callbacks {
>  	int (*read_telem)(struct device *dev, u32 guid, u64 *data, loff_t off, u32 count);
> +	int (*read_discovery)(struct device *dev, unsigned long cap_id, u32 idx, u32 *disc_data);
>  	int (*read_reg)(struct device *dev, u32 guid, u32 *reg_data, u32 offset);
>  	int (*write_reg)(struct device *dev, u32 guid, u32 reg_data, u32 offset);
>  };
> 

-- 
 i.


  reply	other threads:[~2026-11-20 21:29 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 20:55 [PATCH v21 00/19] Crescent Island PMT support Michael J. Ruhl
2026-11-20 20:55 ` [PATCH v21 01/19] platform/x86/intel/pmt: Introduce a callback for discovery data Michael J. Ruhl
2026-11-20 21:29   ` Ilpo Järvinen [this message]
2026-11-20 20:55 ` [PATCH v21 02/19] platform/x86/intel/pmt: Use the pre-populated header info for crashlog Michael J. Ruhl
2026-11-20 20:55 ` [PATCH v21 03/19] drm/xe/vsec: VSEC requires soc-remapper Michael J. Ruhl
2026-11-20 20:55 ` [PATCH v21 04/19] drm/xe/vsec: Do not register BMG PMT for VF Michael J. Ruhl
2026-11-20 20:55 ` [PATCH v21 05/19] drm/xe/vsec: Correct locking order Michael J. Ruhl
2026-11-20 20:55 ` [PATCH v21 06/19] drm/xe/vsec: Use correct pm state get Michael J. Ruhl
2026-11-20 20:55 ` [PATCH v21 07/19] drm/xe/vsec: Add DOC text for VSEC Michael J. Ruhl
2026-11-20 20:55 ` [PATCH v21 08/19] drm/xe/vsec: Support possible hotplug exit Michael J. Ruhl
2026-11-20 20:55 ` [PATCH v21 09/19] drm/xe/vsec: Refactor BattleMage PMT defines Michael J. Ruhl
2026-11-20 20:55 ` [PATCH v21 10/19] drm/xe/vsec: Update VSEC probe order Michael J. Ruhl
2026-11-20 20:55 ` [PATCH v21 11/19] drm/xe/vsec: Add base_offset to allow for more flexibilty Michael J. Ruhl
2026-11-20 20:55 ` [PATCH v21 12/19] drm/xe/vsec: Support Crescent Island PMT Michael J. Ruhl
2026-11-20 20:55 ` [PATCH v21 13/19] drm/xe/vsec: Crescent Island PMT decode Michael J. Ruhl
2026-11-20 20:55 ` [PATCH v21 14/19] drm/xe/vsec: Crescent Island PMT callbacks Michael J. Ruhl
2026-11-20 20:55 ` [PATCH v21 15/19] drm/xe/vsec: Support late bind fw information Michael J. Ruhl
2026-11-20 20:55 ` [PATCH v21 16/19] drm/xe/vsec: Add PMT GUID internal access Michael J. Ruhl
2026-11-20 20:55 ` [PATCH v21 17/19] drm/xe/vsec: Update PMT " Michael J. Ruhl
2026-11-20 20:55 ` [PATCH v21 18/19] drm/xe/vsec: Refactor platform check Michael J. Ruhl
2026-11-20 20:55 ` [PATCH v21 19/19] drm/xe/vsec: Support survivability mode for CRI Michael J. Ruhl
2026-11-20 21:04 ` ✗ CI.checkpatch: warning for Crescent Island PMT support (rev22) Patchwork
2026-11-20 21:06 ` ✓ CI.KUnit: success " Patchwork
2026-11-20 21:47 ` ✗ Xe.CI.BAT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=07de3fd3-c7bb-74f2-9f3c-72c79271aed0@linux.intel.com \
    --to=ilpo.jarvinen@linux.intel.com \
    --cc=airlied@gmail.com \
    --cc=anoop.c.vijay@intel.com \
    --cc=badal.nilawar@intel.com \
    --cc=david.e.box@linux.intel.com \
    --cc=hansg@kernel.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=james.ausmus@intel.com \
    --cc=matthew.brost@intel.com \
    --cc=matthew.d.roper@intel.com \
    --cc=michael.j.ruhl@intel.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rodrigo.vivi@intel.com \
    --cc=simona@ffwll.ch \
    --cc=thomas.hellstrom@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox