From: "Tauro, Riana" <riana.tauro@intel.com>
To: Raag Jadav <raag.jadav@intel.com>, <intel-xe@lists.freedesktop.org>
Cc: <michal.wajdeczko@intel.com>, <matthew.d.roper@intel.com>,
<mallesh.koujalagi@intel.com>
Subject: Re: [PATCH v1] drm/xe/pci_error: Allow debugging PCI errors
Date: Tue, 18 Aug 2026 13:52:28 +0530 [thread overview]
Message-ID: <096b3560-2be1-4082-8e21-ed5ac92e8697@intel.com> (raw)
In-Reply-To: <20260814143121.390791-1-raag.jadav@intel.com>
On 14-08-2026 20:01, Raag Jadav wrote:
> XE_WEDGED_MODE_UPON_ANY_HANG_NO_RESET is intended for debugging hangs.
> Disconnect the device on AER and prevent bus reset, so that it is available
> to the user for debugging.
>
> Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> ---
> drivers/gpu/drm/xe/xe_pci_error.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/xe/xe_pci_error.c b/drivers/gpu/drm/xe/xe_pci_error.c
> index e41af2ac7f23..4858ce2f9c19 100644
> --- a/drivers/gpu/drm/xe/xe_pci_error.c
> +++ b/drivers/gpu/drm/xe/xe_pci_error.c
> @@ -63,6 +63,12 @@ static pci_ers_result_t xe_pci_error_detected(struct pci_dev *pdev, pci_channel_
> if (xe_survivability_mode_is_boot_enabled(xe) || xe_device_wedged(xe))
> return PCI_ERS_RESULT_DISCONNECT;
>
> + /* User wants to debug the error, prevent reset */
> + if (xe->wedged.mode == XE_WEDGED_MODE_UPON_ANY_HANG_NO_RESET) {
> + xe_device_declare_wedged(xe);
> + return PCI_ERS_RESULT_DISCONNECT;
> + }
This should be for nonfatal errors in mmio_enabled after processing the
errors.
Also for fatal errors, we cannot skip recovery as pci port driver
requests reset.
Either way it should be moved to mmio enabled.
Thanks
Riana
> +
> switch (state) {
> case pci_channel_io_normal:
> return PCI_ERS_RESULT_CAN_RECOVER;
next prev parent reply other threads:[~2026-08-18 8:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-14 14:31 [PATCH v1] drm/xe/pci_error: Allow debugging PCI errors Raag Jadav
2026-08-14 14:39 ` ✓ CI.KUnit: success for " Patchwork
2026-08-14 14:46 ` [PATCH v1] " sashiko-bot
2026-08-14 15:30 ` ✓ Xe.CI.BAT: success for " Patchwork
2026-08-14 16:58 ` ✓ Xe.CI.FULL: " Patchwork
2026-08-18 8:22 ` Tauro, Riana [this message]
2026-08-19 10:30 ` [PATCH v1] " Tauro, Riana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=096b3560-2be1-4082-8e21-ed5ac92e8697@intel.com \
--to=riana.tauro@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=mallesh.koujalagi@intel.com \
--cc=matthew.d.roper@intel.com \
--cc=michal.wajdeczko@intel.com \
--cc=raag.jadav@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox