Re: [PATCH v1 08/14] drm/xe/uapi: Order sections

[Aravind Iddamsetty <aravind.iddamsetty@linux.intel.com>]

On 12/15/23 02:27, Lucas De Marchi wrote:

Hi  Lucas,

> On Thu, Dec 07, 2023 at 01:50:03PM +0000, Francois Dugast wrote:
>> From: Rodrigo Vivi <rodrigo.vivi@intel.com>
>>
>> This patch doesn't modify any text or uapi entries themselves.
>> It only move things up and down aiming a better organization of the uAPI.
>>
>> While fixing the documentation I noticed that query_engine_cs_cycles
>> was in the middle of the memory_region info. Then I noticed more
>> mismatches on the order when compared to the order of the IOCTL
>> and QUERY entries declaration. So this patch aims to bring some
>> order to the uAPI so it gets easier to read and the documentation
>> generated in the end is able to tell a consistent story.
>>
>> Overall order:
>>
>> 1. IOCTL definition
>> 2. Extension definition and helper structs
>> 3. IOCTL's Query structs in the order of the Query's entries.
>> 4. The rest of IOCTL structs in the order of IOCTL declaration.
>> 5. uEvents
>> 6. PMU
>>
>> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Signed-off-by: Francois Dugast <francois.dugast@intel.com>
>> ---
>> include/uapi/drm/xe_drm.h | 255 ++++++++++++++++++++------------------
>> 1 file changed, 132 insertions(+), 123 deletions(-)
>>
>> diff --git a/include/uapi/drm/xe_drm.h b/include/uapi/drm/xe_drm.h
>> index f9178fe024a5..b36f3bd53611 100644
>> --- a/include/uapi/drm/xe_drm.h
>> +++ b/include/uapi/drm/xe_drm.h
>> @@ -12,19 +12,51 @@
>> extern "C" {
>> #endif
>>
<snip>
>> +/**
>> + * DOC: uevent generated by xe on its pci node.
>> + *
>> + * DRM_XE_RESET_FAILED_UEVENT - Event is generated when attempt to reset gt
>> + * fails. The value supplied with the event is always "NEEDS_RESET".
>> + * Additional information supplied is tile id and gt id of the gt unit for
>> + * which reset has failed.
>> + */
>> +#define DRM_XE_RESET_FAILED_UEVENT "DEVICE_STATUS"
>
> Unrelated to this.... Aravind has a patch renaming this to make it
> future proof. We will need to either rename it now, or remove and leave
> its addition for later.

it was actual Himal who sent a patch to rework this.

@Himal what's your plan on this.

Thanks,
Aravind.
>
>
> Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
>
>
> Lucas De Marchi
>
>> /**
>>  * DOC: XE PMU event config IDs
>>  *
>> -- 
>> 2.34.1
>>