From: Jani Nikula <jani.nikula@intel.com>
To: Matt Roper <matthew.d.roper@intel.com>,
"Shankar, Uma" <uma.shankar@intel.com>
Cc: "intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
"ville.syrjala@linux.intel.com" <ville.syrjala@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Matthew Brost" <matthew.brost@intel.com>
Subject: Re: [PATCH] drm/xe/compat: Remove unused i915_reg.h from compat header
Date: Wed, 25 Feb 2026 20:11:37 +0200 [thread overview]
Message-ID: <09eb82885835ecea2f60c9eaba15bf58c13fb32e@intel.com> (raw)
In-Reply-To: <20260225174306.GQ4694@mdroper-desk1.amr.corp.intel.com>
On Wed, 25 Feb 2026, Matt Roper <matthew.d.roper@intel.com> wrote:
> On Wed, Feb 25, 2026 at 04:40:23PM +0000, Shankar, Uma wrote:
>> Pushed to drm-xe-next. Thanks for the review.
>
> Even though this is an Xe patch it might have been better to send this
> one through drm-intel-next rather than drm-xe-next since drm-xe-next
> doesn't have the prerequisite display patches yet to make this header
> removal possible. So at the moment the build of drm-xe-next is broken.
> Not a huge issue since drm-tip is fine, and drm-xe-next will likely be
> fixed soon whenever a backmerge happens, but I figured I should point it
> out.
On the contrary, I think it is an issue that warrants a revert.
It's a hard requirement that committers *always* build the branch they
apply patches to before pushing, no exceptions. CI doesn't guarantee
that at all.
With the build already broken, you can't do that, and more breakage can
slip in until it's fixed.
It'll take a drm-intel-next pull request to drm-next, and then a
drm-next backmerge to drm-xe-next to fix this, and we don't generally
want to rush that to hotfix build issues like this. The build failure
*before* pushing is an indication a backmerge might be needed, and
that's the normal order of things.
BR,
Jani.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2026-02-25 18:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 17:10 [PATCH] drm/xe/compat: Remove unused i915_reg.h from compat header Uma Shankar
2026-02-23 16:59 ` ✗ CI.checkpatch: warning for " Patchwork
2026-02-23 17:01 ` ✓ CI.KUnit: success " Patchwork
2026-02-24 13:07 ` [PATCH] " Jani Nikula
2026-02-24 13:25 ` Shankar, Uma
2026-02-25 16:40 ` Shankar, Uma
2026-02-25 17:43 ` Matt Roper
2026-02-25 18:11 ` Jani Nikula [this message]
2026-02-26 6:54 ` Shankar, Uma
2026-02-26 9:42 ` Jani Nikula
-- strict thread matches above, loose matches on Subject: below --
2026-02-26 17:55 Uma Shankar
2026-02-27 6:47 ` Shankar, Uma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09eb82885835ecea2f60c9eaba15bf58c13fb32e@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.brost@intel.com \
--cc=matthew.d.roper@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=thomas.hellstrom@linux.intel.com \
--cc=uma.shankar@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox