Re: [PATCH v2 1/3] drm/xe: Fix xe_vma_set_pte_size

["Thomas Hellström" <thomas.hellstrom@linux.intel.com>]

On Mon, 2024-02-19 at 13:19 -0800, Matthew Brost wrote:
> xe_vma_set_pte_size had a return value and did not set the 4k VMA
> flag.
> Both of these were incorrect. Fix these.
> 
> Fixes: c47794bdd63d ("drm/xe: Set max pte size when skipping
> rebinds")
> Signed-off-by: Matthew Brost <matthew.brost@intel.com>

Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>

> ---
>  drivers/gpu/drm/xe/xe_vm.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
> index 836a6e849cda..2b0c76c663e5 100644
> --- a/drivers/gpu/drm/xe/xe_vm.c
> +++ b/drivers/gpu/drm/xe/xe_vm.c
> @@ -2198,7 +2198,7 @@ static u64 xe_vma_max_pte_size(struct xe_vma
> *vma)
>  	return SZ_1G;	/* Uninitialized, used max size */
>  }
>  
> -static u64 xe_vma_set_pte_size(struct xe_vma *vma, u64 size)
> +static void xe_vma_set_pte_size(struct xe_vma *vma, u64 size)
>  {
>  	switch (size) {
>  	case SZ_1G:
> @@ -2207,9 +2207,10 @@ static u64 xe_vma_set_pte_size(struct xe_vma
> *vma, u64 size)
>  	case SZ_2M:
>  		vma->gpuva.flags |= XE_VMA_PTE_2M;
>  		break;
> +	case SZ_4K:
> +		vma->gpuva.flags |= XE_VMA_PTE_4K;
> +		break;
>  	}
> -
> -	return SZ_4K;
>  }
>  
>  static int xe_vma_op_commit(struct xe_vm *vm, struct xe_vma_op *op)