From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B9796CAC599 for ; Wed, 17 Sep 2025 07:23:20 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CF96210E41D; Wed, 17 Sep 2025 07:23:19 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="eOmwErMm"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by gabe.freedesktop.org (Postfix) with ESMTPS id DC0B910E175; Wed, 17 Sep 2025 07:23:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1758093798; x=1789629798; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=4hQ+mpeCJ8DOteiwqmho3Rl2rSlte6e1plRMV5LvIB0=; b=eOmwErMmj/w9bRi0yFRxRANwlFx6unScrdGpSk7e4MJdpli2l7fv3Jhq kn8D2mkdkp9o2AB/EZZPFtHRrKCuyx6j8IrsL20w+7TtDZ85sD/48uKFE IC7Qbbi6DIzN5520Rcb8p1g2x7uTbYE1EsOXEA73RLtRz0fdE17BFhr/U wWBdvJ+YchBLe9PZ0ePlN7RQBTqqzTCyqR1Gd6G5dV6/0xnkvag+VCTBw mqdWmR4AmYF3xliqL0ZnSbiUZRCH9Wh47llUfRllnR36gGxtmH4vDnOmX nsBDg/JUaOgFPQR9qIv2FHQABUKtO7Ld4sRUQ3vTvns/9gmxVr1Jco76I w==; X-CSE-ConnectionGUID: moi/OZvsSwyN0LoSRSr9Nw== X-CSE-MsgGUID: ++yW+24hSNKsODKlj4+qSg== X-IronPort-AV: E=McAfee;i="6800,10657,11555"; a="63024793" X-IronPort-AV: E=Sophos;i="6.18,271,1751266800"; d="scan'208";a="63024793" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Sep 2025 00:23:17 -0700 X-CSE-ConnectionGUID: 4x0ad1k1Q16stt/AubXU6g== X-CSE-MsgGUID: ka254H5OSG+CgA07h9gV6w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.18,271,1751266800"; d="scan'208";a="174458158" Received: from mjarzebo-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.246.135]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Sep 2025 00:23:15 -0700 From: Jani Nikula To: "Sebinraj, S" , "intel-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "intel-xe@lists.freedesktop.org" Cc: "Badrappan, Jeevaka" Subject: RE: [PATCH v3 3/3] drm/xe: Refactoring the code as per review comment In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20250916072704.2351591-1-s.sebinraj@intel.com> <20250916072704.2351591-4-s.sebinraj@intel.com> <4f495d7ee43a7ddc7ada573f8ab6f69c6e0011f4@intel.com> Date: Wed, 17 Sep 2025 10:23:11 +0300 Message-ID: <0c44364d65dc0155fd2c2da1d413160241cca767@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Wed, 17 Sep 2025, "Sebinraj, S" wrote: > On Tue, 16 Sep 2025, S Sebinraj wrote: >> Moved the trace file header to appropriate path "include/drm" and >> updated the code as per the same. > >> You're not supposed to address code review in independent patches but rather modify the original patches. This is kernel development basics. > >> BR, >> Jani. > > Okay got it, so now do I need to go back and make the changes in original patch and then raise again or this would be fine for now ? > Please let me know. You need to post the revised patches. 'git rebase -i' is your friend here. BR, Jani. -- Jani Nikula, Intel