Re: [PATCH] drm/xe/guc: Add support for NPK as a GuC log target

["Summers, Stuart" <stuart.summers@intel.com>]

On Wed, 2026-04-08 at 16:18 +0300, Jani Nikula wrote:
> On Tue, 07 Apr 2026, "Summers, Stuart" <stuart.summers@intel.com>
> wrote:
> > On Tue, 2026-04-07 at 11:48 +0200, Michal Wajdeczko wrote:
> > > 
> > > On 4/7/2026 12:53 AM, Stuart Summers wrote:
> > > > From: John Harrison <John.C.Harrison@Intel.com>
> > > > 
> > > > GuC provides the ability to gather logs through a hardware
> > > > interface
> > > > called NPK. For certain debugging scenarios this can be
> > > > advantageous
> > > > over getting logs from memory (or in addition to).
> > > > 
> > > > Add a hook for this alternate debugging mode via a configfs.
> > > > This
> > > > translates into a parameter passed to GuC during load time.
> > > > 
> > > > v2: Convert to configfs from modparam (Matt)
> > > > v3: Configfs documentation formatting (Shuicheng)
> > > >     Kerneldoc/comment add + configfs entry ordering
> > > >     Only set the guc_log_target when GuC log is enabled
> > > > (Daniele)
> > > 
> > > nit: we may keep change log under --- so it stays on the ML only
> > 
> > Ok makes sense I'll do that on the next upload.
> 
> Is this an intentional deviation from the quite prevalent drm
> subsystem
> style of including the changelog in the commit message?
> 
> I'm not dead set on either style personally, but I do not like
> conflicting review feedback, and people not knowing what to do.

I agree it would be nice to have consistency, whatever we decide. I
don't have a strong preference either way, although it is interesting
to me to see progression looking at the patch history - but we can get
the same looking at the mailing list archives which is probably even
more interesting.

Do we have a general recommendation here? I don't see anything in the
git format-patch section. The kernel canonical patch format
documentation [1] does mention this as a possibility, but not a
requirement (from my reading):
"""
One good use for the additional comments after the --- marker is for a
diffstat, to show what files have changed, and the number of inserted
and deleted lines per file. A diffstat is especially useful on bigger
patches. Other comments relevant only to the moment or the maintainer,
not suitable for the permanent changelog, should also go here. A good
example of such comments might be patch changelogs which describe what
has changed between the v1 and v2 version of the patch.
"""

[1]:
https://www.kernel.org/doc/html/v4.11/process/submitting-patches.html#the-canonical-patch-format

Thanks,
Stuart

> 
> 
> BR,
> Jani.
> 
>