From: Matthew Auld <matthew.auld@intel.com>
To: Nirmoy Das <nirmoy.das@intel.com>, intel-xe@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/xe: Add caller info to xe_gt_reset_async
Date: Wed, 16 Oct 2024 16:01:37 +0100 [thread overview]
Message-ID: <0fc813cb-e076-4431-830d-0f7508cea0e7@intel.com> (raw)
In-Reply-To: <20241016141717.881143-1-nirmoy.das@intel.com>
On 16/10/2024 15:17, Nirmoy Das wrote:
> Add caller info to the xe_gt_reset_async() to help debug issues.
>
> v2: s/%pS/%ps(Matt)
>
> Cc: Matthew Auld <matthew.auld@intel.com>
> Link: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2874
> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
> ---
> drivers/gpu/drm/xe/xe_gt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_gt.c b/drivers/gpu/drm/xe/xe_gt.c
> index 1c79660fb086..df2fe4005d85 100644
> --- a/drivers/gpu/drm/xe/xe_gt.c
> +++ b/drivers/gpu/drm/xe/xe_gt.c
> @@ -834,7 +834,7 @@ static void gt_reset_worker(struct work_struct *w)
>
> void xe_gt_reset_async(struct xe_gt *gt)
> {
> - xe_gt_info(gt, "trying reset\n");
> + xe_gt_info(gt, "trying reset from %ps\n", __builtin_return_address(0));
>
> /* Don't do a reset while one is already in flight */
> if (!xe_fault_inject_gt_reset() && xe_uc_reset_prepare(>->uc))
next prev parent reply other threads:[~2024-10-16 15:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 14:17 [PATCH v2] drm/xe: Add caller info to xe_gt_reset_async Nirmoy Das
2024-10-16 15:01 ` Matthew Auld [this message]
2024-10-16 15:10 ` ✓ CI.Patch_applied: success for drm/xe: Add caller info to xe_gt_reset_async (rev2) Patchwork
2024-10-16 15:11 ` ✓ CI.checkpatch: " Patchwork
2024-10-16 15:12 ` ✓ CI.KUnit: " Patchwork
2024-10-16 15:23 ` ✓ CI.Build: " Patchwork
2024-10-16 15:26 ` ✓ CI.Hooks: " Patchwork
2024-10-16 15:27 ` ✓ CI.checksparse: " Patchwork
2024-10-16 15:51 ` ✓ CI.BAT: " Patchwork
2024-10-17 7:13 ` ✗ CI.FULL: failure " Patchwork
2024-10-17 13:01 ` Nirmoy Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0fc813cb-e076-4431-830d-0f7508cea0e7@intel.com \
--to=matthew.auld@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=nirmoy.das@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox