Re: [PATCH] drm/xe: Remove fence check from send_tlb_invalidation

[Nirmoy Das <nirmoy.das@linux.intel.com>]

On 7/23/2024 9:07 PM, Matthew Brost wrote:
> 'fence' argument in send_tlb_invalidation cannot be NULL, remove
> non-NULL check from send_tlb_invalidation.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Closes: https://lore.kernel.org/r/202407231049.esig0Fkb-lkp@intel.com/
> Fixes: 61ac035361ae ("drm/xe: Drop xe_gt_tlb_invalidation_wait")
> Signed-off-by: Matthew Brost <matthew.brost@intel.com>

Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>


> ---
>   drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c b/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c
> index 481d83d07367..87cb76a8718c 100644
> --- a/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c
> +++ b/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c
> @@ -182,7 +182,7 @@ static int send_tlb_invalidation(struct xe_guc *guc,
>   	action[1] = seqno;
>   	ret = xe_guc_ct_send_locked(&guc->ct, action, len,
>   				    G2H_LEN_DW_TLB_INVALIDATE, 1);
> -	if (!ret && fence) {
> +	if (!ret) {
>   		spin_lock_irq(&gt->tlb_invalidation.pending_lock);
>   		/*
>   		 * We haven't actually published the TLB fence as per
> @@ -203,7 +203,7 @@ static int send_tlb_invalidation(struct xe_guc *guc,
>   						   tlb_timeout_jiffies(gt));
>   		}
>   		spin_unlock_irq(&gt->tlb_invalidation.pending_lock);
> -	} else if (ret < 0 && fence) {
> +	} else if (ret < 0) {
>   		__invalidation_fence_signal(xe, fence);
>   	}
>   	if (!ret) {