From: Riana Tauro <riana.tauro@intel.com>
To: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>,
<intel-xe@lists.freedesktop.org>
Subject: Re: [v2] drm/xe: Fix typo in vram frequency sysfs documentation
Date: Mon, 22 Jan 2024 12:38:20 +0530 [thread overview]
Message-ID: <11530813-d796-4e76-b268-2a020d7357f5@intel.com> (raw)
In-Reply-To: <20240117043215.2598677-1-sujaritha.sundaresan@intel.com>
On 1/17/2024 10:02 AM, Sujaritha Sundaresan wrote:
> Fix function naming and description for xe_vram_freq_sysfs_init
> function.
>
> v2: Add fixes tag (Riana)
> Fix review comments (Lucas)
>
> Fixes: 4ae3aeab32d7 ("drm/xe: Add vram frequency sysfs attributes")
> Signed-off-by: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
Looks good to me
Reviewed-by: Riana Tauro <riana.tauro@intel.com>
> ---
> drivers/gpu/drm/xe/xe_vram_freq.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_vram_freq.c b/drivers/gpu/drm/xe/xe_vram_freq.c
> index 733146293307..079cc283a186 100644
> --- a/drivers/gpu/drm/xe/xe_vram_freq.c
> +++ b/drivers/gpu/drm/xe/xe_vram_freq.c
> @@ -95,13 +95,12 @@ static void vram_freq_sysfs_fini(struct drm_device *drm, void *arg)
> kobject_put(kobj);
> }
>
> -/*
> - * xe_vram_freq_init - Initialize vram frequency component
> +/**
> + * xe_vram_freq_sysfs_init - Initialize vram frequency sysfs component
> * @tile: Xe Tile object
> *
> * It needs to be initialized after the main tile component is ready
> */
> -
> void xe_vram_freq_sysfs_init(struct xe_tile *tile)
> {
> struct xe_device *xe = tile_to_xe(tile);
next prev parent reply other threads:[~2024-01-22 7:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-17 4:32 [v2] drm/xe: Fix typo in vram frequency sysfs documentation Sujaritha Sundaresan
2024-01-17 4:20 ` ✓ CI.Patch_applied: success for drm/xe: Fix typo in vram frequency sysfs documentation (rev2) Patchwork
2024-01-17 4:20 ` ✗ CI.checkpatch: warning " Patchwork
2024-01-17 4:21 ` ✓ CI.KUnit: success " Patchwork
2024-01-17 4:28 ` ✓ CI.Build: " Patchwork
2024-01-17 4:28 ` ✓ CI.Hooks: " Patchwork
2024-01-17 4:30 ` ✓ CI.checksparse: " Patchwork
2024-01-17 16:04 ` ✓ CI.Patch_applied: " Patchwork
2024-01-17 16:04 ` ✗ CI.checkpatch: warning " Patchwork
2024-01-17 16:05 ` ✓ CI.KUnit: success " Patchwork
2024-01-17 16:12 ` ✓ CI.Build: " Patchwork
2024-01-17 16:13 ` ✓ CI.Hooks: " Patchwork
2024-01-17 16:14 ` ✓ CI.checksparse: " Patchwork
2024-01-17 16:37 ` ✓ CI.BAT: " Patchwork
2024-01-22 7:08 ` Riana Tauro [this message]
2024-01-24 4:00 ` [v2] drm/xe: Fix typo in vram frequency sysfs documentation Sundaresan, Sujaritha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11530813-d796-4e76-b268-2a020d7357f5@intel.com \
--to=riana.tauro@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=sujaritha.sundaresan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox