Re: [PATCH 1/3] drm/xe: trace bo create

["Ghimiray, Himal Prasad" <himal.prasad.ghimiray@intel.com>]

On 18-12-2024 22:18, Oak Zeng wrote:
> Add a tracepoint to trace bo create.
> 
> Signed-off-by: Oak Zeng <oak.zeng@intel.com>
> Reviewed-by: Matthew Brost <matthew.brost@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_bo.c       | 1 +
>   drivers/gpu/drm/xe/xe_trace_bo.h | 5 +++++
>   2 files changed, 6 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_bo.c b/drivers/gpu/drm/xe/xe_bo.c
> index abdeed1c325ea..61f4326e96504 100644
> --- a/drivers/gpu/drm/xe/xe_bo.c
> +++ b/drivers/gpu/drm/xe/xe_bo.c
> @@ -1649,6 +1649,7 @@ __xe_bo_create_locked(struct xe_device *xe,
>   		}
>   	}
>   
> +	trace_xe_bo_create(bo);
>   	return bo;
>   
>   err_unlock_put_bo:
> diff --git a/drivers/gpu/drm/xe/xe_trace_bo.h b/drivers/gpu/drm/xe/xe_trace_bo.h
> index 1762dd30ba6dc..53807f2ef4808 100644
> --- a/drivers/gpu/drm/xe/xe_trace_bo.h
> +++ b/drivers/gpu/drm/xe/xe_trace_bo.h
> @@ -53,6 +53,11 @@ DEFINE_EVENT(xe_bo, xe_bo_validate,
>   	     TP_ARGS(bo)
>   );
>   
> +DEFINE_EVENT(xe_bo, xe_bo_create,
> +	     TP_PROTO(struct xe_bo *bo),
> +	     TP_ARGS(bo)
> +);
> +

Looks good.
Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>

>   TRACE_EVENT(xe_bo_move,
>   	    TP_PROTO(struct xe_bo *bo, uint32_t new_placement, uint32_t old_placement,
>   		     bool move_lacks_source),