Re: [PATCH v3 08/10] drm/xe/xe_ras: Add structures for SoC Internal errors

Tauro, Riana
2026-04-13T07:56:21Z

On 4/8/2026 4:48 PM, Raag Jadav wrote:
> On Thu, Apr 02, 2026 at 12:31:39PM +0530, Riana Tauro wrote:
>> Add response structures for SoC Internal errors.
> This looks like should be squashed with next patch, or did I miss something?
Yeah it can be combined. Will squash it in next rev

Thanks
Riana
>
> Raag
>
>> Signed-off-by: Riana Tauro <riana.tauro@intel.com>
>> ---
>> v2: simplify soc structures
>> ---
>> drivers/gpu/drm/xe/xe_ras_types.h | 51 +++++++++++++++++++++++++++++++
>> 1 file changed, 51 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/xe/xe_ras_types.h b/drivers/gpu/drm/xe/xe_ras_types.h
>> index e37dd12bffa3..65158bf716a7 100644
>> --- a/drivers/gpu/drm/xe/xe_ras_types.h
>> +++ b/drivers/gpu/drm/xe/xe_ras_types.h
>> @@ -10,6 +10,7 @@
>>
>> #define XE_RAS_NUM_ERROR_ARR 3
>> #define XE_RAS_MAX_ERROR_DETAILS 16
>> +#define XE_RAS_IEH_PUNIT_ERROR BIT(1)
>>
>> /**
>> * enum xe_ras_recovery_action - RAS recovery actions
>> @@ -149,4 +150,54 @@ struct xe_ras_compute_error {
>> u32 spare_log3;
>> } __packed;
>>
>> +/**
>> + * struct xe_ras_soc_error_source - Source of SOC error
>> + */
>> +struct xe_ras_soc_error_source {
>> + /** @csc: CSC error */
>> + u32 csc:1;
>> + /** @soc: SOC error */
>> + u32 soc:1;
>> + /** @reserved: Reserved for future use */
>> + u32 reserved:30;
>> +} __packed;
>> +
>> +/**
>> + * struct xe_ras_soc_error - SOC error details
>> + */
>> +struct xe_ras_soc_error {
>> + /** @error_source: Error Source */
>> + struct xe_ras_soc_error_source error_source;
>> + /** @additional_details: Additional details */
>> + u32 additional_details[15];
>> +} __packed;
>> +
>> +/**
>> + * struct xe_ras_csc_error - CSC error details
>> + */
>> +struct xe_ras_csc_error {
>> + /** @hec_uncorr_err_status: CSC error */
>> + u32 hec_uncorr_err_status;
>> + /** @hec_uncorr_fw_err_dw0: CSC f/w error */
>> + u32 hec_uncorr_fw_err_dw0;
>> +} __packed;
>> +
>> +/**
>> + * struct xe_ras_ieh_error - SoC IEH (Integrated Error Handler) details
>> + */
>> +struct xe_ras_ieh_error {
>> + /** @ieh_instance: IEH instance */
>> + u32 ieh_instance:2;
>> + /** @reserved: Reserved for future use */
>> + u32 reserved:30;
>> + /** @global_error_status: Global error status */
>> + u32 global_error_status;
>> + /** @local_error_status: Local error status */
>> + u32 local_error_status;
>> + /** @gerr_mask: Global error mask */
>> + u32 gerr_mask;
>> + /** @additional_info: Additional information */
>> + u32 additional_info[10];
>> +} __packed;
>> +
>> #endif
>> --
>> 2.47.1
>>