Re: [PATCH 11/12] drm/i915/mchbar: Use intel_de_read*() for MCHBAR register accesses

[Jani Nikula <jani.nikula@linux.intel.com>]

On Wed, 25 Mar 2026, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Replace the naked intel_uncore_read*() with intel_de_read*()
> in the MCHBAR code.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_mchbar.c | 14 ++++----------
>  1 file changed, 4 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_mchbar.c b/drivers/gpu/drm/i915/display/intel_mchbar.c
> index 82b47c00101a..da74147f471e 100644
> --- a/drivers/gpu/drm/i915/display/intel_mchbar.c
> +++ b/drivers/gpu/drm/i915/display/intel_mchbar.c
> @@ -7,10 +7,10 @@
>  
>  #include <drm/drm_print.h>
>  
> +#include "intel_de.h"
>  #include "intel_display_core.h"
>  #include "intel_mchbar.h"
>  #include "intel_mchbar_regs.h"
> -#include "intel_uncore.h"
>  
>  static bool has_mchbar_mirror(struct intel_display *display)
>  {
> @@ -53,29 +53,23 @@ static bool is_mchbar_reg(struct intel_display *display, i915_reg_t reg)
>  u16 intel_mchbar_read16(struct intel_display *display,
>  			i915_reg_t reg)
>  {
> -	struct intel_uncore *uncore = to_intel_uncore(display->drm);
> -
>  	drm_WARN_ON(display->drm, !is_mchbar_reg(display, reg));
>  
> -	return intel_uncore_read16(uncore, reg);
> +	return intel_de_read16(display, reg);
>  }
>  
>  u32 intel_mchbar_read(struct intel_display *display,
>  		      i915_reg_t reg)
>  {
> -	struct intel_uncore *uncore = to_intel_uncore(display->drm);
> -
>  	drm_WARN_ON(display->drm, !is_mchbar_reg(display, reg));
>  
> -	return intel_uncore_read(uncore, reg);
> +	return intel_de_read(display, reg);
>  }
>  
>  u64 intel_mchbar_read64(struct intel_display *display,
>  			i915_reg_t reg)
>  {
> -	struct intel_uncore *uncore = to_intel_uncore(display->drm);
> -
>  	drm_WARN_ON(display->drm, !is_mchbar_reg(display, reg));
>  
> -	return intel_uncore_read64(uncore, reg);
> +	return intel_de_read64_2x32(display, reg);
>  }

-- 
Jani Nikula, Intel