From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 375BF10A1E7E for ; Thu, 26 Mar 2026 11:44:08 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E5E3310E985; Thu, 26 Mar 2026 11:44:07 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="GW7KOjmN"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id 84C5410E984; Thu, 26 Mar 2026 11:44:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1774525446; x=1806061446; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=0vD/C9vDNM7vTA6VT0Cy2gjLtI1jDLYpRbCuTgJ21sQ=; b=GW7KOjmN3lzmImE1tqmwuXY4gQZ+TCmwptiZgkQ3n8oS5Vns27c3bAW+ ik4OscrHlGR2wuFXe8odVWM4xHF8vPr6tPXw1mdhPC6OMcgCKdp77ttY3 xul3csg16cvdwHLsifNh/7Id180HK3e4zVhC3ApUkxyITYWADJO6wRYDl /3zpMHHVAuOgVVcJ1Z/PTcsNA7Si0pJAhJ67m+CgGdYfcJdaEs4c6KL5R 9hNjIaqUHfNaOpbya2fU5bS3SI/xRozzlFV1HPiSU+Op+sCe28QvaCI65 Z9Cw7NybrexBtExfmfioKg/2lsLhinYWM1ishWPHuelOhfxT+iVy6OENJ Q==; X-CSE-ConnectionGUID: UYGHaFa0SGGW7+DNjeu0ww== X-CSE-MsgGUID: jWem+ff/R0SULxMPG2D93A== X-IronPort-AV: E=McAfee;i="6800,10657,11740"; a="92959116" X-IronPort-AV: E=Sophos;i="6.23,142,1770624000"; d="scan'208";a="92959116" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2026 04:44:06 -0700 X-CSE-ConnectionGUID: gHb+3o0PTV+VcCymqdJHWA== X-CSE-MsgGUID: d91V1hItSwe9YMiwC7ozFg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,142,1770624000"; d="scan'208";a="221676719" Received: from carterle-desk.ger.corp.intel.com (HELO localhost) ([10.245.246.184]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2026 04:44:04 -0700 From: Jani Nikula To: Ville Syrjala , intel-gfx@lists.freedesktop.org Cc: intel-xe@lists.freedesktop.org Subject: Re: [PATCH 11/12] drm/i915/mchbar: Use intel_de_read*() for MCHBAR register accesses In-Reply-To: <20260325185342.11482-12-ville.syrjala@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland References: <20260325185342.11482-1-ville.syrjala@linux.intel.com> <20260325185342.11482-12-ville.syrjala@linux.intel.com> Date: Thu, 26 Mar 2026 13:44:00 +0200 Message-ID: <15e3d586adcfd3188b4753518757477dfcfaecd9@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Wed, 25 Mar 2026, Ville Syrjala wrote: > From: Ville Syrj=C3=A4l=C3=A4 > > Replace the naked intel_uncore_read*() with intel_de_read*() > in the MCHBAR code. > > Signed-off-by: Ville Syrj=C3=A4l=C3=A4 Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_mchbar.c | 14 ++++---------- > 1 file changed, 4 insertions(+), 10 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_mchbar.c b/drivers/gpu/dr= m/i915/display/intel_mchbar.c > index 82b47c00101a..da74147f471e 100644 > --- a/drivers/gpu/drm/i915/display/intel_mchbar.c > +++ b/drivers/gpu/drm/i915/display/intel_mchbar.c > @@ -7,10 +7,10 @@ >=20=20 > #include >=20=20 > +#include "intel_de.h" > #include "intel_display_core.h" > #include "intel_mchbar.h" > #include "intel_mchbar_regs.h" > -#include "intel_uncore.h" >=20=20 > static bool has_mchbar_mirror(struct intel_display *display) > { > @@ -53,29 +53,23 @@ static bool is_mchbar_reg(struct intel_display *displ= ay, i915_reg_t reg) > u16 intel_mchbar_read16(struct intel_display *display, > i915_reg_t reg) > { > - struct intel_uncore *uncore =3D to_intel_uncore(display->drm); > - > drm_WARN_ON(display->drm, !is_mchbar_reg(display, reg)); >=20=20 > - return intel_uncore_read16(uncore, reg); > + return intel_de_read16(display, reg); > } >=20=20 > u32 intel_mchbar_read(struct intel_display *display, > i915_reg_t reg) > { > - struct intel_uncore *uncore =3D to_intel_uncore(display->drm); > - > drm_WARN_ON(display->drm, !is_mchbar_reg(display, reg)); >=20=20 > - return intel_uncore_read(uncore, reg); > + return intel_de_read(display, reg); > } >=20=20 > u64 intel_mchbar_read64(struct intel_display *display, > i915_reg_t reg) > { > - struct intel_uncore *uncore =3D to_intel_uncore(display->drm); > - > drm_WARN_ON(display->drm, !is_mchbar_reg(display, reg)); >=20=20 > - return intel_uncore_read64(uncore, reg); > + return intel_de_read64_2x32(display, reg); > } --=20 Jani Nikula, Intel