RE: [PATCH] drm/xe: Use IS_ENABLED() for config checks instead of defined()

[Jani Nikula <jani.nikula@linux.intel.com>]

On Mon, 01 Dec 2025, "Upadhyay, Tejas" <tejas.upadhyay@intel.com> wrote:
>> -----Original Message-----
>> From: Intel-xe <intel-xe-bounces@lists.freedesktop.org> On Behalf Of Nitin
>> Gote
>> Sent: 27 November 2025 22:37
>> To: intel-xe@lists.freedesktop.org
>> Cc: Piorkowski, Piotr <piotr.piorkowski@intel.com>; Gote, Nitin R
>> <nitin.r.gote@intel.com>
>> Subject: [PATCH] drm/xe: Use IS_ENABLED() for config checks instead of
>> defined()
>> 
>> Prefer IS_ENABLED() instead of defined() for checking whether a kconfig
>> option is enabled.
>
> Add little info why

That's just what you're supposed to do. ;)

BR,
Jani.



>
> Tejas
>> 
>> Signed-off-by: Nitin Gote <nitin.r.gote@intel.com>
>> ---
>>  drivers/gpu/drm/xe/xe_vram.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/gpu/drm/xe/xe_vram.c b/drivers/gpu/drm/xe/xe_vram.c
>> index 0a645e76e5fa..8fac1cc08dc9 100644
>> --- a/drivers/gpu/drm/xe/xe_vram.c
>> +++ b/drivers/gpu/drm/xe/xe_vram.c
>> @@ -325,7 +325,7 @@ struct xe_vram_region *xe_vram_region_alloc(struct
>> xe_device *xe, u8 id, u32 pla
>>  	vram->xe = xe;
>>  	vram->id = id;
>>  	vram->placement = placement;
>> -#if defined(CONFIG_DRM_XE_PAGEMAP)
>> +#if IS_ENABLED(CONFIG_DRM_XE_PAGEMAP)
>>  	vram->migrate = xe->tiles[id].migrate;  #endif
>>  	return vram;
>> --
>> 2.50.1
>

-- 
Jani Nikula, Intel