From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Daniele Ceraolo Spurio" <daniele.ceraolospurio@intel.com>
Cc: intel-xe@lists.freedesktop.org
Subject: ✓ CI.checkpatch: success for drm/xe: Always check force_wake_get return code
Date: Tue, 12 Mar 2024 19:47:50 -0000 [thread overview]
Message-ID: <171027287086.714563.4606933362160873568@8e613ede5ea5> (raw)
In-Reply-To: <20240312194256.965685-1-daniele.ceraolospurio@intel.com>
== Series Details ==
Series: drm/xe: Always check force_wake_get return code
URL : https://patchwork.freedesktop.org/series/131045/
State : success
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
a9eb1ac8298ef9f9146567c29fa762d8e9efa1ef
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 964b543647f22cdc5df975d1a8857ce955dd56f1
Author: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Date: Tue Mar 12 12:42:56 2024 -0700
drm/xe: Always check force_wake_get return code
A force_wake_get failure means that the HW might not be awake for the
access we're doing; this can lead to an immediate error or it can be a
more subtle problem (e.g. a register read might return an incorrect
value that is still valid, leading the driver to make a wrong choice
instead of flagging an error).
We avoid an error from the force_wake function because callers might
handle or tolerate the error, but this only works if all callers
are checking the error code. The majority already do, but a few are not.
These are mainly falling into 3 categories, which are each handled
differently:
1) error capture: in this case we want to continue the capture, but we
log an info message in dmesg to notify the user that the capture
might have incorrect data.
2) ioctl: in this case we return a -EIO error to userspace
3) unabortable actions: these are scenarios where we can't simply abort
and retry and so it's better to just try it anyway because there is a
chance the HW is awake even with the failure. In this case we throw a
warning so we know there was a forcewake problem if something fails
down the line.
Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Tejas Upadhyay <tejas.upadhyay@intel.com>
+ /mt/dim checkpatch 1dfbf3ced62236dd318c701e3f21f5a33c226d0d drm-intel
964b543647f2 drm/xe: Always check force_wake_get return code
next prev parent reply other threads:[~2024-03-12 19:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-12 19:42 [PATCH] drm/xe: Always check force_wake_get return code Daniele Ceraolo Spurio
2024-03-12 19:47 ` ✓ CI.Patch_applied: success for " Patchwork
2024-03-12 19:47 ` Patchwork [this message]
2024-03-12 19:48 ` ✓ CI.KUnit: " Patchwork
2024-03-12 19:59 ` ✓ CI.Build: " Patchwork
2024-03-12 20:02 ` ✓ CI.Hooks: " Patchwork
2024-03-12 20:03 ` ✓ CI.checksparse: " Patchwork
2024-03-12 20:22 ` ✓ CI.BAT: " Patchwork
2024-03-12 23:07 ` [PATCH] " Matt Roper
2024-03-13 8:31 ` Jani Nikula
2024-03-13 14:24 ` Daniele Ceraolo Spurio
2024-03-13 14:56 ` Jani Nikula
2024-03-13 17:35 ` Daniele Ceraolo Spurio
2024-03-14 10:58 ` Upadhyay, Tejas
2024-03-14 13:53 ` Daniele Ceraolo Spurio
2024-03-14 14:12 ` Upadhyay, Tejas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171027287086.714563.4606933362160873568@8e613ede5ea5 \
--to=patchwork@emeril.freedesktop.org \
--cc=daniele.ceraolospurio@intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox