From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 21F18C25B76 for ; Thu, 6 Jun 2024 00:24:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CF85310E4D1; Thu, 6 Jun 2024 00:24:39 +0000 (UTC) Received: from a6498e030952 (emeril.freedesktop.org [131.252.210.167]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4645C10E4D1; Thu, 6 Jun 2024 00:24:38 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: =?utf-8?q?=E2=9C=97_CI=2Echeckpatch=3A_warning_for_Tracing_cleanup_and_add_m?= =?utf-8?q?mio_tracing_=28rev2=29?= From: Patchwork To: "Radhakrishna Sripada" Cc: intel-xe@lists.freedesktop.org Date: Thu, 06 Jun 2024 00:24:38 -0000 Message-ID: <171763347828.79.16039142299212186730@a6498e030952> X-Patchwork-Hint: ignore References: <20240606001814.3460974-1-radhakrishna.sripada@intel.com> In-Reply-To: <20240606001814.3460974-1-radhakrishna.sripada@intel.com> X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: intel-xe@lists.freedesktop.org Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" == Series Details == Series: Tracing cleanup and add mmio tracing (rev2) URL : https://patchwork.freedesktop.org/series/134258/ State : warning == Summary == + KERNEL=/kernel + git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt Cloning into 'mt'... warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/ + git -C mt rev-list -n1 origin/master 51ce9f6cd981d42d7467409d7dbc559a450abc1e + cd /kernel + git config --global --add safe.directory /kernel + git log -n1 commit 3cff5385b720d876cec8cf9919abff28396842be Author: Radhakrishna Sripada Date: Wed Jun 5 17:18:14 2024 -0700 drm/xe: Add reg read/write trace This will help debug register read/writes and provides a way to trace all the mmio transactions. v2: Fix kunit error v3: Print devid to help in multi-gpu setup v3: rebase and use variable sized variant to display dev name(Gustavo) Cc: Gustavo Sousa Signed-off-by: Radhakrishna Sripada + /mt/dim checkpatch a494545483635d3d93d19e8f483f61e7d4198383 drm-intel 32ce818ed2c3 drm/xe/trace: Extract bo, vm, vma traces Traceback (most recent call last): File "scripts/spdxcheck.py", line 6, in from ply import lex, yacc ModuleNotFoundError: No module named 'ply' Traceback (most recent call last): File "scripts/spdxcheck.py", line 6, in from ply import lex, yacc ModuleNotFoundError: No module named 'ply' -:305: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #305: new file mode 100644 -:347: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #347: FILE: drivers/gpu/drm/xe/xe_trace_bo.h:23: + TP_STRUCT__entry( -:353: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #353: FILE: drivers/gpu/drm/xe/xe_trace_bo.h:29: + TP_fast_assign( -:372: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #372: FILE: drivers/gpu/drm/xe/xe_trace_bo.h:48: + TP_STRUCT__entry( -:381: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #381: FILE: drivers/gpu/drm/xe/xe_trace_bo.h:57: + TP_fast_assign( -:399: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #399: FILE: drivers/gpu/drm/xe/xe_trace_bo.h:75: + TP_STRUCT__entry( -:407: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #407: FILE: drivers/gpu/drm/xe/xe_trace_bo.h:83: + TP_fast_assign( -:499: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #499: FILE: drivers/gpu/drm/xe/xe_trace_bo.h:175: + TP_STRUCT__entry( -:504: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #504: FILE: drivers/gpu/drm/xe/xe_trace_bo.h:180: + TP_fast_assign( -:558: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #558: FILE: drivers/gpu/drm/xe/xe_trace_bo.h:234: +#define TRACE_INCLUDE_PATH ../../drivers/gpu/drm/xe ^ -:558: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #558: FILE: drivers/gpu/drm/xe/xe_trace_bo.h:234: +#define TRACE_INCLUDE_PATH ../../drivers/gpu/drm/xe ^ -:558: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #558: FILE: drivers/gpu/drm/xe/xe_trace_bo.h:234: +#define TRACE_INCLUDE_PATH ../../drivers/gpu/drm/xe ^ -:558: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #558: FILE: drivers/gpu/drm/xe/xe_trace_bo.h:234: +#define TRACE_INCLUDE_PATH ../../drivers/gpu/drm/xe ^ -:558: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #558: FILE: drivers/gpu/drm/xe/xe_trace_bo.h:234: +#define TRACE_INCLUDE_PATH ../../drivers/gpu/drm/xe ^ total: 0 errors, 1 warnings, 13 checks, 514 lines checked 9263ef6c559c drm/xe/trace: Extract guc related traces Traceback (most recent call last): File "scripts/spdxcheck.py", line 6, in from ply import lex, yacc ModuleNotFoundError: No module named 'ply' Traceback (most recent call last): File "scripts/spdxcheck.py", line 6, in from ply import lex, yacc ModuleNotFoundError: No module named 'ply' -:133: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #133: new file mode 100644 -:173: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #173: FILE: drivers/gpu/drm/xe/xe_trace_guc.h:21: + TP_STRUCT__entry( -:181: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #181: FILE: drivers/gpu/drm/xe/xe_trace_guc.h:29: + TP_fast_assign( -:212: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #212: FILE: drivers/gpu/drm/xe/xe_trace_guc.h:60: + TP_STRUCT__entry( -:220: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #220: FILE: drivers/gpu/drm/xe/xe_trace_guc.h:68: + TP_fast_assign( -:253: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #253: FILE: drivers/gpu/drm/xe/xe_trace_guc.h:101: +#define TRACE_INCLUDE_PATH ../../drivers/gpu/drm/xe ^ -:253: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #253: FILE: drivers/gpu/drm/xe/xe_trace_guc.h:101: +#define TRACE_INCLUDE_PATH ../../drivers/gpu/drm/xe ^ -:253: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #253: FILE: drivers/gpu/drm/xe/xe_trace_guc.h:101: +#define TRACE_INCLUDE_PATH ../../drivers/gpu/drm/xe ^ -:253: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #253: FILE: drivers/gpu/drm/xe/xe_trace_guc.h:101: +#define TRACE_INCLUDE_PATH ../../drivers/gpu/drm/xe ^ -:253: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #253: FILE: drivers/gpu/drm/xe/xe_trace_guc.h:101: +#define TRACE_INCLUDE_PATH ../../drivers/gpu/drm/xe ^ total: 0 errors, 1 warnings, 9 checks, 213 lines checked 10e06e0bd34f drm/xe/trace: Print device_id in xe_trace_bo events d47381bed5f9 drm/xe/trace: Print device_id in xe_trace_guc events -:90: WARNING:LONG_LINE: line length of 103 exceeds 100 columns #90: FILE: drivers/gpu/drm/xe/xe_trace_guc.h:22: + TP_PROTO(struct xe_device *xe, u32 _head, u32 _tail, u32 size, u32 space, u32 len), -:127: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #127: FILE: drivers/gpu/drm/xe/xe_trace_guc.h:54: + TP_PROTO(struct xe_device *xe, u32 _head, u32 _tail, u32 size, u32 space, u32 len), -:140: WARNING:LONG_LINE: line length of 103 exceeds 100 columns #140: FILE: drivers/gpu/drm/xe/xe_trace_guc.h:63: + TP_PROTO(struct xe_device *xe, u8 gt_id, u32 action, u32 len, u32 _head, u32 tail), -:177: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #177: FILE: drivers/gpu/drm/xe/xe_trace_guc.h:95: + TP_PROTO(struct xe_device *xe, u8 gt_id, u32 action, u32 len, u32 _head, u32 tail), total: 0 errors, 4 warnings, 0 checks, 149 lines checked 599c07ecda36 drm/xe/trace: Print device_id in xe_trace events -:328: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #328: FILE: drivers/gpu/drm/xe/xe_trace.h:282: + __string(dev, __dev_name_eq(((struct xe_exec_queue *)msg->private_data))) -:334: WARNING:LONG_LINE: line length of 106 exceeds 100 columns #334: FILE: drivers/gpu/drm/xe/xe_trace.h:288: + __assign_str(dev, __dev_name_eq(((struct xe_exec_queue *)msg->private_data))); total: 0 errors, 2 warnings, 0 checks, 313 lines checked 3cff5385b720 drm/xe: Add reg read/write trace -:93: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #93: FILE: drivers/gpu/drm/xe/xe_trace.h:351: +TRACE_EVENT(xe_reg_rw, + TP_PROTO(struct xe_gt *gt, bool write, u32 reg, u64 val, int len), -:97: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #97: FILE: drivers/gpu/drm/xe/xe_trace.h:355: + TP_STRUCT__entry( -:105: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #105: FILE: drivers/gpu/drm/xe/xe_trace.h:363: + TP_fast_assign( total: 0 errors, 0 warnings, 3 checks, 93 lines checked