Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Sebastian Andrzej Siewior" <bigeasy@linutronix.de>
Cc: intel-xe@lists.freedesktop.org
Subject: ✗ CI.checkpatch: warning for drm/i915: PREEMPT_RT related fixups. (rev3)
Date: Thu, 13 Jun 2024 11:52:48 -0000	[thread overview]
Message-ID: <171827956815.72831.12830786515641663225@a6498e030952> (raw)
In-Reply-To: <20240613102818.4056866-1-bigeasy@linutronix.de>

== Series Details ==

Series: drm/i915: PREEMPT_RT related fixups. (rev3)
URL   : https://patchwork.freedesktop.org/series/132082/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
51ce9f6cd981d42d7467409d7dbc559a450abc1e
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 8828334cac627b726c3f5b1eedeb1ed525693ac7
Author: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Date:   Thu Jun 13 12:20:25 2024 +0200

    Revert "drm/i915: Depend on !PREEMPT_RT."
    
    Once the known issues are addressed, it should be safe to enable the
    driver.
    
    Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
+ /mt/dim checkpatch 9f3ced27c8deae54c79db1743e37d2935558e048 drm-intel
a3292fdac182 drm/i915: Use preempt_disable/enable_rt() where recommended
-:7: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#7: 
  ad3543ede630f ("drm/intel: Push get_scanout_position() timestamping into kms driver.")

total: 0 errors, 1 warnings, 0 checks, 67 lines checked
264f4286831c drm/i915: Don't disable interrupts on PREEMPT_RT during atomic updates
-:10: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#10: 
started disabling interrupts across atomic updates. This breaks on PREEMPT_RT

total: 0 errors, 1 warnings, 0 checks, 42 lines checked
499bb09223af drm/i915: Don't check for atomic context on PREEMPT_RT
95c79fb5f8f4 drm/i915: Disable tracing points on PREEMPT_RT
-:26: WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be immediately followed by Closes: with a URL to the report
#26: 
Reported-by: Luca Abeni <lucabe72@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>

total: 0 errors, 1 warnings, 0 checks, 20 lines checked
3888f3997885 drm/i915/gt: Use spin_lock_irq() instead of local_irq_disable() + spin_lock()
-:22: WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be immediately followed by Closes: with a URL to the report
#22: 
Reported-by: Clark Williams <williams@redhat.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

total: 0 errors, 1 warnings, 0 checks, 53 lines checked
e6ffe1fa41ca drm/i915: Drop the irqs_disabled() check
-:16: WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be immediately followed by Closes: with a URL to the report
#16: 
Reported-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

total: 0 errors, 1 warnings, 0 checks, 14 lines checked
7423ea1204f3 drm/i915/guc: Consider also RCU depth in busy loop.
-:13: WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be immediately followed by Closes: with a URL to the report
#13: 
Reported-by: "John B. Wyatt IV" <jwyatt@redhat.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

-:26: ERROR:IN_ATOMIC: do not use in_atomic in drivers
#26: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc.h:365:
+	bool not_atomic = !in_atomic() && !irqs_disabled() && !rcu_preempt_depth();

total: 1 errors, 1 warnings, 0 checks, 8 lines checked
8828334cac62 Revert "drm/i915: Depend on !PREEMPT_RT."



  parent reply	other threads:[~2024-06-13 11:52 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-13 10:20 [PATCH v2 0/8] drm/i915: PREEMPT_RT related fixups Sebastian Andrzej Siewior
2024-06-13 10:20 ` [PATCH v2 1/8] drm/i915: Use preempt_disable/enable_rt() where recommended Sebastian Andrzej Siewior
2024-06-13 10:20 ` [PATCH v2 2/8] drm/i915: Don't disable interrupts on PREEMPT_RT during atomic updates Sebastian Andrzej Siewior
2024-06-13 10:20 ` [PATCH v2 3/8] drm/i915: Don't check for atomic context on PREEMPT_RT Sebastian Andrzej Siewior
2024-06-14  8:32   ` Tvrtko Ursulin
2024-06-14 11:05     ` Sebastian Andrzej Siewior
2024-06-14 12:19       ` Tvrtko Ursulin
2024-06-17 10:07         ` Sebastian Andrzej Siewior
2024-06-18  9:00           ` Tvrtko Ursulin
2024-06-18 12:54             ` Sebastian Andrzej Siewior
2024-06-19 10:26               ` Tvrtko Ursulin
2024-06-13 10:20 ` [PATCH v2 4/8] drm/i915: Disable tracing points " Sebastian Andrzej Siewior
2024-06-19 10:27   ` Tvrtko Ursulin
2024-06-13 10:20 ` [PATCH v2 5/8] drm/i915/gt: Use spin_lock_irq() instead of local_irq_disable() + spin_lock() Sebastian Andrzej Siewior
2024-06-13 10:20 ` [PATCH v2 6/8] drm/i915: Drop the irqs_disabled() check Sebastian Andrzej Siewior
2024-06-19 10:28   ` Tvrtko Ursulin
2024-06-13 10:20 ` [PATCH v2 7/8] drm/i915/guc: Consider also RCU depth in busy loop Sebastian Andrzej Siewior
2024-06-13 10:20 ` [PATCH v2 8/8] Revert "drm/i915: Depend on !PREEMPT_RT." Sebastian Andrzej Siewior
2024-06-19 10:29   ` Tvrtko Ursulin
2024-06-13 11:52 ` ✓ CI.Patch_applied: success for drm/i915: PREEMPT_RT related fixups. (rev3) Patchwork
2024-06-13 11:52 ` Patchwork [this message]
2024-06-13 11:53 ` ✓ CI.KUnit: " Patchwork
2024-06-13 12:05 ` ✓ CI.Build: " Patchwork
2024-06-13 12:07 ` ✗ CI.Hooks: failure " Patchwork
2024-06-13 12:09 ` ✗ CI.checksparse: warning " Patchwork
2024-06-13 12:31 ` ✓ CI.BAT: success " Patchwork
2024-06-13 14:34 ` ✓ CI.FULL: " Patchwork
2024-06-17 10:12 ` ✓ CI.Patch_applied: success for drm/i915: PREEMPT_RT related fixups. (rev4) Patchwork
2024-06-17 10:12 ` ✗ CI.checkpatch: warning " Patchwork
2024-06-17 10:13 ` ✓ CI.KUnit: success " Patchwork
2024-06-17 10:26 ` ✓ CI.Build: " Patchwork
2024-06-17 10:30 ` ✗ CI.Hooks: failure " Patchwork
2024-06-17 10:32 ` ✗ CI.checksparse: warning " Patchwork
2024-06-17 10:54 ` ✓ CI.BAT: success " Patchwork
2024-06-17 16:35 ` ✓ CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=171827956815.72831.12830786515641663225@a6498e030952 \
    --to=patchwork@emeril.freedesktop.org \
    --cc=bigeasy@linutronix.de \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox