Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Michal Wajdeczko" <michal.wajdeczko@intel.com>
Cc: intel-xe@lists.freedesktop.org
Subject: ✗ CI.checkpatch: warning for drm/xe/kunit: Simplify live tests code layout
Date: Mon, 08 Jul 2024 11:18:35 -0000	[thread overview]
Message-ID: <172043751545.49182.1205510070316770749@2413ebb6fbb6> (raw)
In-Reply-To: <20240708111210.1154-1-michal.wajdeczko@intel.com>

== Series Details ==

Series: drm/xe/kunit: Simplify live tests code layout
URL   : https://patchwork.freedesktop.org/series/135839/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
51ce9f6cd981d42d7467409d7dbc559a450abc1e
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 0484df0e00d607dd7529398d21309c69c38adb69
Author: Michal Wajdeczko <michal.wajdeczko@intel.com>
Date:   Mon Jul 8 13:12:10 2024 +0200

    drm/xe/kunit: Simplify xe_mocs live tests code layout
    
    The test case logic is implemented by the functions compiled as
    part of the core Xe driver module and then exported to build and
    register the test suite in the live test module.
    
    But we don't need to export individual test case functions, we may
    just export the entire test suite. And we don't need to register
    this test suite in a separate file, it can be done in the main
    file of the live test module.
    
    Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
+ /mt/dim checkpatch 414cc5961337b50dd261349b4ed7aa0013044ccf drm-intel
c3ff109865a6 drm/xe/kunit: Simplify xe_bo live tests code layout
-:78: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#78: 
deleted file mode 100644

total: 0 errors, 1 warnings, 0 checks, 59 lines checked
45cab2497780 drm/xe/kunit: Simplify xe_dma_buf live tests code layout
-:64: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#64: 
deleted file mode 100644

-:116: WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#116: FILE: drivers/gpu/drm/xe/tests/xe_live_test_mod.c:9:
+extern struct kunit_suite xe_dma_buf_test_suite;

total: 0 errors, 2 warnings, 0 checks, 45 lines checked
6ae39c3dc2ee drm/xe/kunit: Simplify xe_migrate live tests code layout
-:37: WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#37: FILE: drivers/gpu/drm/xe/tests/xe_live_test_mod.c:10:
+extern struct kunit_suite xe_migrate_test_suite;

-:80: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#80: 
deleted file mode 100644

total: 0 errors, 2 warnings, 0 checks, 46 lines checked
0484df0e00d6 drm/xe/kunit: Simplify xe_mocs live tests code layout
-:39: WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#39: FILE: drivers/gpu/drm/xe/tests/xe_live_test_mod.c:11:
+extern struct kunit_suite xe_mocs_test_suite;

-:97: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#97: 
deleted file mode 100644

total: 0 errors, 2 warnings, 0 checks, 62 lines checked



  parent reply	other threads:[~2024-07-08 11:18 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-08 11:12 [PATCH 0/4] drm/xe/kunit: Simplify live tests code layout Michal Wajdeczko
2024-07-08 11:12 ` [PATCH 1/4] drm/xe/kunit: Simplify xe_bo " Michal Wajdeczko
2024-07-09 14:43   ` Lucas De Marchi
2024-07-08 11:12 ` [PATCH 2/4] drm/xe/kunit: Simplify xe_dma_buf " Michal Wajdeczko
2024-07-09 14:45   ` Lucas De Marchi
2024-07-08 11:12 ` [PATCH 3/4] drm/xe/kunit: Simplify xe_migrate " Michal Wajdeczko
2024-07-09 14:46   ` Lucas De Marchi
2024-07-08 11:12 ` [PATCH 4/4] drm/xe/kunit: Simplify xe_mocs " Michal Wajdeczko
2024-07-09 14:52   ` Lucas De Marchi
2024-07-10 20:03     ` Kumar, Janga Rahul
2024-07-11 21:59       ` Lucas De Marchi
2024-07-08 11:18 ` ✓ CI.Patch_applied: success for drm/xe/kunit: Simplify " Patchwork
2024-07-08 11:18 ` Patchwork [this message]
2024-07-08 11:19 ` ✓ CI.KUnit: " Patchwork
2024-07-08 11:31 ` ✓ CI.Build: " Patchwork
2024-07-08 11:35 ` ✓ CI.Hooks: " Patchwork
2024-07-08 11:37 ` ✓ CI.checksparse: " Patchwork
2024-07-08 11:58 ` ✓ CI.BAT: " Patchwork
2024-07-08 14:01 ` ✗ CI.FULL: failure " Patchwork
2024-07-08 17:37   ` Michal Wajdeczko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=172043751545.49182.1205510070316770749@2413ebb6fbb6 \
    --to=patchwork@emeril.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=michal.wajdeczko@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox