Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Michal Wajdeczko" <michal.wajdeczko@intel.com>
Cc: intel-xe@lists.freedesktop.org
Subject: ✗ CI.checkpatch: warning for PF: threshold config fixes
Date: Fri, 30 Aug 2024 14:20:32 -0000	[thread overview]
Message-ID: <172502763243.854866.9279605004808596273@2413ebb6fbb6> (raw)
In-Reply-To: <20240830132100.1704-1-michal.wajdeczko@intel.com>

== Series Details ==

Series: PF: threshold config fixes
URL   : https://patchwork.freedesktop.org/series/138023/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
9fe5037901cabbcdf27a6fe0dfb047ca1474d363
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit d6e8d8f18dcd580e0e0897eba5e359fe2dc11ef0
Author: Michal Wajdeczko <michal.wajdeczko@intel.com>
Date:   Fri Aug 30 15:21:00 2024 +0200

    drm/xe/pf: Reset thresholds when releasing a VF config
    
    As part of the VF config release, we should reset all parameters,
    including thresholds, to always start with the clean VF config.
    
    Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
+ /mt/dim checkpatch 876db6b8ef45d285316cc53b5cf44cbc39aa8758 drm-intel
05d508ba75e3 drm/xe/pf: Add thresholds to the VF KLV config
-:21: WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#21: FILE: drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c:280:
+#define encode_threshold_config(TAG, ...) ({					\
+	cfg[n++] = PREP_GUC_KLV_TAG(VF_CFG_THRESHOLD_##TAG);			\
+	cfg[n++] = config->thresholds[MAKE_XE_GUC_KLV_THRESHOLD_INDEX(TAG)];	\
+});

total: 0 errors, 1 warnings, 0 checks, 14 lines checked
d6e8d8f18dcd drm/xe/pf: Reset thresholds when releasing a VF config
-:23: WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#23: FILE: drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c:1849:
+#define reset_threshold_config(TAG, ...) ({				\
+	config->thresholds[MAKE_XE_GUC_KLV_THRESHOLD_INDEX(TAG)] = 0;	\
+});

total: 0 errors, 1 warnings, 0 checks, 25 lines checked



  parent reply	other threads:[~2024-08-30 14:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-30 13:20 [PATCH 0/2] PF: threshold config fixes Michal Wajdeczko
2024-08-30 13:20 ` [PATCH 1/2] drm/xe/pf: Add thresholds to the VF KLV config Michal Wajdeczko
2024-09-02  9:36   ` Piotr Piórkowski
2024-08-30 13:21 ` [PATCH 2/2] drm/xe/pf: Reset thresholds when releasing a VF config Michal Wajdeczko
2024-09-02  9:37   ` Piotr Piórkowski
2024-08-30 14:20 ` ✓ CI.Patch_applied: success for PF: threshold config fixes Patchwork
2024-08-30 14:20 ` Patchwork [this message]
2024-08-30 14:21 ` ✓ CI.KUnit: " Patchwork
2024-08-30 14:33 ` ✓ CI.Build: " Patchwork
2024-08-30 14:36 ` ✓ CI.Hooks: " Patchwork
2024-08-30 14:37 ` ✓ CI.checksparse: " Patchwork
2024-08-30 14:57 ` ✓ CI.BAT: " Patchwork
2024-08-31  2:41 ` ✗ CI.FULL: failure " Patchwork
2024-09-02 18:44   ` Michal Wajdeczko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=172502763243.854866.9279605004808596273@2413ebb6fbb6 \
    --to=patchwork@emeril.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=michal.wajdeczko@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox