From: Gustavo Sousa <gustavo.sousa@intel.com>
To: Krzysztof Karas <krzysztof.karas@intel.com>
Cc: <intel-gfx@lists.freedesktop.org>, <intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915/dmc_wl: Do not check for DMC payload
Date: Fri, 31 Jan 2025 17:16:29 -0300 [thread overview]
Message-ID: <173835458986.77773.13912562984988802225@intel.com> (raw)
In-Reply-To: <l4ga4qidhl6d3fwknxtq2f6j5lcjf3thgeklehn7o7sjnstqe6@lscjymo6oaqh>
Quoting Krzysztof Karas (2025-01-30 11:18:28-03:00)
>Hi Gustavo,
>
>[...]
>> Let's remove that check, since it is unnecessary and causes the
>> inconsistency illustrated above.
>>
>> Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
>> ---
>
>Would you add:
>Fixes: c01e78a96e12 ("drm/i915/dmc_wl: Sanitize enable_dmc_wl according to hardware support")?
I believe the above commit should not be a "fixes" candidate, the check
for intel_dmc_has_payload() was already there when that commit was
applied.
Also, do we need a "Fixes:" tag here? There only platform where the DMC
Wakelock mechanism is enabled by default is PTL, which is still under
force_probe protection.
--
Gustavo Sousa
>
>after that LGTM:
>Reviewed-by: Krzysztof Karas <krzysztof.karas@intel.com>
>
>Krzysztof
next prev parent reply other threads:[~2025-01-31 20:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-24 19:12 [PATCH] drm/i915/dmc_wl: Do not check for DMC payload Gustavo Sousa
2025-01-24 21:36 ` ✓ CI.Patch_applied: success for " Patchwork
2025-01-24 21:36 ` ✓ CI.checkpatch: " Patchwork
2025-01-24 21:37 ` ✓ CI.KUnit: " Patchwork
2025-01-24 21:54 ` ✓ CI.Build: " Patchwork
2025-01-24 21:57 ` ✓ CI.Hooks: " Patchwork
2025-01-24 22:00 ` ✓ CI.checksparse: " Patchwork
2025-01-24 22:34 ` ✓ Xe.CI.BAT: " Patchwork
2025-01-25 4:42 ` ✗ Xe.CI.Full: failure " Patchwork
2025-02-05 11:57 ` Gustavo Sousa
2025-01-30 9:41 ` [PATCH] " Luca Coelho
2025-01-30 14:18 ` Krzysztof Karas
2025-01-31 20:16 ` Gustavo Sousa [this message]
2025-01-31 23:49 ` Lucas De Marchi
2025-02-03 11:44 ` Gustavo Sousa
2025-02-05 9:07 ` Krzysztof Karas
2025-02-05 14:18 ` Gustavo Sousa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173835458986.77773.13912562984988802225@intel.com \
--to=gustavo.sousa@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=krzysztof.karas@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox